Refactor svg stringifier #1593
Merged
Refactor svg stringifier #1593
+215
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TrySound
commented
Oct 1, 2021
TrySound
commented
- rewrote prototype class with functions
- covered with tsdoc
- added a few TODOs for v3
- rewrote prototype class with functions - covered with tsdoc - added a few TODOs for v3
omgovich
reviewed
Oct 1, 2021
lib/stringifier.js
Outdated
Comment on lines
27
to
54
| * @typedef {{ | ||
| * doctypeStart: string, | ||
| * doctypeEnd: string, | ||
| * procInstStart: string, | ||
| * procInstEnd: string, | ||
| * tagOpenStart: string, | ||
| * tagOpenEnd: string, | ||
| * tagCloseStart: string, | ||
| * tagCloseEnd: string, | ||
| * tagShortStart: string, | ||
| * tagShortEnd: string, | ||
| * attrStart: string, | ||
| * attrEnd: string, | ||
| * commentStart: string, | ||
| * commentEnd: string, | ||
| * cdataStart: string, | ||
| * cdataEnd: string, | ||
| * textStart: string, | ||
| * textEnd: string, | ||
| * indent: string, | ||
| * regEntities: RegExp, | ||
| * regValEntities: RegExp, | ||
| * encodeEntity: (char: string) => string, | ||
| * pretty: boolean, | ||
| * useShortTags: boolean | ||
| * eol: 'lf' | 'crlf', | ||
| * finalNewline: boolean, | ||
| * }} Options |
There was a problem hiding this comment.
Can't we replace that with @typedef {Required<StringifyOptions>} Options?
There was a problem hiding this comment.
indent types are different but maybe easier to store it in state instead
matheus1lva
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.