Refactor inlineStyles #1601
Merged
Refactor inlineStyles #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a big one - got rid from another closestByName usage - delegated removing empty defs elements to removeEmptyContainers plugin - got rid from all css-tools usages (most inlineStyles code was there for some reason) - combined a few loops - fixed useMqs option (I would remove it in v3 for simplicity as it seems nobody use it)
Closed
matheus1lva
reviewed
Oct 4, 2021
| const cssTools = require('../lib/css-tools'); | ||
| /** | ||
| * @typedef {import('../lib/types').Specificity} Specificity | ||
| * @typedef {import('../lib/types').XastElement} XastElement |
There was a problem hiding this comment.
i'm really starting to see the benefits of jsdocs inside a ts project. You can define your types outside, as plain ts files and use on js files :D
|
Ah yes, in the good old times (1, 2 years ago) svgo didn't use any TS features and I tried to isolate the CSS-related stuff into a separate object. |
matheus1lva
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one
for some reason)
seems nobody use it)
cc @strarsis