Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cross-env and rimraf so that tests work everywhere #1988

Merged
merged 1 commit into from May 14, 2024

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 8, 2024

Without this tests fail on Windows cmd (CI works because by default it's using bash)

Requires #1986 and #1987.

@XhmikosR XhmikosR changed the title chore: add cross-env so that tests work everywhere chore: add cross-env and rimraf so that tests work everywhere May 8, 2024
@XhmikosR XhmikosR force-pushed the xmr/cross-env branch 2 times, most recently from d0eb49b to 3e774fe Compare May 9, 2024 14:20
@XhmikosR XhmikosR marked this pull request as ready for review May 14, 2024 18:11
Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@SethFalco SethFalco merged commit 3c155cc into svg:main May 14, 2024
10 checks passed
@XhmikosR XhmikosR deleted the xmr/cross-env branch May 14, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants