Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop Node.js < 16 support #2002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 9, 2024

@SethFalco not sure if you want to drop support for Node.js 16 too, it doesn't seem needed AFAICT.

BTW Node.js 14 wasn't tested on CI on main.

@XhmikosR XhmikosR marked this pull request as ready for review May 9, 2024 14:19
@SethFalco
Copy link
Member

not sure if you want to drop support for Node.js 16 too

I was thining about that recently, and not sure yet myself. Node.js v16 is out of support, but their are still lots of projects/companies using it, including some of my clients (freelance), so I'm leaning towards keeping it, at least until we'd actually benefit doing something that requires v18.

Note: Our test code already requires Node.js v18 I believe, but atm the released build shouldn't.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented May 9, 2024

We can always cut a new major version if needed. Right now we don't seem to use any features from newer Node.js so I think we can keep Node.js 16 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants