Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining grouping in swagger #4246

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Defining grouping in swagger #4246

wants to merge 7 commits into from

Conversation

S66D
Copy link

@S66D S66D commented Sep 5, 2022

Defining grouping in swagger endpoints to reduce the challenges brought in creating a per class request models in huge system for better maintainability and for less class redundancy.

@S66D S66D changed the title Defining endpoints grouping in swagger Defining grouping in swagger Sep 5, 2022
@didjoman
Copy link

That Pull-Request would be SO helpful as it fixes a major bug (and thus lot of issues).
I was so happy when I saw it, and I am watching it for 4months now, but sadly it never gets approved :(
How could we fasten the approval of the PR :) ?

@mdaumen
Copy link

mdaumen commented Jan 26, 2023

I'm waiting on this too - it's maddening. I have a model class like this:

  @Schema(description = "Unique ksuid for this Event - returned on submission.", required = false)
  @NotEmpty(groups = {EventConsumerValidations.class})
  @Builder.Default
  private Optional<String> id = Optional.empty();

The idea is we want the validation after the object has been created with an id and not to have a client pass one in. I've tried required = false, I've tried a distinct @Schema annotation on the controller method that specifically omits that id field from the requiredProperties attribute. It's a huge omission. What is the hold-up with this PR?

@virgilsb
Copy link

I'm also looking forward to this.

@b-smets
Copy link

b-smets commented May 8, 2023

Any updates on this PR? Is there something I can assist with to get this merged?

@kangaroo1122
Copy link

Any updates?

@CatarinaRibas
Copy link

Do you have any updates on this?
Can I help with something in order to merge this? We really need this functionality.

Thank you in advance

@Mitic96
Copy link

Mitic96 commented Feb 1, 2024

Any updates?

This is a crucial functionality that would help many of us.
If there is anything that needs to be done before merging this PR, I propose for Maintainers to write the additional requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants