Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explictly WriteHeader before Write to avoid superfluous response.Writ… #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WqyJh
Copy link

@WqyJh WqyJh commented Feb 28, 2023

There're some situation when WriteHeader would be called after httpSwagger.Handler which may cause warning of http: superfluous response.WriteHeader call.

Simply add WriteHeader before write data to response solve this problem. The underlying webdav.Handler does the same and won't cause this problem.

Reference to https://github.com/golang/go/blob/72301a9863fb43ff26e9779a086e02cf02031ceb/src/net/http/clientserver_test.go#L1551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant