Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display free instead of used and with greater granularity if <1TiB #853

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Display free instead of used and with greater granularity if <1TiB #853

wants to merge 2 commits into from

Conversation

fiveangle
Copy link

@fiveangle fiveangle commented May 24, 2021

reporting used seems reasonable from a generic "disk info" standpoint, but the actual space available on each temp disk is really the only critical metric to plotter owners so we can see if we are getting too close to the edge

  • swap reported raw used with free
  • clarify % is % used
  • report disk sizes with more granularity if <1TiB

example:

image

reporting `used` seems reasonable from a generic "disk info" standpoint, but the actual space available on each temp disk is really the only critical metric to plotter owners so we can see if we are getting too close to the edge
.
@fiveangle fiveangle changed the title replace used with free for disk reports Display free instead of used and with greater granularity if <1TiB May 24, 2021
Copy link

@cherymann cherymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works on my system with the development branch

Copy link

@cherymann cherymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works on my system with the development branch

@creamsoup
Copy link

imo it should always display free. the free space is what we are interested. who cares how much it is used? fore those who cared should look at the farmer not plot manager. @swar, WDYT?

@fiveangle
Copy link
Author

well, if anyone wants this, feel free to install from https://github.com/fiveangle/Swar-Chia-Plot-Manager/tree/critical_temp_disk_info . I'll keep that branch live until this PR is either merged or will maintain indefinitely if the PR here is rejected. If I can find the time, I really want to add the feature to send SIGSTOP signal to the last-launched plot job if free goes below a configurable threshold, then send SIGCONT to the process once free goes above that threshold again (+hysteresis padding), to prevent ruining the entire staggered pipeline if temp is cut too close on space, but I've been on a long road trip so no time 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants