Skip to content

Commit

Permalink
test(es/minifier): Organize terser tests (#6247)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kdy1
kdy1 committed Oct 25, 2022
1 parent cb33fee commit 01edb4f
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 23 deletions.
4 changes: 0 additions & 4 deletions crates/swc_ecma_minifier/tests/TODO.txt
View file
Expand Up @@ -21,7 +21,6 @@ collapse_vars/chained_1/input.js
collapse_vars/chained_2/input.js
collapse_vars/chained_3/input.js
collapse_vars/collapse_vars_arguments/input.js
collapse_vars/collapse_vars_assignment/input.js
collapse_vars/collapse_vars_constants/input.js
collapse_vars/collapse_vars_do_while/input.js
collapse_vars/collapse_vars_do_while_drop_assign/input.js
Expand All @@ -34,7 +33,6 @@ collapse_vars/collapse_vars_short_circuit/input.js
collapse_vars/collapse_vars_short_circuited_conditions/input.js
collapse_vars/collapse_vars_side_effects_1/input.js
collapse_vars/collapse_vars_switch/input.js
collapse_vars/collapse_vars_unary/input.js
collapse_vars/cond_branch_1/input.js
collapse_vars/cond_branch_2/input.js
collapse_vars/double_def_1/input.js
Expand Down Expand Up @@ -72,8 +70,6 @@ collapse_vars/switch_case_1/input.js
collapse_vars/toplevel_single_reference/input.js
collapse_vars/undeclared/input.js
collapse_vars/unused_orig/input.js
collapse_vars/var_defs/input.js
collapse_vars/var_side_effects_2/input.js
conditionals/equality_conditionals_false/input.js
conditionals/ifs_5/input.js
conditionals/ifs_6/input.js
Expand Down
4 changes: 4 additions & 0 deletions crates/swc_ecma_minifier/tests/passing.txt
View file
Expand Up @@ -146,6 +146,7 @@ collapse_vars/collapse_rhs_undefined/input.js
collapse_vars/collapse_rhs_var/input.js
collapse_vars/collapse_rhs_vardef/input.js
collapse_vars/collapse_vars_array/input.js
collapse_vars/collapse_vars_assignment/input.js
collapse_vars/collapse_vars_closures/input.js
collapse_vars/collapse_vars_eval_and_with/input.js
collapse_vars/collapse_vars_issue_721/input.js
Expand All @@ -157,6 +158,7 @@ collapse_vars/collapse_vars_seq/input.js
collapse_vars/collapse_vars_side_effects_2/input.js
collapse_vars/collapse_vars_throw/input.js
collapse_vars/collapse_vars_try/input.js
collapse_vars/collapse_vars_unary/input.js
collapse_vars/collapse_vars_unary_2/input.js
collapse_vars/collapse_vars_while/input.js
collapse_vars/compound_assignment/input.js
Expand Down Expand Up @@ -246,7 +248,9 @@ collapse_vars/side_effects_property/input.js
collapse_vars/switch_case_2/input.js
collapse_vars/switch_case_3/input.js
collapse_vars/unsafe_builtin/input.js
collapse_vars/var_defs/input.js
collapse_vars/var_side_effects_1/input.js
collapse_vars/var_side_effects_2/input.js
collapse_vars/var_side_effects_3/input.js
comments/comment_moved_between_return_and_value/input.js
comments/preserve_comments_by_default/input.js
Expand Down
16 changes: 7 additions & 9 deletions .../swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_assignment/output.js
View file
Expand Up @@ -2,27 +2,25 @@ function log(x) {
return console.log(x), x;
}
function f0(c) {
var a = 3 / c;
return (a = a);
return 3 / c;
}
function f1(c) {
return 1 - 3 / c;
}
function f2(c) {
return log((c = 3 / c - 7));
return log(c = 3 / c - 7);
}
function f3(c) {
return log((c |= 3 / c - 7));
var a = 3 / c;
return log(c |= a - 7);
}
function f4(c) {
var b = 2;
return log((b += 3 / c));
return log(2 + 3 / c);
}
function f5(c) {
var b = 2;
return log((b += 3 / c));
return log(2 + 3 / c);
}
function f6(c) {
var b = g();
return log((b += 3 / c));
return log(b += 3 / c);
}
3 changes: 1 addition & 2 deletions crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_unary/output.js
View file
@@ -1,6 +1,5 @@
function f0(o, p) {
var x = o[p];
return delete x;
return o[p], !0;
}
function f1(n) {
return n > +!!n;
Expand Down
8 changes: 3 additions & 5 deletions crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_defs/output.js
View file
@@ -1,7 +1,5 @@
var f1 = function (x, y) {
var r = x + y,
a = r * r - r,
b = 7;
console.log(a + b);
var f1 = function(x, y) {
var r = x + y;
console.log(r * r - r + 7);
};
f1("1", 0);
7 changes: 4 additions & 3 deletions crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_side_effects_2/output.js
View file
@@ -1,6 +1,7 @@
var print = console.log.bind(console);
function foo(x) {
var twice = 2 * x.y;
print("Foo:", twice);
print("Foo:", 2 * x.y);
}
foo({ y: 10 });
foo({
y: 10
});

2 comments on commit 01edb4f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 01edb4f Previous: d454488 Ratio
es/full/bugs-1 413795 ns/iter (± 20077) 349641 ns/iter (± 44357) 1.18
es/full/minify/libraries/antd 2013578744 ns/iter (± 45413342) 1819594156 ns/iter (± 86792731) 1.11
es/full/minify/libraries/d3 390547845 ns/iter (± 31387493) 374216731 ns/iter (± 12062793) 1.04
es/full/minify/libraries/echarts 1704129352 ns/iter (± 31177238) 1542027844 ns/iter (± 38517855) 1.11
es/full/minify/libraries/jquery 114639845 ns/iter (± 2082991) 98677472 ns/iter (± 3358755) 1.16
es/full/minify/libraries/lodash 141321460 ns/iter (± 3149692) 116251622 ns/iter (± 6095309) 1.22
es/full/minify/libraries/moment 124155576 ns/iter (± 29574186) 58454524 ns/iter (± 2262474) 2.12
es/full/minify/libraries/react 25326873 ns/iter (± 2992753) 21986171 ns/iter (± 2630383) 1.15
es/full/minify/libraries/terser 312746776 ns/iter (± 9812501) 301479603 ns/iter (± 12736907) 1.04
es/full/minify/libraries/three 532482669 ns/iter (± 26915749) 553712441 ns/iter (± 22965989) 0.96
es/full/minify/libraries/typescript 3790116593 ns/iter (± 81660888) 3357040591 ns/iter (± 87282545) 1.13
es/full/minify/libraries/victory 782618271 ns/iter (± 59720608) 802509289 ns/iter (± 27404387) 0.98
es/full/minify/libraries/vue 172810089 ns/iter (± 3431816) 150304989 ns/iter (± 10686816) 1.15
es/full/codegen/es3 39429 ns/iter (± 2789) 33855 ns/iter (± 1345) 1.16
es/full/codegen/es5 40071 ns/iter (± 2865) 33876 ns/iter (± 5879) 1.18
es/full/codegen/es2015 38257 ns/iter (± 2807) 33760 ns/iter (± 592) 1.13
es/full/codegen/es2016 39066 ns/iter (± 1348) 33777 ns/iter (± 580) 1.16
es/full/codegen/es2017 38540 ns/iter (± 1958) 33730 ns/iter (± 851) 1.14
es/full/codegen/es2018 38611 ns/iter (± 1797) 33960 ns/iter (± 1897) 1.14
es/full/codegen/es2019 39887 ns/iter (± 2290) 34146 ns/iter (± 899) 1.17
es/full/codegen/es2020 38580 ns/iter (± 1494) 33737 ns/iter (± 928) 1.14
es/full/all/es3 222064422 ns/iter (± 5598935) 191400310 ns/iter (± 10434365) 1.16
es/full/all/es5 211399283 ns/iter (± 7327180) 178154930 ns/iter (± 8035487) 1.19
es/full/all/es2015 170894992 ns/iter (± 8554800) 144574571 ns/iter (± 5291355) 1.18
es/full/all/es2016 169573948 ns/iter (± 6334468) 141418382 ns/iter (± 4254339) 1.20
es/full/all/es2017 168610335 ns/iter (± 13425787) 141396756 ns/iter (± 5399823) 1.19
es/full/all/es2018 165343930 ns/iter (± 6897689) 138937474 ns/iter (± 6252164) 1.19
es/full/all/es2019 164164489 ns/iter (± 5571963) 139991806 ns/iter (± 7717894) 1.17
es/full/all/es2020 158988979 ns/iter (± 6146350) 133694156 ns/iter (± 4151785) 1.19
es/full/parser 805844 ns/iter (± 38088) 704487 ns/iter (± 35616) 1.14
es/full/base/fixer 29050 ns/iter (± 1785) 25351 ns/iter (± 1712) 1.15
es/full/base/resolver_and_hygiene 104876 ns/iter (± 7312) 88823 ns/iter (± 2450) 1.18
serialization of ast node 255 ns/iter (± 18) 213 ns/iter (± 4) 1.20
serialization of serde 245 ns/iter (± 14) 226 ns/iter (± 27) 1.08

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 01edb4f Previous: d454488 Ratio
es/full/minify/libraries/moment 124155576 ns/iter (± 29574186) 58454524 ns/iter (± 2262474) 2.12

This comment was automatically generated by workflow using github-action-benchmark.

CC: @kdy1

Please sign in to comment.