Skip to content

Commit

Permalink
build(bindings/node): Link msvc runtime statically (#7965)
Browse files Browse the repository at this point in the history 
Should resolve
#1351 (comment)

CI passed: https://github.com/swc-project/swc/actions/runs/6217017170
  • Loading branch information
@Brooooooklyn
Brooooooklyn committed Sep 18, 2023
1 parent f2baa7a commit 0759779
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .cargo/config.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ rustflags = ["-Z", "share-generics=y"]

[target.x86_64-pc-windows-msvc]
linker = "rust-lld"
rustflags = ["-C", "target-feature=+crt-static"]

[target.i686-pc-windows-msvc]
rustflags = ["-C", "target-feature=+crt-static"]

[target.aarch64-pc-windows-msvc]
linker = "rust-lld"
Expand Down

1 comment on commit 0759779

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0759779 Previous: 005ddc5 Ratio
es/full/bugs-1 284288 ns/iter (± 4333) 287147 ns/iter (± 3369) 0.99
es/full/minify/libraries/antd 1339990923 ns/iter (± 29802002) 1315250910 ns/iter (± 8355605) 1.02
es/full/minify/libraries/d3 277767508 ns/iter (± 7013031) 270384221 ns/iter (± 2226724) 1.03
es/full/minify/libraries/echarts 1063175059 ns/iter (± 6487519) 1041801950 ns/iter (± 9116454) 1.02
es/full/minify/libraries/jquery 85244523 ns/iter (± 303383) 83861529 ns/iter (± 522769) 1.02
es/full/minify/libraries/lodash 97759696 ns/iter (± 343111) 96256270 ns/iter (± 190929) 1.02
es/full/minify/libraries/moment 50156287 ns/iter (± 353677) 49242572 ns/iter (± 119572) 1.02
es/full/minify/libraries/react 18146674 ns/iter (± 91084) 17821477 ns/iter (± 63403) 1.02
es/full/minify/libraries/terser 218243657 ns/iter (± 798963) 215416750 ns/iter (± 1226391) 1.01
es/full/minify/libraries/three 384779742 ns/iter (± 1873928) 378658325 ns/iter (± 1669226) 1.02
es/full/minify/libraries/typescript 2632700624 ns/iter (± 11201493) 2628982565 ns/iter (± 81831128) 1.00
es/full/minify/libraries/victory 570264678 ns/iter (± 6561647) 555589689 ns/iter (± 5822602) 1.03
es/full/minify/libraries/vue 120548306 ns/iter (± 339272) 118086379 ns/iter (± 158279) 1.02
es/full/codegen/es3 34017 ns/iter (± 100) 34155 ns/iter (± 90) 1.00
es/full/codegen/es5 34084 ns/iter (± 450) 33998 ns/iter (± 174) 1.00
es/full/codegen/es2015 33881 ns/iter (± 870) 34259 ns/iter (± 66) 0.99
es/full/codegen/es2016 33895 ns/iter (± 160) 34310 ns/iter (± 98) 0.99
es/full/codegen/es2017 33943 ns/iter (± 88) 34159 ns/iter (± 68) 0.99
es/full/codegen/es2018 33982 ns/iter (± 143) 34188 ns/iter (± 89) 0.99
es/full/codegen/es2019 33916 ns/iter (± 83) 34243 ns/iter (± 96) 0.99
es/full/codegen/es2020 34023 ns/iter (± 170) 34066 ns/iter (± 129) 1.00
es/full/all/es3 167426210 ns/iter (± 1268935) 167307459 ns/iter (± 1554105) 1.00
es/full/all/es5 159507694 ns/iter (± 722208) 159250676 ns/iter (± 963415) 1.00
es/full/all/es2015 120558959 ns/iter (± 884583) 119401512 ns/iter (± 289031) 1.01
es/full/all/es2016 119422964 ns/iter (± 576822) 118329866 ns/iter (± 737952) 1.01
es/full/all/es2017 119406252 ns/iter (± 907664) 117975250 ns/iter (± 669969) 1.01
es/full/all/es2018 117510833 ns/iter (± 641603) 116351503 ns/iter (± 515268) 1.01
es/full/all/es2019 116468668 ns/iter (± 644604) 115262686 ns/iter (± 436980) 1.01
es/full/all/es2020 113262982 ns/iter (± 818260) 111056942 ns/iter (± 588570) 1.02
es/full/parser 487203 ns/iter (± 5011) 493035 ns/iter (± 4792) 0.99
es/full/base/fixer 18057 ns/iter (± 128) 17137 ns/iter (± 32) 1.05
es/full/base/resolver_and_hygiene 79667 ns/iter (± 213) 80549 ns/iter (± 230) 0.99
serialization of serde 292 ns/iter (± 0) 298 ns/iter (± 2) 0.98
css/minify/libraries/bootstrap 28774419 ns/iter (± 47848) 28742404 ns/iter (± 173553) 1.00
css/visitor/compare/clone 1650922 ns/iter (± 2289) 1647254 ns/iter (± 3521) 1.00
css/visitor/compare/visit_mut_span 1777042 ns/iter (± 2349) 1769345 ns/iter (± 4799) 1.00
css/visitor/compare/visit_mut_span_panic 1840262 ns/iter (± 2621) 1838307 ns/iter (± 3897) 1.00
css/visitor/compare/fold_span 2578886 ns/iter (± 10798) 2575277 ns/iter (± 6938) 1.00
css/visitor/compare/fold_span_panic 2756228 ns/iter (± 15845) 2761515 ns/iter (± 8237) 1.00
css/lexer/bootstrap_5_1_3 4424578 ns/iter (± 3069) 4441729 ns/iter (± 8505) 1.00
css/lexer/foundation_6_7_4 3727482 ns/iter (± 2239) 3711361 ns/iter (± 4079) 1.00
css/lexer/tailwind_3_1_1 709367 ns/iter (± 405) 705337 ns/iter (± 690) 1.01
css/parser/bootstrap_5_1_3 19362948 ns/iter (± 22529) 20073613 ns/iter (± 29576) 0.96
css/parser/foundation_6_7_4 15315620 ns/iter (± 957788) 16187765 ns/iter (± 16805) 0.95
css/parser/tailwind_3_1_1 3013019 ns/iter (± 4132) 3032788 ns/iter (± 2627) 0.99
es/codegen/colors 728220 ns/iter (± 397135) 727159 ns/iter (± 396415) 1.00
es/codegen/large 2887875 ns/iter (± 1524407) 3137675 ns/iter (± 1668181) 0.92
es/codegen/with-parser/colors 45072 ns/iter (± 584) 45098 ns/iter (± 528) 1.00
es/codegen/with-parser/large 488595 ns/iter (± 966) 487073 ns/iter (± 1464) 1.00
es/minify/libraries/antd 1128106730 ns/iter (± 7995833) 1135202348 ns/iter (± 10475899) 0.99
es/minify/libraries/d3 239565251 ns/iter (± 1714996) 237324822 ns/iter (± 461124) 1.01
es/minify/libraries/echarts 894182503 ns/iter (± 6125861) 888648479 ns/iter (± 7324949) 1.01
es/minify/libraries/jquery 73737946 ns/iter (± 219780) 73621265 ns/iter (± 323273) 1.00
es/minify/libraries/lodash 87452260 ns/iter (± 336768) 88012842 ns/iter (± 491492) 0.99
es/minify/libraries/moment 43527107 ns/iter (± 53101) 44981291 ns/iter (± 183544) 0.97
es/minify/libraries/react 16126644 ns/iter (± 354895) 16474751 ns/iter (± 97506) 0.98
es/minify/libraries/terser 186577612 ns/iter (± 606353) 187175597 ns/iter (± 3289798) 1.00
es/minify/libraries/three 320492858 ns/iter (± 1294011) 318779291 ns/iter (± 1896415) 1.01
es/minify/libraries/typescript 2213979380 ns/iter (± 8309090) 2234019955 ns/iter (± 10774778) 0.99
es/minify/libraries/victory 466938822 ns/iter (± 2031587) 465910053 ns/iter (± 1684387) 1.00
es/minify/libraries/vue 106363143 ns/iter (± 164776) 106135691 ns/iter (± 317023) 1.00
es/visitor/compare/clone 1948741 ns/iter (± 96169) 2013543 ns/iter (± 7404) 0.97
es/visitor/compare/visit_mut_span 2297335 ns/iter (± 2139) 2331858 ns/iter (± 4785) 0.99
es/visitor/compare/visit_mut_span_panic 2337293 ns/iter (± 6892) 2378770 ns/iter (± 3356) 0.98
es/visitor/compare/fold_span 3378172 ns/iter (± 7547) 3454471 ns/iter (± 8026) 0.98
es/visitor/compare/fold_span_panic 3516657 ns/iter (± 8311) 3566198 ns/iter (± 9088) 0.99
es/lexer/colors 12905 ns/iter (± 37) 13058 ns/iter (± 35) 0.99
es/lexer/angular 5987730 ns/iter (± 5438) 6076802 ns/iter (± 16285) 0.99
es/lexer/backbone 771646 ns/iter (± 654) 776538 ns/iter (± 2804) 0.99
es/lexer/jquery 4408600 ns/iter (± 5422) 4441461 ns/iter (± 12388) 0.99
es/lexer/jquery mobile 6773187 ns/iter (± 10142) 6763511 ns/iter (± 8886) 1.00
es/lexer/mootools 3518276 ns/iter (± 2863) 3522040 ns/iter (± 3988) 1.00
es/lexer/underscore 648645 ns/iter (± 1171) 656282 ns/iter (± 1028) 0.99
es/lexer/three 20986825 ns/iter (± 33408) 21178349 ns/iter (± 42284) 0.99
es/lexer/yui 3767300 ns/iter (± 7712) 3796542 ns/iter (± 3714) 0.99
es/parser/colors 27217 ns/iter (± 164) 27185 ns/iter (± 63) 1.00
es/parser/angular 13487693 ns/iter (± 55096) 13373462 ns/iter (± 47582) 1.01
es/parser/backbone 1989711 ns/iter (± 20106) 1956229 ns/iter (± 7921) 1.02
es/parser/jquery 10850720 ns/iter (± 61004) 10695507 ns/iter (± 35498) 1.01
es/parser/jquery mobile 16552003 ns/iter (± 57123) 16523123 ns/iter (± 57141) 1.00
es/parser/mootools 8341680 ns/iter (± 22142) 8230252 ns/iter (± 18479) 1.01
es/parser/underscore 1709840 ns/iter (± 10967) 1678517 ns/iter (± 9047) 1.02
es/parser/three 48971040 ns/iter (± 395738) 45717761 ns/iter (± 111293) 1.07
es/parser/yui 8362840 ns/iter (± 31723) 8157472 ns/iter (± 29798) 1.03
es/preset-env/usage/builtin_type 138151 ns/iter (± 33373) 138110 ns/iter (± 32749) 1.00
es/preset-env/usage/property 17087 ns/iter (± 38) 17003 ns/iter (± 126) 1.00
es/resolver/typescript 91486948 ns/iter (± 2667177) 92187890 ns/iter (± 2165803) 0.99
es/fixer/typescript 63743385 ns/iter (± 662702) 64860537 ns/iter (± 962490) 0.98
es/hygiene/typescript 131281388 ns/iter (± 862446) 134338952 ns/iter (± 1083067) 0.98
es/resolver_with_hygiene/typescript 241714333 ns/iter (± 691799) 249017735 ns/iter (± 1890629) 0.97
es/visitor/base-perf/module_clone 58888 ns/iter (± 241) 59449 ns/iter (± 312) 0.99
es/visitor/base-perf/fold_empty 62954 ns/iter (± 350) 63861 ns/iter (± 134) 0.99
es/visitor/base-perf/fold_noop_impl_all 63134 ns/iter (± 284) 63779 ns/iter (± 240) 0.99
es/visitor/base-perf/fold_noop_impl_vec 63836 ns/iter (± 293) 64049 ns/iter (± 330) 1.00
es/visitor/base-perf/boxing_boxed_clone 57 ns/iter (± 0) 56 ns/iter (± 0) 1.02
es/visitor/base-perf/boxing_unboxed_clone 47 ns/iter (± 0) 40 ns/iter (± 0) 1.18
es/visitor/base-perf/boxing_boxed 108 ns/iter (± 0) 109 ns/iter (± 0) 0.99
es/visitor/base-perf/boxing_unboxed 82 ns/iter (± 0) 78 ns/iter (± 0) 1.05
es/visitor/base-perf/visit_empty 0 ns/iter (± 0) 0 ns/iter (± 0) NaN
es/visitor/base-perf/visit_contains_this 2507 ns/iter (± 9) 2542 ns/iter (± 13) 0.99
es/base/parallel/resolver/typescript 4532750892 ns/iter (± 302430037) 4369952616 ns/iter (± 242367012) 1.04
es/base/parallel/hygiene/typescript 1451490803 ns/iter (± 22062989) 1477587054 ns/iter (± 25696839) 0.98
misc/visitors/time-complexity/time 5 150 ns/iter (± 0) 150 ns/iter (± 0) 1
misc/visitors/time-complexity/time 10 452 ns/iter (± 0) 421 ns/iter (± 0) 1.07
misc/visitors/time-complexity/time 15 787 ns/iter (± 6) 787 ns/iter (± 3) 1
misc/visitors/time-complexity/time 20 1280 ns/iter (± 0) 1447 ns/iter (± 12) 0.88
misc/visitors/time-complexity/time 40 4348 ns/iter (± 7) 4360 ns/iter (± 17) 1.00
misc/visitors/time-complexity/time 60 9002 ns/iter (± 5) 10592 ns/iter (± 9) 0.85
es/full-target/es2016 230035 ns/iter (± 822) 227655 ns/iter (± 838) 1.01
es/full-target/es2017 218277 ns/iter (± 772) 216040 ns/iter (± 550) 1.01
es/full-target/es2018 206665 ns/iter (± 478) 206036 ns/iter (± 786) 1.00
es2020_nullish_coalescing 69318 ns/iter (± 215) 69709 ns/iter (± 409) 0.99
es2020_optional_chaining 75164 ns/iter (± 191) 75600 ns/iter (± 233) 0.99
es2022_class_properties 115364 ns/iter (± 426) 115249 ns/iter (± 229) 1.00
es2018_object_rest_spread 72827 ns/iter (± 220) 74606 ns/iter (± 322) 0.98
es2019_optional_catch_binding 63539 ns/iter (± 255) 64052 ns/iter (± 308) 0.99
es2017_async_to_generator 62711 ns/iter (± 130) 64158 ns/iter (± 151) 0.98
es2016_exponentiation 67158 ns/iter (± 214) 68457 ns/iter (± 146) 0.98
es2015_arrow 69762 ns/iter (± 171) 70753 ns/iter (± 259) 0.99
es2015_block_scoped_fn 67254 ns/iter (± 648) 67889 ns/iter (± 215) 0.99
es2015_block_scoping 119977 ns/iter (± 494) 119349 ns/iter (± 403) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.