Skip to content

Commit

Permalink
chore(es/minifier): Expose globals_defs pass (#6633)
Browse files Browse the repository at this point in the history
  • Loading branch information
@hyf0
hyf0 committed Dec 13, 2022
1 parent afe174d commit 08ccb83
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/swc_ecma_minifier/src/lib.rs
View file
Expand Up @@ -45,7 +45,7 @@ use swc_ecma_usage_analyzer::marks::Marks;
use swc_ecma_visit::VisitMutWith;
use swc_timer::timer;

pub use crate::pass::unique_scope::unique_scope;
pub use crate::pass::{global_defs::globals_defs, unique_scope::unique_scope};
use crate::{
compress::{compressor, pure_optimizer, PureOptimizerConfig},
metadata::info_marker,
Expand Down

1 comment on commit 08ccb83

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 08ccb83 Previous: d3fbfff Ratio
es/full/bugs-1 303776 ns/iter (± 6865) 295158 ns/iter (± 16597) 1.03
es/full/minify/libraries/antd 1845162605 ns/iter (± 16448442) 1657317663 ns/iter (± 22724123) 1.11
es/full/minify/libraries/d3 370059442 ns/iter (± 7252804) 341011595 ns/iter (± 4281830) 1.09
es/full/minify/libraries/echarts 1530883062 ns/iter (± 18861638) 1407984156 ns/iter (± 6870911) 1.09
es/full/minify/libraries/jquery 94478493 ns/iter (± 1267837) 91794669 ns/iter (± 743830) 1.03
es/full/minify/libraries/lodash 115256820 ns/iter (± 1840597) 111295857 ns/iter (± 783505) 1.04
es/full/minify/libraries/moment 55661934 ns/iter (± 872357) 54172703 ns/iter (± 574353) 1.03
es/full/minify/libraries/react 20413697 ns/iter (± 166351) 19647067 ns/iter (± 131281) 1.04
es/full/minify/libraries/terser 286097305 ns/iter (± 5769196) 262507498 ns/iter (± 1952909) 1.09
es/full/minify/libraries/three 526876309 ns/iter (± 9893060) 503863969 ns/iter (± 6007056) 1.05
es/full/minify/libraries/typescript 3434112004 ns/iter (± 22644063) 3186366093 ns/iter (± 20959331) 1.08
es/full/minify/libraries/victory 793423172 ns/iter (± 12500539) 709958852 ns/iter (± 10090662) 1.12
es/full/minify/libraries/vue 144916683 ns/iter (± 3161580) 137082098 ns/iter (± 1655969) 1.06
es/full/codegen/es3 27325 ns/iter (± 53) 27861 ns/iter (± 67) 0.98
es/full/codegen/es5 27314 ns/iter (± 81) 27838 ns/iter (± 63) 0.98
es/full/codegen/es2015 27312 ns/iter (± 59) 27848 ns/iter (± 58) 0.98
es/full/codegen/es2016 27320 ns/iter (± 58) 27819 ns/iter (± 44) 0.98
es/full/codegen/es2017 27317 ns/iter (± 49) 27831 ns/iter (± 53) 0.98
es/full/codegen/es2018 27271 ns/iter (± 63) 27874 ns/iter (± 80) 0.98
es/full/codegen/es2019 27279 ns/iter (± 67) 27834 ns/iter (± 55) 0.98
es/full/codegen/es2020 27340 ns/iter (± 75) 27804 ns/iter (± 51) 0.98
es/full/all/es3 170147847 ns/iter (± 5045637) 168052115 ns/iter (± 2763770) 1.01
es/full/all/es5 160743500 ns/iter (± 4086110) 159972182 ns/iter (± 1497603) 1.00
es/full/all/es2015 120176485 ns/iter (± 1120410) 120641921 ns/iter (± 1262253) 1.00
es/full/all/es2016 119818889 ns/iter (± 1210850) 119489924 ns/iter (± 895214) 1.00
es/full/all/es2017 118660706 ns/iter (± 1826616) 118496335 ns/iter (± 868721) 1.00
es/full/all/es2018 117898322 ns/iter (± 3913535) 116502309 ns/iter (± 946185) 1.01
es/full/all/es2019 117055186 ns/iter (± 1648719) 116073406 ns/iter (± 1091572) 1.01
es/full/all/es2020 112595176 ns/iter (± 2851320) 112012072 ns/iter (± 1045645) 1.01
es/full/parser 507700 ns/iter (± 8607) 520989 ns/iter (± 6587) 0.97
es/full/base/fixer 21861 ns/iter (± 32) 22004 ns/iter (± 26) 0.99
es/full/base/resolver_and_hygiene 78474 ns/iter (± 124) 78844 ns/iter (± 486) 1.00
serialization of ast node 121 ns/iter (± 0) 121 ns/iter (± 0) 1
serialization of serde 125 ns/iter (± 0) 125 ns/iter (± 0) 1
css/minify/libraries/bootstrap 27362226 ns/iter (± 178395) 27050361 ns/iter (± 219971) 1.01
css/visitor/compare/clone 2069058 ns/iter (± 11886) 2058202 ns/iter (± 22293) 1.01
css/visitor/compare/visit_mut_span 2245462 ns/iter (± 3387) 2253598 ns/iter (± 18706) 1.00
css/visitor/compare/visit_mut_span_panic 2305180 ns/iter (± 9472) 2288864 ns/iter (± 6217) 1.01
css/visitor/compare/fold_span 2956698 ns/iter (± 17474) 3000081 ns/iter (± 17399) 0.99
css/visitor/compare/fold_span_panic 3103785 ns/iter (± 11470) 3113108 ns/iter (± 16910) 1.00
css/lexer/bootstrap_5_1_3 5186733 ns/iter (± 1032) 5187977 ns/iter (± 1517) 1.00
css/lexer/foundation_6_7_4 4399456 ns/iter (± 1446) 4402964 ns/iter (± 4087) 1.00
css/lexer/tailwind_3_1_1 824374 ns/iter (± 3616) 826628 ns/iter (± 415) 1.00
css/parser/bootstrap_5_1_3 21005076 ns/iter (± 102899) 20830959 ns/iter (± 74649) 1.01
css/parser/foundation_6_7_4 16600088 ns/iter (± 43725) 16585151 ns/iter (± 65422) 1.00
css/parser/tailwind_3_1_1 3187882 ns/iter (± 5613) 3219653 ns/iter (± 3887) 0.99
es/codegen/colors 323882 ns/iter (± 181451) 331266 ns/iter (± 186531) 0.98
es/codegen/large 1226113 ns/iter (± 635685) 1075628 ns/iter (± 550360) 1.14
es/codegen/with-parser/colors 46569 ns/iter (± 352) 46333 ns/iter (± 459) 1.01
es/codegen/with-parser/large 514141 ns/iter (± 2456) 511798 ns/iter (± 656) 1.00
es/minify/libraries/antd 1578295459 ns/iter (± 13900468) 1448109856 ns/iter (± 17898463) 1.09
es/minify/libraries/d3 306934144 ns/iter (± 3201295) 298876933 ns/iter (± 5106427) 1.03
es/minify/libraries/echarts 1315471777 ns/iter (± 11384964) 1222520789 ns/iter (± 9365098) 1.08
es/minify/libraries/jquery 81760366 ns/iter (± 741435) 78413478 ns/iter (± 666848) 1.04
es/minify/libraries/lodash 101031919 ns/iter (± 1263705) 97382574 ns/iter (± 528676) 1.04
es/minify/libraries/moment 47106376 ns/iter (± 557651) 45921637 ns/iter (± 190672) 1.03
es/minify/libraries/react 17748840 ns/iter (± 191692) 17244576 ns/iter (± 131688) 1.03
es/minify/libraries/terser 234843234 ns/iter (± 4232659) 220151442 ns/iter (± 3179927) 1.07
es/minify/libraries/three 437424574 ns/iter (± 6367977) 392003164 ns/iter (± 7965818) 1.12
es/minify/libraries/typescript 2927844859 ns/iter (± 15472052) 2667945053 ns/iter (± 9859656) 1.10
es/minify/libraries/victory 678363858 ns/iter (± 12476552) 574631905 ns/iter (± 8557204) 1.18
es/minify/libraries/vue 123533815 ns/iter (± 1622976) 118218615 ns/iter (± 879471) 1.04
es/visitor/compare/clone 2401108 ns/iter (± 3629) 2442994 ns/iter (± 6666) 0.98
es/visitor/compare/visit_mut_span 2789884 ns/iter (± 10960) 2796636 ns/iter (± 11616) 1.00
es/visitor/compare/visit_mut_span_panic 2885309 ns/iter (± 17527) 2848547 ns/iter (± 6808) 1.01
es/visitor/compare/fold_span 4000155 ns/iter (± 16191) 3948718 ns/iter (± 7483) 1.01
es/visitor/compare/fold_span_panic 4151333 ns/iter (± 32541) 4088416 ns/iter (± 15728) 1.02
es/lexer/colors 17352 ns/iter (± 10) 17568 ns/iter (± 14) 0.99
es/lexer/angular 8223938 ns/iter (± 9606) 8275747 ns/iter (± 3086) 0.99
es/lexer/backbone 1071251 ns/iter (± 344) 1081500 ns/iter (± 817) 0.99
es/lexer/jquery 5940937 ns/iter (± 8797) 5973630 ns/iter (± 2471) 0.99
es/lexer/jquery mobile 9152546 ns/iter (± 3492) 9220729 ns/iter (± 5415) 0.99
es/lexer/mootools 4667370 ns/iter (± 2934) 4696013 ns/iter (± 2651) 0.99
es/lexer/underscore 891852 ns/iter (± 350) 899979 ns/iter (± 369) 0.99
es/lexer/three 27829811 ns/iter (± 12970) 28011804 ns/iter (± 19507) 0.99
es/lexer/yui 5052587 ns/iter (± 2525) 5079597 ns/iter (± 3599) 0.99
es/parser/colors 30814 ns/iter (± 166) 30574 ns/iter (± 147) 1.01
es/parser/angular 16018576 ns/iter (± 150822) 15507928 ns/iter (± 254857) 1.03
es/parser/backbone 2342028 ns/iter (± 15425) 2305407 ns/iter (± 11158) 1.02
es/parser/jquery 12907197 ns/iter (± 190091) 12518765 ns/iter (± 125536) 1.03
es/parser/jquery mobile 21041204 ns/iter (± 388575) 20516197 ns/iter (± 265117) 1.03
es/parser/mootools 9732033 ns/iter (± 71602) 9610213 ns/iter (± 46198) 1.01
es/parser/underscore 1973802 ns/iter (± 12370) 1959447 ns/iter (± 11511) 1.01
es/parser/three 61662985 ns/iter (± 193378) 59680370 ns/iter (± 254616) 1.03
es/parser/yui 9702513 ns/iter (± 102431) 9547901 ns/iter (± 72234) 1.02
es/preset-env/usage/builtin_type 139647 ns/iter (± 31183) 141457 ns/iter (± 32118) 0.99
es/preset-env/usage/property 21505 ns/iter (± 85) 21168 ns/iter (± 89) 1.02
es/resolver/typescript 121649364 ns/iter (± 2279026) 109444785 ns/iter (± 2812212) 1.11
es/fixer/typescript 99532274 ns/iter (± 1054082) 87084757 ns/iter (± 1009739) 1.14
es/hygiene/typescript 197181350 ns/iter (± 1076569) 168537812 ns/iter (± 1511277) 1.17
es/resolver_with_hygiene/typescript 335454496 ns/iter (± 3723323) 296952808 ns/iter (± 878191) 1.13
es/visitor/base-perf/module_clone 74009 ns/iter (± 1169) 74004 ns/iter (± 936) 1.00
es/visitor/base-perf/fold_empty 85032 ns/iter (± 1279) 87964 ns/iter (± 1715) 0.97
es/visitor/base-perf/fold_noop_impl_all 85040 ns/iter (± 525) 86992 ns/iter (± 1697) 0.98
es/visitor/base-perf/fold_noop_impl_vec 85954 ns/iter (± 1661) 85782 ns/iter (± 1975) 1.00
es/visitor/base-perf/boxing_boxed_clone 54 ns/iter (± 0) 54 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 58 ns/iter (± 0) 61 ns/iter (± 0) 0.95
es/visitor/base-perf/boxing_boxed 99 ns/iter (± 0) 100 ns/iter (± 0) 0.99
es/visitor/base-perf/boxing_unboxed 100 ns/iter (± 0) 100 ns/iter (± 0) 1
es/visitor/base-perf/visit_contains_this 3483 ns/iter (± 63) 3400 ns/iter (± 36) 1.02
es/base/parallel/resolver/typescript 6124939990 ns/iter (± 385003413) 5543557325 ns/iter (± 284616248) 1.10
es/base/parallel/hygiene/typescript 2259058215 ns/iter (± 44524735) 2003911087 ns/iter (± 29615238) 1.13
misc/visitors/time-complexity/time 5 92 ns/iter (± 0) 92 ns/iter (± 0) 1
misc/visitors/time-complexity/time 10 304 ns/iter (± 8) 299 ns/iter (± 3) 1.02
misc/visitors/time-complexity/time 15 619 ns/iter (± 5) 606 ns/iter (± 1) 1.02
misc/visitors/time-complexity/time 20 1124 ns/iter (± 1) 1126 ns/iter (± 2) 1.00
misc/visitors/time-complexity/time 40 5963 ns/iter (± 19) 5933 ns/iter (± 34) 1.01
misc/visitors/time-complexity/time 60 15265 ns/iter (± 86) 15089 ns/iter (± 46) 1.01
es/full-target/es2016 187839 ns/iter (± 799) 187614 ns/iter (± 561) 1.00
es/full-target/es2017 181522 ns/iter (± 633) 181105 ns/iter (± 886) 1.00
es/full-target/es2018 170964 ns/iter (± 726) 170395 ns/iter (± 669) 1.00
es2020_nullish_coalescing 65730 ns/iter (± 106) 65393 ns/iter (± 268) 1.01
es2020_optional_chaining 94476 ns/iter (± 243) 94378 ns/iter (± 322) 1.00
es2022_class_properties 92362 ns/iter (± 147) 91745 ns/iter (± 377) 1.01
es2018_object_rest_spread 70534 ns/iter (± 100) 70174 ns/iter (± 1059) 1.01
es2019_optional_catch_binding 60099 ns/iter (± 124) 59862 ns/iter (± 173) 1.00
es2017_async_to_generator 60505 ns/iter (± 104) 60207 ns/iter (± 193) 1.00
es2016_exponentiation 63589 ns/iter (± 113) 63898 ns/iter (± 550) 1.00
es2015_arrow 69201 ns/iter (± 228) 68356 ns/iter (± 259) 1.01
es2015_block_scoped_fn 64875 ns/iter (± 100) 64714 ns/iter (± 191) 1.00
es2015_block_scoping 139942 ns/iter (± 9785) 149903 ns/iter (± 8354) 0.93
es2015_classes 114948 ns/iter (± 517) 113476 ns/iter (± 553) 1.01
es2015_computed_props 59977 ns/iter (± 95) 59481 ns/iter (± 187) 1.01
es2015_destructuring 114783 ns/iter (± 232) 114292 ns/iter (± 389) 1.00
es2015_duplicate_keys 62683 ns/iter (± 74) 62226 ns/iter (± 174) 1.01
es2015_parameters 78534 ns/iter (± 136) 77466 ns/iter (± 242) 1.01
es2015_fn_name 65751 ns/iter (± 619) 65106 ns/iter (± 434) 1.01
es2015_for_of 63056 ns/iter (± 70) 62626 ns/iter (± 286) 1.01
es2015_instanceof 62038 ns/iter (± 114) 61719 ns/iter (± 141) 1.01
es2015_shorthand_property 60235 ns/iter (± 128) 59778 ns/iter (± 95) 1.01
es2015_spread 60009 ns/iter (± 109) 59774 ns/iter (± 79) 1.00
es2015_sticky_regex 60882 ns/iter (± 95) 60923 ns/iter (± 97) 1.00
es2015_typeof_symbol 61171 ns/iter (± 88) 61266 ns/iter (± 110) 1.00
es/transform/baseline/base 50687 ns/iter (± 117) 50644 ns/iter (± 72) 1.00
es/transform/baseline/common_reserved_word 61466 ns/iter (± 158) 61511 ns/iter (± 80) 1.00
es/transform/baseline/common_typescript 142065 ns/iter (± 1364) 150271 ns/iter (± 12076) 0.95
es/target/es3 169408 ns/iter (± 184) 168327 ns/iter (± 582) 1.01
es/target/es2015 627439 ns/iter (± 1340) 628413 ns/iter (± 1380) 1.00
es/target/es2016 63736 ns/iter (± 129) 63973 ns/iter (± 97) 1.00
es/target/es2017 60764 ns/iter (± 104) 60704 ns/iter (± 191) 1.00
es/target/es2018 80843 ns/iter (± 45) 80467 ns/iter (± 144) 1.00
es/target/es2020 131677 ns/iter (± 227) 130699 ns/iter (± 437) 1.01
babelify-only 662431 ns/iter (± 933) 654476 ns/iter (± 2308) 1.01
parse_and_babelify_angular 43547409 ns/iter (± 403685) 41745378 ns/iter (± 351959) 1.04
parse_and_babelify_backbone 5542062 ns/iter (± 85907) 5273105 ns/iter (± 91552) 1.05
parse_and_babelify_jquery 33674568 ns/iter (± 752682) 31591608 ns/iter (± 164197) 1.07
parse_and_babelify_jquery_mobile 58952023 ns/iter (± 1396704) 53990560 ns/iter (± 563011) 1.09
parse_and_babelify_mootools 34709569 ns/iter (± 673116) 32379824 ns/iter (± 471134) 1.07
parse_and_babelify_underscore 4331184 ns/iter (± 37991) 4291430 ns/iter (± 30684) 1.01
parse_and_babelify_yui 34433015 ns/iter (± 510403) 32691833 ns/iter (± 284476) 1.05
html/minify/document/css_spec 42307283 ns/iter (± 222701) 42141532 ns/iter (± 375192) 1.00
html/minify/document/github 17613077 ns/iter (± 49626) 17458912 ns/iter (± 133305) 1.01
html/minify/document/stackoverflow 15742218 ns/iter (± 76436) 15649741 ns/iter (± 37024) 1.01
html/minify/document_fragment/css_spec 41250042 ns/iter (± 318346) 40501560 ns/iter (± 515706) 1.02
html/minify/document_fragment/github 16851872 ns/iter (± 51625) 16641375 ns/iter (± 65743) 1.01
html/minify/document_fragment/stackoverflow 15426012 ns/iter (± 99063) 15120650 ns/iter (± 24045) 1.02
html/document/visitor/compare/clone 341367 ns/iter (± 2263) 336089 ns/iter (± 2702) 1.02
html/document/visitor/compare/visit_mut_span 364488 ns/iter (± 1762) 366296 ns/iter (± 2717) 1.00
html/document/visitor/compare/visit_mut_span_panic 380599 ns/iter (± 1515) 375608 ns/iter (± 2220) 1.01
html/document/visitor/compare/fold_span 407655 ns/iter (± 1735) 399549 ns/iter (± 2329) 1.02
html/document/visitor/compare/fold_span_panic 464198 ns/iter (± 2580) 461965 ns/iter (± 27378) 1.00
html/document_fragment/visitor/compare/clone 342110 ns/iter (± 2074) 338579 ns/iter (± 1760) 1.01
html/document_fragment/visitor/compare/visit_mut_span 369967 ns/iter (± 1857) 364392 ns/iter (± 2038) 1.02
html/document_fragment/visitor/compare/visit_mut_span_panic 372630 ns/iter (± 2714) 371022 ns/iter (± 3113) 1.00
html/document_fragment/visitor/compare/fold_span 404026 ns/iter (± 1990) 404060 ns/iter (± 1994) 1.00
html/document_fragment/visitor/compare/fold_span_panic 456174 ns/iter (± 2130) 460841 ns/iter (± 2806) 0.99
html/lexer/css_2021_spec 15604431 ns/iter (± 17936) 15614469 ns/iter (± 8284) 1.00
html/lexer/github_com_17_05_2022 6051207 ns/iter (± 2323) 6052616 ns/iter (± 1437) 1.00
html/lexer/stackoverflow_com_17_05_2022 5656688 ns/iter (± 2702) 5656080 ns/iter (± 2379) 1.00
html/parser/parser_document/css_2021_spec 26217067 ns/iter (± 215392) 26880726 ns/iter (± 287310) 0.98
html/parser/parser_document/github_com_17_05_2022 8747196 ns/iter (± 13850) 8757394 ns/iter (± 13753) 1.00
html/parser/parser_document/stackoverflow_com_17_05_2022 7698225 ns/iter (± 9427) 7759299 ns/iter (± 43442) 0.99
html/parser/parser_document_fragment/css_2021_spec 26737710 ns/iter (± 372956) 26139262 ns/iter (± 161848) 1.02
html/parser/parser_document_fragment/github_com_17_05_2022 8788655 ns/iter (± 26975) 8819209 ns/iter (± 25266) 1.00
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7732552 ns/iter (± 5161) 7699188 ns/iter (± 17528) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.