Skip to content

Commit

Permalink
chore(ci): Enforce clippy for all targets (#6299)
Browse files Browse the repository at this point in the history
  • Loading branch information
kdy1 committed Oct 31, 2022
1 parent 33d83ae commit 0967e8f
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/CI.yml
Expand Up @@ -38,13 +38,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
submodules: true

- uses: actions-rs/toolchain@v1
with:
profile: minimal
components: clippy

- run: cargo clippy --all -- -D warnings
- run: cargo clippy --all --all-targets -- -D warnings

cargo-crev:
name: Cargo crev
Expand Down
2 changes: 1 addition & 1 deletion crates/swc_css_modules/tests/fixture.rs
Expand Up @@ -43,7 +43,7 @@ fn imports(input: PathBuf) {

#[testing::fixture("tests/fixture/**/*.css", exclude("compiled\\.css"))]
fn compile(input: PathBuf) {
testing::run_test(false, |cm, handler| {
testing::run_test(false, |cm, _| {
let fm = cm.load_file(&input).unwrap();
let mut errors = vec![];
let mut ss = swc_css_parser::parse_file(
Expand Down
2 changes: 1 addition & 1 deletion crates/swc_ecma_codegen/benches/bench.rs
Expand Up @@ -114,7 +114,7 @@ fn bench_emitter(b: &mut Bencher, s: &str) {
let _ = emitter.emit_module(&module);
}
black_box(buf);
let srcmap = cm.build_source_map(&mut src_map_buf);
let srcmap = cm.build_source_map(&src_map_buf);
black_box(srcmap);
});
Ok(())
Expand Down
2 changes: 1 addition & 1 deletion crates/swc_ecma_codegen/benches/with_parse.rs
Expand Up @@ -113,7 +113,7 @@ fn bench_emitter(b: &mut Bencher, s: &str) {
let _ = emitter.emit_module(&module);
}
black_box(buf);
let srcmap = cm.build_source_map(&mut src_map_buf);
let srcmap = cm.build_source_map(&src_map_buf);
black_box(srcmap);
});
Ok(())
Expand Down
2 changes: 1 addition & 1 deletion crates/swc_ecma_codegen/examples/sourcemap.rs
Expand Up @@ -45,7 +45,7 @@ fn parse_and_gen(entry: &Path) {
emitter.emit_module(&m).unwrap();
}

let srcmap = cm.build_source_map(&mut srcmap);
let srcmap = cm.build_source_map(&srcmap);

fs::write("output.js", &code).unwrap();

Expand Down
2 changes: 1 addition & 1 deletion crates/swc_ecma_codegen/tests/sourcemap.rs
Expand Up @@ -352,7 +352,7 @@ fn identity(entry: PathBuf) {
}

let actual_code = String::from_utf8(wr).unwrap();
let actual_map = cm.build_source_map_with_config(&mut src_map, None, SourceMapConfigImpl);
let actual_map = cm.build_source_map_with_config(&src_map, None, SourceMapConfigImpl);

let visualizer_url_for_actual = visualizer_url(&actual_code, &actual_map);

Expand Down

1 comment on commit 0967e8f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0967e8f Previous: aa18612 Ratio
es/full/bugs-1 421728 ns/iter (± 57912) 351971 ns/iter (± 20548) 1.20
es/full/minify/libraries/antd 2231201446 ns/iter (± 332358325) 1875886032 ns/iter (± 53111060) 1.19
es/full/minify/libraries/d3 490219091 ns/iter (± 20524134) 411103145 ns/iter (± 12359547) 1.19
es/full/minify/libraries/echarts 1854911157 ns/iter (± 96606898) 1624703672 ns/iter (± 79742447) 1.14
es/full/minify/libraries/jquery 134039899 ns/iter (± 10585721) 102824100 ns/iter (± 5093030) 1.30
es/full/minify/libraries/lodash 162215410 ns/iter (± 6586077) 119810701 ns/iter (± 9080479) 1.35
es/full/minify/libraries/moment 73512775 ns/iter (± 8409508) 61544495 ns/iter (± 5829520) 1.19
es/full/minify/libraries/react 25895674 ns/iter (± 3296036) 20428021 ns/iter (± 311051) 1.27
es/full/minify/libraries/terser 387786637 ns/iter (± 17576130) 315736125 ns/iter (± 17896768) 1.23
es/full/minify/libraries/three 666473578 ns/iter (± 47406577) 586047547 ns/iter (± 66980698) 1.14
es/full/minify/libraries/typescript 4111655570 ns/iter (± 152213724) 3793645317 ns/iter (± 261847808) 1.08
es/full/minify/libraries/victory 864666903 ns/iter (± 25426307) 917659503 ns/iter (± 73381197) 0.94
es/full/minify/libraries/vue 175974762 ns/iter (± 18012733) 176434100 ns/iter (± 29706781) 1.00
es/full/codegen/es3 35839 ns/iter (± 3980) 35629 ns/iter (± 2791) 1.01
es/full/codegen/es5 36742 ns/iter (± 4616) 36172 ns/iter (± 4660) 1.02
es/full/codegen/es2015 35278 ns/iter (± 3035) 36916 ns/iter (± 8757) 0.96
es/full/codegen/es2016 34658 ns/iter (± 2206) 36001 ns/iter (± 3381) 0.96
es/full/codegen/es2017 37600 ns/iter (± 7753) 35587 ns/iter (± 1271) 1.06
es/full/codegen/es2018 41749 ns/iter (± 4498) 36276 ns/iter (± 4130) 1.15
es/full/codegen/es2019 39311 ns/iter (± 4431) 36033 ns/iter (± 6125) 1.09
es/full/codegen/es2020 36656 ns/iter (± 3537) 36128 ns/iter (± 3438) 1.01
es/full/all/es3 232773858 ns/iter (± 77317000) 195972167 ns/iter (± 50631928) 1.19
es/full/all/es5 215176525 ns/iter (± 91854707) 183622475 ns/iter (± 29222935) 1.17
es/full/all/es2015 169608699 ns/iter (± 65316844) 147974242 ns/iter (± 31207476) 1.15
es/full/all/es2016 183816844 ns/iter (± 79927029) 146424274 ns/iter (± 33058729) 1.26
es/full/all/es2017 179090293 ns/iter (± 56197776) 145490592 ns/iter (± 25626012) 1.23
es/full/all/es2018 167585615 ns/iter (± 45293145) 145401391 ns/iter (± 43498030) 1.15
es/full/all/es2019 163102332 ns/iter (± 64269667) 144939270 ns/iter (± 42058843) 1.13
es/full/all/es2020 176030427 ns/iter (± 50858897) 140576784 ns/iter (± 30344529) 1.25
es/full/parser 741873 ns/iter (± 47563) 731535 ns/iter (± 190700) 1.01
es/full/base/fixer 27364 ns/iter (± 4889) 26958 ns/iter (± 2345) 1.02
es/full/base/resolver_and_hygiene 94856 ns/iter (± 14895) 93331 ns/iter (± 7559) 1.02
serialization of ast node 216 ns/iter (± 73) 216 ns/iter (± 12) 1
serialization of serde 220 ns/iter (± 6) 219 ns/iter (± 18) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.