fix(es): Use unresolved_mark for preset-env (#6386)

swc-project · Nov 9, 2022 · 156f370 · 156f370 · github-actions · Nov 9, 2022
1 parent 7fcd2b2
commit 156f370
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 1 deletion.
diff --git a/crates/swc/src/builder.rs b/crates/swc/src/builder.rs
@@ -202,7 +202,7 @@ impl<'a, 'b, P: swc_ecma_visit::Fold> PassBuilder<'a, 'b, P> {
         // compat
         let compat_pass = if let Some(env) = self.env {
             Either::Left(swc_ecma_preset_env::preset_env(
-                self.top_level_mark,
+                self.unresolved_mark,
                 comments,
                 env,
                 self.assumptions,

diff --git a/crates/swc/tests/fixture/issues-6xxx/6371/input/.swcrc b/crates/swc/tests/fixture/issues-6xxx/6371/input/.swcrc
@@ -0,0 +1,5 @@
+{
+    "env": {
+        "targets": "ie 10"
+    }
+}
diff --git a/crates/swc/tests/fixture/issues-6xxx/6371/input/input.js b/crates/swc/tests/fixture/issues-6xxx/6371/input/input.js
@@ -0,0 +1,6 @@
+function add(a, b) {
+    const d = () => {
+        return arguments.length;
+    }
+    return d();
+}
diff --git a/crates/swc/tests/fixture/issues-6xxx/6371/output/input.js b/crates/swc/tests/fixture/issues-6xxx/6371/output/input.js
@@ -0,0 +1,7 @@
+function add(a, b) {
+    var _arguments = arguments;
+    var d = function() {
+        return _arguments.length;
+    };
+    return d();
+}
Benchmark suite	Current: `156f370`	Previous: `4d49b9f`	Ratio
`es/full/bugs-1`	`349665` ns/iter (`± 19952`)	`355266` ns/iter (`± 22995`)	`0.98`
`es/full/minify/libraries/antd`	`1913935347` ns/iter (`± 717884934`)	`1886808597` ns/iter (`± 14519599`)	`1.01`
`es/full/minify/libraries/d3`	`431164593` ns/iter (`± 10389337`)	`420077018` ns/iter (`± 12810921`)	`1.03`
`es/full/minify/libraries/echarts`	`1609843463` ns/iter (`± 62060950`)	`1584480107` ns/iter (`± 27561397`)	`1.02`
`es/full/minify/libraries/jquery`	`102964506` ns/iter (`± 4605892`)	`104839428` ns/iter (`± 4956263`)	`0.98`
`es/full/minify/libraries/lodash`	`133234758` ns/iter (`± 4146128`)	`121755925` ns/iter (`± 2318161`)	`1.09`
`es/full/minify/libraries/moment`	`68781109` ns/iter (`± 2592595`)	`61203197` ns/iter (`± 2199677`)	`1.12`
`es/full/minify/libraries/react`	`22912492` ns/iter (`± 1831906`)	`20997533` ns/iter (`± 1764191`)	`1.09`
`es/full/minify/libraries/terser`	`325763725` ns/iter (`± 27244793`)	`321901910` ns/iter (`± 2957471`)	`1.01`
`es/full/minify/libraries/three`	`572042920` ns/iter (`± 39100126`)	`569403798` ns/iter (`± 5208199`)	`1.00`
`es/full/minify/libraries/typescript`	`3487447997` ns/iter (`± 182143318`)	`3411564119` ns/iter (`± 43305931`)	`1.02`
`es/full/minify/libraries/victory`	`872739815` ns/iter (`± 27250947`)	`850254491` ns/iter (`± 10594899`)	`1.03`
`es/full/minify/libraries/vue`	`180261896` ns/iter (`± 16971402`)	`157387962` ns/iter (`± 13349037`)	`1.15`
`es/full/codegen/es3`	`35123` ns/iter (`± 2202`)	`34045` ns/iter (`± 1432`)	`1.03`
`es/full/codegen/es5`	`33876` ns/iter (`± 3808`)	`33531` ns/iter (`± 1061`)	`1.01`
`es/full/codegen/es2015`	`33522` ns/iter (`± 1000`)	`33484` ns/iter (`± 2995`)	`1.00`
`es/full/codegen/es2016`	`33607` ns/iter (`± 887`)	`33590` ns/iter (`± 763`)	`1.00`
`es/full/codegen/es2017`	`33478` ns/iter (`± 798`)	`33379` ns/iter (`± 986`)	`1.00`
`es/full/codegen/es2018`	`33381` ns/iter (`± 2341`)	`33402` ns/iter (`± 1373`)	`1.00`
`es/full/codegen/es2019`	`33585` ns/iter (`± 919`)	`33446` ns/iter (`± 1137`)	`1.00`
`es/full/codegen/es2020`	`33808` ns/iter (`± 1233`)	`33497` ns/iter (`± 1597`)	`1.01`
`es/full/all/es3`	`195598291` ns/iter (`± 13921585`)	`189962562` ns/iter (`± 21597521`)	`1.03`
`es/full/all/es5`	`187611336` ns/iter (`± 11870303`)	`181806904` ns/iter (`± 9033667`)	`1.03`
`es/full/all/es2015`	`148426616` ns/iter (`± 8298313`)	`155462548` ns/iter (`± 17519771`)	`0.95`
`es/full/all/es2016`	`147943092` ns/iter (`± 9117504`)	`142307197` ns/iter (`± 11571573`)	`1.04`
`es/full/all/es2017`	`147361104` ns/iter (`± 9845160`)	`155052549` ns/iter (`± 12766158`)	`0.95`
`es/full/all/es2018`	`144116961` ns/iter (`± 9062409`)	`143940101` ns/iter (`± 7118366`)	`1.00`
`es/full/all/es2019`	`145513182` ns/iter (`± 6655203`)	`138285945` ns/iter (`± 7962779`)	`1.05`
`es/full/all/es2020`	`139098700` ns/iter (`± 13686634`)	`133533994` ns/iter (`± 5111018`)	`1.04`
`es/full/parser`	`731982` ns/iter (`± 95556`)	`686528` ns/iter (`± 25314`)	`1.07`
`es/full/base/fixer`	`26807` ns/iter (`± 2036`)	`25643` ns/iter (`± 844`)	`1.05`
`es/full/base/resolver_and_hygiene`	`94041` ns/iter (`± 7649`)	`91248` ns/iter (`± 4702`)	`1.03`
`serialization of ast node`	`216` ns/iter (`± 8`)	`215` ns/iter (`± 15`)	`1.00`
`serialization of serde`	`215` ns/iter (`± 16`)	`216` ns/iter (`± 3`)	`1.00`