Skip to content

Commit

Permalink
chore(common): Switch to new_debug_unreachable (#6265)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mbrubeck
mbrubeck committed Oct 27, 2022
1 parent bd61e06 commit 2f61332
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 40 deletions.
26 changes: 1 addition & 25 deletions Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 15 additions & 15 deletions crates/swc_common/Cargo.toml
View file
Expand Up @@ -49,21 +49,21 @@ rkyv-impl = ["__rkyv", "rkyv", "swc_atoms/rkyv-impl"]
rkyv-bytecheck-impl = ["__rkyv", "rkyv-latest", "swc_atoms/rkyv-bytecheck-impl"]

[dependencies]
ahash = "0.7.4"
anyhow = { version = "1.0.45", optional = true }
arbitrary = { version = "1", optional = true, features = ["derive"] }
ast_node = { version = "0.8.6", path = "../ast_node" }
atty = { version = "0.2", optional = true }
better_scoped_tls = { version = "0.1.0", path = "../better_scoped_tls" }
bytecheck = { version = "0.6.9", optional = true }
cfg-if = "1.0.0"
debug_unreachable = "0.1.1"
either = "1.5"
from_variant = { version = "0.1.3", path = "../from_variant" }
num-bigint = "0.4"
once_cell = "1.10.0"
parking_lot = { version = "0.12.0", optional = true }
rkyv = { version = "=0.7.37", optional = true }
ahash = "0.7.4"
anyhow = { version = "1.0.45", optional = true }
arbitrary = { version = "1", optional = true, features = ["derive"] }
ast_node = { version = "0.8.6", path = "../ast_node" }
atty = { version = "0.2", optional = true }
better_scoped_tls = { version = "0.1.0", path = "../better_scoped_tls" }
bytecheck = { version = "0.6.9", optional = true }
cfg-if = "1.0.0"
either = "1.5"
from_variant = { version = "0.1.3", path = "../from_variant" }
new_debug_unreachable = "1.0.4"
num-bigint = "0.4"
once_cell = "1.10.0"
parking_lot = { version = "0.12.0", optional = true }
rkyv = { version = "=0.7.37", optional = true }
# This is to avoid cargo version selection conflict between rkyv=0.7.37 and other versions, as it is strictly pinned
# cannot be merged.
rkyv-latest = { package = "rkyv-test", version = "=0.7.38-test.2", optional = true }
Expand Down

1 comment on commit 2f61332

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 2f61332 Previous: 743a1aa Ratio
es/full/bugs-1 417017 ns/iter (± 22800) 338859 ns/iter (± 19165) 1.23
es/full/minify/libraries/antd 2174265677 ns/iter (± 49170857) 1807361757 ns/iter (± 42942553) 1.20
es/full/minify/libraries/d3 415953889 ns/iter (± 11861345) 383691809 ns/iter (± 12991801) 1.08
es/full/minify/libraries/echarts 1828994985 ns/iter (± 31550651) 1541896169 ns/iter (± 24128297) 1.19
es/full/minify/libraries/jquery 117771720 ns/iter (± 1460408) 97437574 ns/iter (± 3473725) 1.21
es/full/minify/libraries/lodash 141626800 ns/iter (± 4498559) 114406438 ns/iter (± 1436726) 1.24
es/full/minify/libraries/moment 70152280 ns/iter (± 1521989) 57999540 ns/iter (± 990658) 1.21
es/full/minify/libraries/react 23823070 ns/iter (± 466634) 19392601 ns/iter (± 478067) 1.23
es/full/minify/libraries/terser 313458647 ns/iter (± 13480518) 357911001 ns/iter (± 143841951) 0.88
es/full/minify/libraries/three 552859064 ns/iter (± 18762300) 538254061 ns/iter (± 10344689) 1.03
es/full/minify/libraries/typescript 3983980133 ns/iter (± 37123648) 3398886400 ns/iter (± 77681435) 1.17
es/full/minify/libraries/victory 839610303 ns/iter (± 24135431) 814345267 ns/iter (± 37635308) 1.03
es/full/minify/libraries/vue 177712628 ns/iter (± 4216745) 145270534 ns/iter (± 4043914) 1.22
es/full/codegen/es3 39517 ns/iter (± 1618) 33633 ns/iter (± 1450) 1.17
es/full/codegen/es5 39852 ns/iter (± 1953) 33333 ns/iter (± 3277) 1.20
es/full/codegen/es2015 39943 ns/iter (± 1572) 33311 ns/iter (± 727) 1.20
es/full/codegen/es2016 40116 ns/iter (± 404) 33232 ns/iter (± 914) 1.21
es/full/codegen/es2017 40071 ns/iter (± 763) 33261 ns/iter (± 1295) 1.20
es/full/codegen/es2018 40148 ns/iter (± 1173) 33253 ns/iter (± 675) 1.21
es/full/codegen/es2019 40011 ns/iter (± 1061) 33295 ns/iter (± 583) 1.20
es/full/codegen/es2020 39889 ns/iter (± 954) 33264 ns/iter (± 974) 1.20
es/full/all/es3 229773214 ns/iter (± 4714765) 185946772 ns/iter (± 10381718) 1.24
es/full/all/es5 218548057 ns/iter (± 6062258) 176159583 ns/iter (± 2767116) 1.24
es/full/all/es2015 176476573 ns/iter (± 3699118) 141727264 ns/iter (± 3737441) 1.25
es/full/all/es2016 175054957 ns/iter (± 3715731) 140608961 ns/iter (± 4037461) 1.24
es/full/all/es2017 174047413 ns/iter (± 4737114) 140009277 ns/iter (± 2781809) 1.24
es/full/all/es2018 173253294 ns/iter (± 4751314) 138744681 ns/iter (± 4257324) 1.25
es/full/all/es2019 172606106 ns/iter (± 4192514) 137928365 ns/iter (± 3423663) 1.25
es/full/all/es2020 165734199 ns/iter (± 4787335) 132987276 ns/iter (± 3115723) 1.25
es/full/parser 873619 ns/iter (± 33416) 695014 ns/iter (± 64121) 1.26
es/full/base/fixer 31901 ns/iter (± 469) 24891 ns/iter (± 1019) 1.28
es/full/base/resolver_and_hygiene 112468 ns/iter (± 2616) 87499 ns/iter (± 1637) 1.29
serialization of ast node 265 ns/iter (± 4) 208 ns/iter (± 4) 1.27
serialization of serde 262 ns/iter (± 3) 211 ns/iter (± 10) 1.24

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.