Skip to content

Commit

Permalink
fix(bindings/node): Fix visitBindingIdentifier (#7000)
Browse files Browse the repository at this point in the history
  • Loading branch information
cyjake committed Mar 3, 2023
1 parent a504e2a commit 30cff01
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion node-swc/src/Visitor.ts
Expand Up @@ -171,6 +171,7 @@ import {
TsConstAssertion,
Import,
SuperPropExpression,
BindingIdentifier,
} from "./types";

export class Visitor {
Expand Down Expand Up @@ -1730,7 +1731,10 @@ export class Visitor {
return node;
}

visitBindingIdentifier(i: Identifier): Identifier {
visitBindingIdentifier(i: BindingIdentifier): BindingIdentifier {
if (i.typeAnnotation) {
i.typeAnnotation = this.visitTsTypeAnnotation(i.typeAnnotation);
}
return this.visitIdentifier(i);
}

Expand Down

1 comment on commit 30cff01

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 30cff01 Previous: 367ac82 Ratio
es/full/bugs-1 289255 ns/iter (± 10477) 298224 ns/iter (± 13823) 0.97
es/full/minify/libraries/antd 1838801541 ns/iter (± 146632125) 1614476927 ns/iter (± 18572207) 1.14
es/full/minify/libraries/d3 339369337 ns/iter (± 8505742) 300200417 ns/iter (± 6817488) 1.13
es/full/minify/libraries/echarts 1230990003 ns/iter (± 20958358) 1253288226 ns/iter (± 7377629) 0.98
es/full/minify/libraries/jquery 112817596 ns/iter (± 3835519) 91051207 ns/iter (± 1085148) 1.24
es/full/minify/libraries/lodash 124713532 ns/iter (± 8725266) 106426008 ns/iter (± 1148604) 1.17
es/full/minify/libraries/moment 55017603 ns/iter (± 1781471) 53071139 ns/iter (± 304413) 1.04
es/full/minify/libraries/react 19300583 ns/iter (± 213155) 19162511 ns/iter (± 158230) 1.01
es/full/minify/libraries/terser 247512635 ns/iter (± 3088041) 251253952 ns/iter (± 2966960) 0.99
es/full/minify/libraries/three 445626087 ns/iter (± 9012103) 451836044 ns/iter (± 3172770) 0.99
es/full/minify/libraries/typescript 2984921773 ns/iter (± 16740810) 3011675855 ns/iter (± 22312759) 0.99
es/full/minify/libraries/victory 695317430 ns/iter (± 13828462) 663424774 ns/iter (± 14229269) 1.05
es/full/minify/libraries/vue 138552054 ns/iter (± 3123399) 131383450 ns/iter (± 1959866) 1.05
es/full/codegen/es3 26116 ns/iter (± 213) 26916 ns/iter (± 64) 0.97
es/full/codegen/es5 26327 ns/iter (± 219) 26911 ns/iter (± 40) 0.98
es/full/codegen/es2015 26216 ns/iter (± 207) 26942 ns/iter (± 71) 0.97
es/full/codegen/es2016 26290 ns/iter (± 154) 26915 ns/iter (± 94) 0.98
es/full/codegen/es2017 26121 ns/iter (± 124) 26918 ns/iter (± 38) 0.97
es/full/codegen/es2018 26127 ns/iter (± 164) 26921 ns/iter (± 57) 0.97
es/full/codegen/es2019 26479 ns/iter (± 229) 26915 ns/iter (± 65) 0.98
es/full/codegen/es2020 26315 ns/iter (± 237) 27005 ns/iter (± 63) 0.97
es/full/all/es3 168696253 ns/iter (± 2652268) 169762895 ns/iter (± 3276486) 0.99
es/full/all/es5 162981796 ns/iter (± 1944374) 163395806 ns/iter (± 2903938) 1.00
es/full/all/es2015 122419847 ns/iter (± 1179783) 128002980 ns/iter (± 1288514) 0.96
es/full/all/es2016 122989526 ns/iter (± 983207) 126497639 ns/iter (± 1421077) 0.97
es/full/all/es2017 121439030 ns/iter (± 1200855) 124895847 ns/iter (± 1336284) 0.97
es/full/all/es2018 119865350 ns/iter (± 1313814) 120830528 ns/iter (± 733949) 0.99
es/full/all/es2019 119400841 ns/iter (± 1069052) 120567376 ns/iter (± 1197932) 0.99
es/full/all/es2020 114637088 ns/iter (± 340962) 116450592 ns/iter (± 524006) 0.98
es/full/parser 532264 ns/iter (± 8505) 547318 ns/iter (± 8494) 0.97
es/full/base/fixer 22526 ns/iter (± 94) 21901 ns/iter (± 55) 1.03
es/full/base/resolver_and_hygiene 81887 ns/iter (± 190) 82231 ns/iter (± 71) 1.00
serialization of ast node 124 ns/iter (± 0) 124 ns/iter (± 0) 1
serialization of serde 124 ns/iter (± 0) 124 ns/iter (± 0) 1
css/minify/libraries/bootstrap 28185219 ns/iter (± 118821) 28091149 ns/iter (± 158560) 1.00
css/visitor/compare/clone 2101565 ns/iter (± 23698) 2059426 ns/iter (± 21719) 1.02
css/visitor/compare/visit_mut_span 2261429 ns/iter (± 3945) 2282852 ns/iter (± 9745) 0.99
css/visitor/compare/visit_mut_span_panic 2306726 ns/iter (± 7973) 2296967 ns/iter (± 6948) 1.00
css/visitor/compare/fold_span 3020642 ns/iter (± 17117) 3005196 ns/iter (± 28238) 1.01
css/visitor/compare/fold_span_panic 3207295 ns/iter (± 20016) 3199270 ns/iter (± 24759) 1.00
css/lexer/bootstrap_5_1_3 5178712 ns/iter (± 27628) 5199839 ns/iter (± 26308) 1.00
css/lexer/foundation_6_7_4 4370955 ns/iter (± 18523) 4360853 ns/iter (± 1912) 1.00
css/lexer/tailwind_3_1_1 814544 ns/iter (± 7404) 830239 ns/iter (± 709) 0.98
css/parser/bootstrap_5_1_3 21361891 ns/iter (± 158768) 21717401 ns/iter (± 54087) 0.98
css/parser/foundation_6_7_4 17292504 ns/iter (± 39648) 17295682 ns/iter (± 21887) 1.00
css/parser/tailwind_3_1_1 3295031 ns/iter (± 4264) 3330439 ns/iter (± 4793) 0.99
es/codegen/colors 328095 ns/iter (± 184492) 332087 ns/iter (± 184964) 0.99
es/codegen/large 1222243 ns/iter (± 614666) 1153899 ns/iter (± 580082) 1.06
es/codegen/with-parser/colors 47515 ns/iter (± 462) 47932 ns/iter (± 443) 0.99
es/codegen/with-parser/large 519034 ns/iter (± 4007) 519313 ns/iter (± 532) 1.00
es/minify/libraries/antd 1372534578 ns/iter (± 24647220) 1401484345 ns/iter (± 25329611) 0.98
es/minify/libraries/d3 250777172 ns/iter (± 4757399) 254834719 ns/iter (± 2129703) 0.98
es/minify/libraries/echarts 1037790187 ns/iter (± 13745673) 1061805966 ns/iter (± 8379348) 0.98
es/minify/libraries/jquery 78054244 ns/iter (± 791973) 77564235 ns/iter (± 554825) 1.01
es/minify/libraries/lodash 94418567 ns/iter (± 1636201) 94358865 ns/iter (± 505585) 1.00
es/minify/libraries/moment 45979267 ns/iter (± 316322) 45919099 ns/iter (± 385150) 1.00
es/minify/libraries/react 17030384 ns/iter (± 108626) 16995100 ns/iter (± 100794) 1.00
es/minify/libraries/terser 209215895 ns/iter (± 2338230) 212548890 ns/iter (± 1900364) 0.98
es/minify/libraries/three 362788685 ns/iter (± 14236618) 367804912 ns/iter (± 3776562) 0.99
es/minify/libraries/typescript 2596972867 ns/iter (± 18631858) 2556052834 ns/iter (± 23922437) 1.02
es/minify/libraries/victory 615230407 ns/iter (± 36499140) 563299298 ns/iter (± 5314023) 1.09
es/minify/libraries/vue 122203343 ns/iter (± 2203796) 116679448 ns/iter (± 867080) 1.05
es/visitor/compare/clone 2420680 ns/iter (± 20629) 2408847 ns/iter (± 8250) 1.00
es/visitor/compare/visit_mut_span 2836534 ns/iter (± 7155) 2784498 ns/iter (± 3403) 1.02
es/visitor/compare/visit_mut_span_panic 2863269 ns/iter (± 15037) 2816689 ns/iter (± 7788) 1.02
es/visitor/compare/fold_span 3905586 ns/iter (± 32817) 3938180 ns/iter (± 9097) 0.99
es/visitor/compare/fold_span_panic 4061676 ns/iter (± 33380) 4082000 ns/iter (± 9830) 1.00
es/lexer/colors 16272 ns/iter (± 110) 16326 ns/iter (± 17) 1.00
es/lexer/angular 7819735 ns/iter (± 71657) 7846201 ns/iter (± 3292) 1.00
es/lexer/backbone 1005625 ns/iter (± 5698) 1010919 ns/iter (± 4739) 0.99
es/lexer/jquery 5560368 ns/iter (± 28123) 5618276 ns/iter (± 5352) 0.99
es/lexer/jquery mobile 8531131 ns/iter (± 38405) 8631436 ns/iter (± 20095) 0.99
es/lexer/mootools 4366615 ns/iter (± 16727) 4429468 ns/iter (± 3707) 0.99
es/lexer/underscore 838455 ns/iter (± 4743) 846422 ns/iter (± 455) 0.99
es/lexer/three 26445610 ns/iter (± 37163) 26323188 ns/iter (± 12526) 1.00
es/lexer/yui 4879600 ns/iter (± 11658) 4823008 ns/iter (± 1643) 1.01
es/parser/colors 30603 ns/iter (± 60) 30265 ns/iter (± 52) 1.01
es/parser/angular 15592766 ns/iter (± 167229) 15574325 ns/iter (± 111748) 1.00
es/parser/backbone 2296728 ns/iter (± 15645) 2285525 ns/iter (± 12040) 1.00
es/parser/jquery 12347788 ns/iter (± 67404) 12265072 ns/iter (± 81030) 1.01
es/parser/jquery mobile 19267735 ns/iter (± 109332) 19256215 ns/iter (± 271160) 1.00
es/parser/mootools 9550222 ns/iter (± 37457) 9453850 ns/iter (± 24937) 1.01
es/parser/underscore 1960634 ns/iter (± 13457) 1941430 ns/iter (± 12932) 1.01
es/parser/three 57365392 ns/iter (± 695330) 57081266 ns/iter (± 318091) 1.00
es/parser/yui 9512993 ns/iter (± 78198) 9478149 ns/iter (± 58211) 1.00
es/preset-env/usage/builtin_type 138719 ns/iter (± 29880) 141942 ns/iter (± 32650) 0.98
es/preset-env/usage/property 21069 ns/iter (± 76) 21170 ns/iter (± 88) 1.00
es/resolver/typescript 113299043 ns/iter (± 1179910) 112179917 ns/iter (± 2899608) 1.01
es/fixer/typescript 88223469 ns/iter (± 574419) 85363941 ns/iter (± 3198129) 1.03
es/hygiene/typescript 187361703 ns/iter (± 1547662) 180823810 ns/iter (± 1231102) 1.04
es/resolver_with_hygiene/typescript 324078985 ns/iter (± 2692502) 321119722 ns/iter (± 1866499) 1.01
es/visitor/base-perf/module_clone 76015 ns/iter (± 1922) 76820 ns/iter (± 1771) 0.99
es/visitor/base-perf/fold_empty 85955 ns/iter (± 1648) 86438 ns/iter (± 1123) 0.99
es/visitor/base-perf/fold_noop_impl_all 86154 ns/iter (± 1681) 85864 ns/iter (± 1307) 1.00
es/visitor/base-perf/fold_noop_impl_vec 87392 ns/iter (± 1160) 88125 ns/iter (± 2544) 0.99
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 59 ns/iter (± 0) 59 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 103 ns/iter (± 0) 103 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed 102 ns/iter (± 0) 103 ns/iter (± 0) 0.99
es/visitor/base-perf/visit_contains_this 3306 ns/iter (± 67) 3483 ns/iter (± 68) 0.95
es/base/parallel/resolver/typescript 4850633361 ns/iter (± 405145608) 5575714289 ns/iter (± 487459726) 0.87
es/base/parallel/hygiene/typescript 2170882636 ns/iter (± 66109060) 2144660074 ns/iter (± 20468510) 1.01
misc/visitors/time-complexity/time 5 101 ns/iter (± 0) 102 ns/iter (± 0) 0.99
misc/visitors/time-complexity/time 10 318 ns/iter (± 3) 323 ns/iter (± 2) 0.98
misc/visitors/time-complexity/time 15 643 ns/iter (± 0) 686 ns/iter (± 0) 0.94
misc/visitors/time-complexity/time 20 1214 ns/iter (± 6) 1271 ns/iter (± 11) 0.96
misc/visitors/time-complexity/time 40 6683 ns/iter (± 51) 6748 ns/iter (± 54) 0.99
misc/visitors/time-complexity/time 60 17011 ns/iter (± 17) 17172 ns/iter (± 59) 0.99
es/full-target/es2016 187841 ns/iter (± 384) 188429 ns/iter (± 355) 1.00
es/full-target/es2017 183063 ns/iter (± 941) 183771 ns/iter (± 542) 1.00
es/full-target/es2018 172950 ns/iter (± 668) 172209 ns/iter (± 476) 1.00
es2020_nullish_coalescing 67015 ns/iter (± 178) 67535 ns/iter (± 91) 0.99
es2020_optional_chaining 96181 ns/iter (± 8998) 96193 ns/iter (± 3181) 1.00
es2022_class_properties 93731 ns/iter (± 427) 94004 ns/iter (± 156) 1.00
es2018_object_rest_spread 71866 ns/iter (± 252) 71818 ns/iter (± 125) 1.00
es2019_optional_catch_binding 61687 ns/iter (± 150) 61417 ns/iter (± 110) 1.00
es2017_async_to_generator 62056 ns/iter (± 86) 62118 ns/iter (± 141) 1.00
es2016_exponentiation 65795 ns/iter (± 110) 65447 ns/iter (± 182) 1.01
es2015_arrow 71304 ns/iter (± 323) 69751 ns/iter (± 227) 1.02
es2015_block_scoped_fn 67054 ns/iter (± 223) 66413 ns/iter (± 129) 1.01
es2015_block_scoping 159261 ns/iter (± 7978) 138851 ns/iter (± 12034) 1.15
es2015_classes 116928 ns/iter (± 480) 116665 ns/iter (± 395) 1.00
es2015_computed_props 62069 ns/iter (± 179) 61323 ns/iter (± 88) 1.01
es2015_destructuring 117632 ns/iter (± 297) 117150 ns/iter (± 407) 1.00
es2015_duplicate_keys 63826 ns/iter (± 144) 64109 ns/iter (± 91) 1.00
es2015_parameters 80170 ns/iter (± 184) 80091 ns/iter (± 141) 1.00
es2015_fn_name 66951 ns/iter (± 311) 66527 ns/iter (± 460) 1.01
es2015_for_of 65019 ns/iter (± 103) 64427 ns/iter (± 169) 1.01
es2015_instanceof 63575 ns/iter (± 80) 63731 ns/iter (± 134) 1.00
es2015_shorthand_property 61348 ns/iter (± 105) 60968 ns/iter (± 65) 1.01
es2015_spread 61167 ns/iter (± 183) 61197 ns/iter (± 130) 1.00
es2015_sticky_regex 62575 ns/iter (± 122) 62497 ns/iter (± 94) 1.00
es2015_typeof_symbol 62886 ns/iter (± 147) 62816 ns/iter (± 110) 1.00
es/transform/baseline/base 52344 ns/iter (± 69) 52071 ns/iter (± 90) 1.01
es/transform/baseline/common_reserved_word 63346 ns/iter (± 125) 62593 ns/iter (± 103) 1.01
es/transform/baseline/common_typescript 164845 ns/iter (± 1178) 142346 ns/iter (± 2092) 1.16
es/target/es3 170498 ns/iter (± 191) 168870 ns/iter (± 219) 1.01
es/target/es2015 630195 ns/iter (± 1430) 629829 ns/iter (± 1346) 1.00
es/target/es2016 65441 ns/iter (± 257) 65490 ns/iter (± 87) 1.00
es/target/es2017 61033 ns/iter (± 448) 62254 ns/iter (± 107) 0.98
es/target/es2018 79427 ns/iter (± 422) 81931 ns/iter (± 157) 0.97
es/target/es2020 130381 ns/iter (± 677) 132942 ns/iter (± 230) 0.98
babelify-only 672327 ns/iter (± 5780) 665520 ns/iter (± 2895) 1.01
parse_and_babelify_angular 43548498 ns/iter (± 645934) 44121133 ns/iter (± 1262116) 0.99
parse_and_babelify_backbone 5370451 ns/iter (± 53632) 5467319 ns/iter (± 61781) 0.98
parse_and_babelify_jquery 31087770 ns/iter (± 1684601) 32203836 ns/iter (± 574077) 0.97
parse_and_babelify_jquery_mobile 54344518 ns/iter (± 871904) 54399453 ns/iter (± 314710) 1.00
parse_and_babelify_mootools 33344184 ns/iter (± 770714) 33539068 ns/iter (± 416067) 0.99
parse_and_babelify_underscore 4397592 ns/iter (± 53175) 4378707 ns/iter (± 11002) 1.00
parse_and_babelify_yui 33494868 ns/iter (± 490524) 37071240 ns/iter (± 738663) 0.90
html/minify/document/css_spec 42322823 ns/iter (± 346069) 42000606 ns/iter (± 174322) 1.01
html/minify/document/github 17456223 ns/iter (± 53421) 17422321 ns/iter (± 23456) 1.00
html/minify/document/stackoverflow 15656819 ns/iter (± 133246) 15647644 ns/iter (± 23706) 1.00
html/minify/document_fragment/css_spec 39962494 ns/iter (± 208337) 40531812 ns/iter (± 226454) 0.99
html/minify/document_fragment/github 16795297 ns/iter (± 33168) 16733011 ns/iter (± 29045) 1.00
html/minify/document_fragment/stackoverflow 15161656 ns/iter (± 47912) 15244223 ns/iter (± 47244) 0.99
html/document/visitor/compare/clone 346290 ns/iter (± 1384) 342521 ns/iter (± 1598) 1.01
html/document/visitor/compare/visit_mut_span 366772 ns/iter (± 2460) 369625 ns/iter (± 2599) 0.99
html/document/visitor/compare/visit_mut_span_panic 376643 ns/iter (± 2722) 382733 ns/iter (± 1775) 0.98
html/document/visitor/compare/fold_span 405245 ns/iter (± 1866) 407569 ns/iter (± 2240) 0.99
html/document/visitor/compare/fold_span_panic 461999 ns/iter (± 2055) 466138 ns/iter (± 1751) 0.99
html/document_fragment/visitor/compare/clone 338552 ns/iter (± 2922) 343877 ns/iter (± 2102) 0.98
html/document_fragment/visitor/compare/visit_mut_span 365580 ns/iter (± 1553) 367358 ns/iter (± 1672) 1.00
html/document_fragment/visitor/compare/visit_mut_span_panic 371864 ns/iter (± 2645) 373126 ns/iter (± 2181) 1.00
html/document_fragment/visitor/compare/fold_span 404872 ns/iter (± 2012) 404360 ns/iter (± 1813) 1.00
html/document_fragment/visitor/compare/fold_span_panic 459025 ns/iter (± 2574) 465173 ns/iter (± 2275) 0.99
html/lexer/css_2021_spec 15621609 ns/iter (± 82231) 15795125 ns/iter (± 10919) 0.99
html/lexer/github_com_17_05_2022 6036645 ns/iter (± 26595) 6090451 ns/iter (± 1479) 0.99
html/lexer/stackoverflow_com_17_05_2022 5672448 ns/iter (± 15760) 5715146 ns/iter (± 1689) 0.99
html/parser/parser_document/css_2021_spec 25475458 ns/iter (± 259826) 25595004 ns/iter (± 72645) 1.00
html/parser/parser_document/github_com_17_05_2022 8660714 ns/iter (± 32995) 8718888 ns/iter (± 15080) 0.99
html/parser/parser_document/stackoverflow_com_17_05_2022 7684239 ns/iter (± 17809) 7675130 ns/iter (± 4690) 1.00
html/parser/parser_document_fragment/css_2021_spec 25659254 ns/iter (± 167133) 26020159 ns/iter (± 143229) 0.99
html/parser/parser_document_fragment/github_com_17_05_2022 8758167 ns/iter (± 16347) 8712157 ns/iter (± 12282) 1.01
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7726164 ns/iter (± 10005) 7681201 ns/iter (± 3961) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.