Skip to content

Commit

Permalink
refactor(css/parser): Avoid unnecessary checks (#6383)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexander-akait committed Nov 9, 2022
1 parent 96e7814 commit 4d49b9f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions crates/swc_css_parser/src/parser/values_and_units/mod.rs
Expand Up @@ -1096,7 +1096,7 @@ where
}
}

if !is_one_of!(self, EOF, ")", "/") {
if !is_one_of!(self, EOF, "/") {
match function_name {
"hwb" => {
let percentage_or_none = self.try_parse_variable_function(
Expand Down Expand Up @@ -1229,7 +1229,7 @@ where
}
}

if !is_one_of!(self, EOF, ")", "/") {
if !is_one_of!(self, EOF, "/") {
match function_name {
"hwb" => {
let percentage_or_none = self.try_parse_variable_function(
Expand Down Expand Up @@ -1416,7 +1416,7 @@ where
}
}

if !is_one_of!(self, EOF, ")", "/") && function_name == "device-cmyk" {
if !is_one_of!(self, EOF, "/") && function_name == "device-cmyk" {
let cmyk_component = self.try_parse_variable_function(
|parser, _| Ok(Some(ComponentValue::CmykComponent(parser.parse()?))),
&mut has_variable,
Expand Down

1 comment on commit 4d49b9f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 4d49b9f Previous: 25333b9 Ratio
es/full/bugs-1 355266 ns/iter (± 22995) 381828 ns/iter (± 28743) 0.93
es/full/minify/libraries/antd 1886808597 ns/iter (± 14519599) 1971406237 ns/iter (± 83023775) 0.96
es/full/minify/libraries/d3 420077018 ns/iter (± 12810921) 441661798 ns/iter (± 22849511) 0.95
es/full/minify/libraries/echarts 1584480107 ns/iter (± 27561397) 1627116467 ns/iter (± 114560250) 0.97
es/full/minify/libraries/jquery 104839428 ns/iter (± 4956263) 113568182 ns/iter (± 9778780) 0.92
es/full/minify/libraries/lodash 121755925 ns/iter (± 2318161) 135239632 ns/iter (± 11847051) 0.90
es/full/minify/libraries/moment 61203197 ns/iter (± 2199677) 69209562 ns/iter (± 4075761) 0.88
es/full/minify/libraries/react 20997533 ns/iter (± 1764191) 22602869 ns/iter (± 1166711) 0.93
es/full/minify/libraries/terser 321901910 ns/iter (± 2957471) 370047247 ns/iter (± 28539967) 0.87
es/full/minify/libraries/three 569403798 ns/iter (± 5208199) 604607801 ns/iter (± 37911223) 0.94
es/full/minify/libraries/typescript 3411564119 ns/iter (± 43305931) 3509438636 ns/iter (± 91526789) 0.97
es/full/minify/libraries/victory 850254491 ns/iter (± 10594899) 844058843 ns/iter (± 15429891) 1.01
es/full/minify/libraries/vue 157387962 ns/iter (± 13349037) 186764005 ns/iter (± 14307938) 0.84
es/full/codegen/es3 34045 ns/iter (± 1432) 36463 ns/iter (± 4101) 0.93
es/full/codegen/es5 33531 ns/iter (± 1061) 35140 ns/iter (± 3316) 0.95
es/full/codegen/es2015 33484 ns/iter (± 2995) 34730 ns/iter (± 3047) 0.96
es/full/codegen/es2016 33590 ns/iter (± 763) 34812 ns/iter (± 2145) 0.96
es/full/codegen/es2017 33379 ns/iter (± 986) 34534 ns/iter (± 1747) 0.97
es/full/codegen/es2018 33402 ns/iter (± 1373) 35139 ns/iter (± 2231) 0.95
es/full/codegen/es2019 33446 ns/iter (± 1137) 34787 ns/iter (± 2164) 0.96
es/full/codegen/es2020 33497 ns/iter (± 1597) 34509 ns/iter (± 1891) 0.97
es/full/all/es3 189962562 ns/iter (± 21597521) 236530949 ns/iter (± 22609014) 0.80
es/full/all/es5 181806904 ns/iter (± 9033667) 220701311 ns/iter (± 19513567) 0.82
es/full/all/es2015 155462548 ns/iter (± 17519771) 175160308 ns/iter (± 16346516) 0.89
es/full/all/es2016 142307197 ns/iter (± 11571573) 182886668 ns/iter (± 23667674) 0.78
es/full/all/es2017 155052549 ns/iter (± 12766158) 175158408 ns/iter (± 20887053) 0.89
es/full/all/es2018 143940101 ns/iter (± 7118366) 171134197 ns/iter (± 20304718) 0.84
es/full/all/es2019 138285945 ns/iter (± 7962779) 178678233 ns/iter (± 30135978) 0.77
es/full/all/es2020 133533994 ns/iter (± 5111018) 174168466 ns/iter (± 20888853) 0.77
es/full/parser 686528 ns/iter (± 25314) 765408 ns/iter (± 99498) 0.90
es/full/base/fixer 25643 ns/iter (± 844) 27493 ns/iter (± 3405) 0.93
es/full/base/resolver_and_hygiene 91248 ns/iter (± 4702) 95887 ns/iter (± 14892) 0.95
serialization of ast node 215 ns/iter (± 15) 235 ns/iter (± 23) 0.91
serialization of serde 216 ns/iter (± 3) 221 ns/iter (± 24) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.