Skip to content

Commit

Permalink
fix(es): Preserve license comments by default (#6703)
Browse files Browse the repository at this point in the history 
**Related issue:**

 - Closes #6677.
  • Loading branch information
@kdy1
kdy1 committed Dec 21, 2022
1 parent 70d8ecc commit 58700f2
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion crates/swc/src/config/mod.rs
View file
Expand Up @@ -943,7 +943,7 @@ pub struct JsMinifyFormatOptions {
#[serde(default)]
pub braces: bool,

#[serde(default)]
#[serde(default = "default_comments")]
pub comments: BoolOrDataConfig<JsMinifyCommentOption>,

/// Not implemented yet.
Expand Down Expand Up @@ -1015,6 +1015,10 @@ pub struct JsMinifyFormatOptions {
pub wrap_func_args: bool,
}

fn default_comments() -> BoolOrDataConfig<JsMinifyCommentOption> {
BoolOrDataConfig::from_obj(JsMinifyCommentOption::PreserveSomeComments)
}

#[derive(Debug, Clone, Serialize, Deserialize)]
pub enum JsMinifyCommentOption {
#[serde(rename = "some")]
Expand Down

1 comment on commit 58700f2

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 58700f2 Previous: 025d626 Ratio
es/full/bugs-1 311992 ns/iter (± 13371) 296019 ns/iter (± 9906) 1.05
es/full/minify/libraries/antd 1735086609 ns/iter (± 27469213) 1583514690 ns/iter (± 31342434) 1.10
es/full/minify/libraries/d3 316725554 ns/iter (± 11995207) 291117354 ns/iter (± 5476873) 1.09
es/full/minify/libraries/echarts 1288395739 ns/iter (± 21500894) 1213670633 ns/iter (± 7761576) 1.06
es/full/minify/libraries/jquery 90201767 ns/iter (± 795921) 88874542 ns/iter (± 368049) 1.01
es/full/minify/libraries/lodash 107095989 ns/iter (± 1831777) 106349279 ns/iter (± 3057957) 1.01
es/full/minify/libraries/moment 53285387 ns/iter (± 691515) 52081087 ns/iter (± 487057) 1.02
es/full/minify/libraries/react 18884711 ns/iter (± 216770) 18764496 ns/iter (± 52136) 1.01
es/full/minify/libraries/terser 250952354 ns/iter (± 5789191) 240534579 ns/iter (± 1578144) 1.04
es/full/minify/libraries/three 449797038 ns/iter (± 10425651) 431611914 ns/iter (± 5330135) 1.04
es/full/minify/libraries/typescript 3222684984 ns/iter (± 16199205) 2997343141 ns/iter (± 44954509) 1.08
es/full/minify/libraries/victory 713579084 ns/iter (± 20333025) 641011620 ns/iter (± 6604769) 1.11
es/full/minify/libraries/vue 131329262 ns/iter (± 1137103) 128541202 ns/iter (± 1949898) 1.02
es/full/codegen/es3 27656 ns/iter (± 184) 27347 ns/iter (± 46) 1.01
es/full/codegen/es5 27623 ns/iter (± 76) 27282 ns/iter (± 77) 1.01
es/full/codegen/es2015 27573 ns/iter (± 79) 27257 ns/iter (± 66) 1.01
es/full/codegen/es2016 27502 ns/iter (± 105) 27309 ns/iter (± 49) 1.01
es/full/codegen/es2017 27507 ns/iter (± 158) 27267 ns/iter (± 49) 1.01
es/full/codegen/es2018 27437 ns/iter (± 137) 27281 ns/iter (± 169) 1.01
es/full/codegen/es2019 27518 ns/iter (± 153) 27281 ns/iter (± 49) 1.01
es/full/codegen/es2020 27483 ns/iter (± 191) 27292 ns/iter (± 75) 1.01
es/full/all/es3 168706489 ns/iter (± 3105273) 168052466 ns/iter (± 3181192) 1.00
es/full/all/es5 160207475 ns/iter (± 2363596) 157334330 ns/iter (± 3202260) 1.02
es/full/all/es2015 122025555 ns/iter (± 1697901) 118631454 ns/iter (± 987481) 1.03
es/full/all/es2016 122217147 ns/iter (± 1911359) 118118119 ns/iter (± 541340) 1.03
es/full/all/es2017 121120900 ns/iter (± 3285993) 117059450 ns/iter (± 370902) 1.03
es/full/all/es2018 118861853 ns/iter (± 4849307) 115370559 ns/iter (± 922097) 1.03
es/full/all/es2019 117114793 ns/iter (± 1331493) 114930183 ns/iter (± 1665675) 1.02
es/full/all/es2020 111749492 ns/iter (± 1875991) 109638154 ns/iter (± 1096445) 1.02
es/full/parser 513777 ns/iter (± 8080) 507046 ns/iter (± 7062) 1.01
es/full/base/fixer 21892 ns/iter (± 23) 22032 ns/iter (± 23) 0.99
es/full/base/resolver_and_hygiene 77947 ns/iter (± 104) 78023 ns/iter (± 115) 1.00
serialization of ast node 118 ns/iter (± 0) 118 ns/iter (± 0) 1
serialization of serde 122 ns/iter (± 0) 122 ns/iter (± 0) 1
css/minify/libraries/bootstrap 27885845 ns/iter (± 142453) 27512340 ns/iter (± 96083) 1.01
css/visitor/compare/clone 2240977 ns/iter (± 129951) 2070875 ns/iter (± 17034) 1.08
css/visitor/compare/visit_mut_span 2667374 ns/iter (± 11722) 2290479 ns/iter (± 5337) 1.16
css/visitor/compare/visit_mut_span_panic 2715056 ns/iter (± 5086) 2335960 ns/iter (± 2749) 1.16
css/visitor/compare/fold_span 3501801 ns/iter (± 7627) 3069889 ns/iter (± 8942) 1.14
css/visitor/compare/fold_span_panic 3599836 ns/iter (± 8880) 3235399 ns/iter (± 13047) 1.11
css/lexer/bootstrap_5_1_3 5200814 ns/iter (± 2068) 5226126 ns/iter (± 9147) 1.00
css/lexer/foundation_6_7_4 4371217 ns/iter (± 4698) 4400397 ns/iter (± 1624) 0.99
css/lexer/tailwind_3_1_1 826695 ns/iter (± 413) 834925 ns/iter (± 396) 0.99
css/parser/bootstrap_5_1_3 21740123 ns/iter (± 99093) 21462535 ns/iter (± 12499) 1.01
css/parser/foundation_6_7_4 17341165 ns/iter (± 38120) 17340517 ns/iter (± 232918) 1.00
css/parser/tailwind_3_1_1 3314202 ns/iter (± 5716) 3292980 ns/iter (± 3538) 1.01
es/codegen/colors 333464 ns/iter (± 187670) 330453 ns/iter (± 184627) 1.01
es/codegen/large 1173274 ns/iter (± 596986) 1270932 ns/iter (± 656934) 0.92
es/codegen/with-parser/colors 46642 ns/iter (± 314) 46348 ns/iter (± 336) 1.01
es/codegen/with-parser/large 513202 ns/iter (± 2017) 512449 ns/iter (± 1839) 1.00
es/minify/libraries/antd 1512929934 ns/iter (± 18948020) 1363009350 ns/iter (± 46944850) 1.11
es/minify/libraries/d3 255337350 ns/iter (± 4929844) 245373987 ns/iter (± 1618556) 1.04
es/minify/libraries/echarts 1149284769 ns/iter (± 23409315) 1019889821 ns/iter (± 7589202) 1.13
es/minify/libraries/jquery 78698031 ns/iter (± 1086782) 77254512 ns/iter (± 1487725) 1.02
es/minify/libraries/lodash 96560059 ns/iter (± 1795781) 94283950 ns/iter (± 1089569) 1.02
es/minify/libraries/moment 46311269 ns/iter (± 464339) 45638030 ns/iter (± 259247) 1.01
es/minify/libraries/react 16952024 ns/iter (± 164113) 16751604 ns/iter (± 86252) 1.01
es/minify/libraries/terser 214853152 ns/iter (± 3389736) 206763197 ns/iter (± 4391933) 1.04
es/minify/libraries/three 373889412 ns/iter (± 15123592) 354039241 ns/iter (± 2137985) 1.06
es/minify/libraries/typescript 2788994113 ns/iter (± 27218068) 2582427464 ns/iter (± 13908638) 1.08
es/minify/libraries/victory 584494554 ns/iter (± 14009131) 561827875 ns/iter (± 4490312) 1.04
es/minify/libraries/vue 117952672 ns/iter (± 1372631) 116822144 ns/iter (± 1042401) 1.01
es/visitor/compare/clone 2525653 ns/iter (± 46267) 2380606 ns/iter (± 18886) 1.06
es/visitor/compare/visit_mut_span 3157630 ns/iter (± 10720) 2763468 ns/iter (± 11401) 1.14
es/visitor/compare/visit_mut_span_panic 3200180 ns/iter (± 12254) 2841344 ns/iter (± 7996) 1.13
es/visitor/compare/fold_span 4367641 ns/iter (± 49106) 3955246 ns/iter (± 21339) 1.10
es/visitor/compare/fold_span_panic 4496034 ns/iter (± 8499) 4120301 ns/iter (± 57352) 1.09
es/lexer/colors 17316 ns/iter (± 11) 17377 ns/iter (± 19) 1.00
es/lexer/angular 8257927 ns/iter (± 2679) 8238366 ns/iter (± 5646) 1.00
es/lexer/backbone 1078380 ns/iter (± 372) 1076395 ns/iter (± 374) 1.00
es/lexer/jquery 5970843 ns/iter (± 3076) 5960260 ns/iter (± 3057) 1.00
es/lexer/jquery mobile 9205477 ns/iter (± 4501) 9180057 ns/iter (± 5343) 1.00
es/lexer/mootools 4688089 ns/iter (± 12213) 4677000 ns/iter (± 1467) 1.00
es/lexer/underscore 900283 ns/iter (± 2756) 896040 ns/iter (± 294) 1.00
es/lexer/three 28032287 ns/iter (± 63378) 28000257 ns/iter (± 20741) 1.00
es/lexer/yui 5070945 ns/iter (± 3356) 5062609 ns/iter (± 1172) 1.00
es/parser/colors 30695 ns/iter (± 154) 30345 ns/iter (± 134) 1.01
es/parser/angular 15670035 ns/iter (± 260035) 15897334 ns/iter (± 193651) 0.99
es/parser/backbone 2316887 ns/iter (± 10838) 2321216 ns/iter (± 11960) 1.00
es/parser/jquery 12576938 ns/iter (± 147069) 12589508 ns/iter (± 116215) 1.00
es/parser/jquery mobile 20020795 ns/iter (± 363168) 20006216 ns/iter (± 321401) 1.00
es/parser/mootools 9701654 ns/iter (± 65029) 9675119 ns/iter (± 48878) 1.00
es/parser/underscore 1984577 ns/iter (± 10173) 1969293 ns/iter (± 10171) 1.01
es/parser/three 60068921 ns/iter (± 1175821) 58320080 ns/iter (± 311811) 1.03
es/parser/yui 9617407 ns/iter (± 96467) 9544310 ns/iter (± 47168) 1.01
es/preset-env/usage/builtin_type 140787 ns/iter (± 31552) 144247 ns/iter (± 33772) 0.98
es/preset-env/usage/property 21111 ns/iter (± 800) 20937 ns/iter (± 74) 1.01
es/resolver/typescript 132410073 ns/iter (± 4932435) 108618304 ns/iter (± 922811) 1.22
es/fixer/typescript 103713552 ns/iter (± 5677973) 85237257 ns/iter (± 989131) 1.22
es/hygiene/typescript 197866681 ns/iter (± 957321) 165346425 ns/iter (± 496556) 1.20
es/resolver_with_hygiene/typescript 349180911 ns/iter (± 5121652) 307928746 ns/iter (± 2955072) 1.13
es/visitor/base-perf/module_clone 75449 ns/iter (± 1450) 75061 ns/iter (± 1420) 1.01
es/visitor/base-perf/fold_empty 85499 ns/iter (± 1786) 85344 ns/iter (± 1979) 1.00
es/visitor/base-perf/fold_noop_impl_all 86177 ns/iter (± 740) 85502 ns/iter (± 1680) 1.01
es/visitor/base-perf/fold_noop_impl_vec 86384 ns/iter (± 1505) 86171 ns/iter (± 1898) 1.00
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 59 ns/iter (± 0) 59 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 106 ns/iter (± 0) 127 ns/iter (± 0) 0.83
es/visitor/base-perf/boxing_unboxed 103 ns/iter (± 0) 102 ns/iter (± 0) 1.01
es/visitor/base-perf/visit_contains_this 3537 ns/iter (± 78) 3397 ns/iter (± 49) 1.04
es/base/parallel/resolver/typescript 5607090857 ns/iter (± 556860953) 5415723637 ns/iter (± 480392139) 1.04
es/base/parallel/hygiene/typescript 2269557224 ns/iter (± 34479612) 2002488136 ns/iter (± 27897833) 1.13
misc/visitors/time-complexity/time 5 93 ns/iter (± 0) 93 ns/iter (± 1) 1
misc/visitors/time-complexity/time 10 325 ns/iter (± 0) 324 ns/iter (± 0) 1.00
misc/visitors/time-complexity/time 15 634 ns/iter (± 0) 636 ns/iter (± 0) 1.00
misc/visitors/time-complexity/time 20 1192 ns/iter (± 1) 1191 ns/iter (± 0) 1.00
misc/visitors/time-complexity/time 40 6198 ns/iter (± 55) 6153 ns/iter (± 6) 1.01
misc/visitors/time-complexity/time 60 15536 ns/iter (± 31) 15539 ns/iter (± 51) 1.00
es/full-target/es2016 187735 ns/iter (± 679) 187464 ns/iter (± 323) 1.00
es/full-target/es2017 182459 ns/iter (± 447) 182116 ns/iter (± 564) 1.00
es/full-target/es2018 171337 ns/iter (± 498) 171373 ns/iter (± 385) 1.00
es2020_nullish_coalescing 66732 ns/iter (± 5189) 66801 ns/iter (± 89) 1.00
es2020_optional_chaining 95640 ns/iter (± 278) 95454 ns/iter (± 240) 1.00
es2022_class_properties 93743 ns/iter (± 183) 93293 ns/iter (± 171) 1.00
es2018_object_rest_spread 71135 ns/iter (± 147) 71046 ns/iter (± 84) 1.00
es2019_optional_catch_binding 60727 ns/iter (± 135) 60996 ns/iter (± 87) 1.00
es2017_async_to_generator 61534 ns/iter (± 115) 61374 ns/iter (± 87) 1.00
es2016_exponentiation 65009 ns/iter (± 166) 64569 ns/iter (± 125) 1.01
es2015_arrow 70269 ns/iter (± 237) 69728 ns/iter (± 183) 1.01
es2015_block_scoped_fn 66532 ns/iter (± 228) 66160 ns/iter (± 140) 1.01
es2015_block_scoping 150184 ns/iter (± 9235) 154319 ns/iter (± 8534) 0.97
es2015_classes 116580 ns/iter (± 437) 116355 ns/iter (± 323) 1.00
es2015_computed_props 60949 ns/iter (± 253) 61163 ns/iter (± 112) 1.00
es2015_destructuring 114800 ns/iter (± 375) 115001 ns/iter (± 208) 1.00
es2015_duplicate_keys 63524 ns/iter (± 164) 63425 ns/iter (± 87) 1.00
es2015_parameters 79621 ns/iter (± 383) 79192 ns/iter (± 180) 1.01
es2015_fn_name 66417 ns/iter (± 583) 65969 ns/iter (± 397) 1.01
es2015_for_of 64678 ns/iter (± 120) 64296 ns/iter (± 117) 1.01
es2015_instanceof 62687 ns/iter (± 118) 62955 ns/iter (± 75) 1.00
es2015_shorthand_property 60724 ns/iter (± 183) 60846 ns/iter (± 77) 1.00
es2015_spread 60828 ns/iter (± 171) 60926 ns/iter (± 110) 1.00
es2015_sticky_regex 62092 ns/iter (± 136) 62421 ns/iter (± 87) 0.99
es2015_typeof_symbol 62303 ns/iter (± 155) 62127 ns/iter (± 79) 1.00
es/transform/baseline/base 51440 ns/iter (± 142) 51496 ns/iter (± 75) 1.00
es/transform/baseline/common_reserved_word 62691 ns/iter (± 595) 62649 ns/iter (± 61) 1.00
es/transform/baseline/common_typescript 147956 ns/iter (± 5155) 143183 ns/iter (± 4052) 1.03
es/target/es3 168577 ns/iter (± 456) 169869 ns/iter (± 125) 0.99
es/target/es2015 629546 ns/iter (± 2588) 625713 ns/iter (± 723) 1.01
es/target/es2016 65090 ns/iter (± 88) 64722 ns/iter (± 105) 1.01
es/target/es2017 61544 ns/iter (± 99) 61554 ns/iter (± 80) 1.00
es/target/es2018 81217 ns/iter (± 248) 81464 ns/iter (± 76) 1.00
es/target/es2020 131114 ns/iter (± 767) 131928 ns/iter (± 264) 0.99
babelify-only 690328 ns/iter (± 6857) 676928 ns/iter (± 983) 1.02
parse_and_babelify_angular 45087623 ns/iter (± 1062323) 41331221 ns/iter (± 433138) 1.09
parse_and_babelify_backbone 5456835 ns/iter (± 81745) 5309147 ns/iter (± 50304) 1.03
parse_and_babelify_jquery 32748501 ns/iter (± 458683) 31026158 ns/iter (± 300989) 1.06
parse_and_babelify_jquery_mobile 56193964 ns/iter (± 711484) 53771419 ns/iter (± 664508) 1.05
parse_and_babelify_mootools 33673468 ns/iter (± 633463) 33152518 ns/iter (± 235740) 1.02
parse_and_babelify_underscore 4356593 ns/iter (± 32224) 4344311 ns/iter (± 24288) 1.00
parse_and_babelify_yui 33015012 ns/iter (± 575588) 32617335 ns/iter (± 446827) 1.01
html/minify/document/css_spec 42762981 ns/iter (± 413473) 41895259 ns/iter (± 301171) 1.02
html/minify/document/github 17541024 ns/iter (± 103695) 17370414 ns/iter (± 91554) 1.01
html/minify/document/stackoverflow 15611531 ns/iter (± 139915) 15687934 ns/iter (± 116905) 1.00
html/minify/document_fragment/css_spec 40402391 ns/iter (± 718138) 41883453 ns/iter (± 979154) 0.96
html/minify/document_fragment/github 16763097 ns/iter (± 37901) 16697367 ns/iter (± 43311) 1.00
html/minify/document_fragment/stackoverflow 15087412 ns/iter (± 33453) 15005120 ns/iter (± 15629) 1.01
html/document/visitor/compare/clone 402737 ns/iter (± 24200) 343720 ns/iter (± 2720) 1.17
html/document/visitor/compare/visit_mut_span 437909 ns/iter (± 6201) 366048 ns/iter (± 2457) 1.20
html/document/visitor/compare/visit_mut_span_panic 447487 ns/iter (± 4567) 373786 ns/iter (± 1393) 1.20
html/document/visitor/compare/fold_span 476233 ns/iter (± 4542) 409091 ns/iter (± 2619) 1.16
html/document/visitor/compare/fold_span_panic 541327 ns/iter (± 4121) 467103 ns/iter (± 2010) 1.16
html/document_fragment/visitor/compare/clone 400507 ns/iter (± 5697) 340305 ns/iter (± 1514) 1.18
html/document_fragment/visitor/compare/visit_mut_span 435684 ns/iter (± 3995) 371229 ns/iter (± 2737) 1.17
html/document_fragment/visitor/compare/visit_mut_span_panic 447541 ns/iter (± 4065) 375906 ns/iter (± 1660) 1.19
html/document_fragment/visitor/compare/fold_span 473409 ns/iter (± 5293) 407003 ns/iter (± 1477) 1.16
html/document_fragment/visitor/compare/fold_span_panic 533242 ns/iter (± 5823) 463621 ns/iter (± 2465) 1.15
html/lexer/css_2021_spec 15522539 ns/iter (± 18186) 15611670 ns/iter (± 16368) 0.99
html/lexer/github_com_17_05_2022 6031273 ns/iter (± 4274) 6040642 ns/iter (± 2022) 1.00
html/lexer/stackoverflow_com_17_05_2022 5627423 ns/iter (± 3030) 5646644 ns/iter (± 2287) 1.00
html/parser/parser_document/css_2021_spec 26702641 ns/iter (± 293824) 25287176 ns/iter (± 112781) 1.06
html/parser/parser_document/github_com_17_05_2022 8791357 ns/iter (± 15675) 8690793 ns/iter (± 5862) 1.01
html/parser/parser_document/stackoverflow_com_17_05_2022 7723259 ns/iter (± 10628) 7672881 ns/iter (± 16539) 1.01
html/parser/parser_document_fragment/css_2021_spec 27291482 ns/iter (± 510169) 25513613 ns/iter (± 96112) 1.07
html/parser/parser_document_fragment/github_com_17_05_2022 8834448 ns/iter (± 22369) 8722309 ns/iter (± 4520) 1.01
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7787821 ns/iter (± 7518) 7680082 ns/iter (± 40423) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.