fix(es/compat): Improve destructuring pass (#6412)

crates/swc/tests/fixture/issues-1xxx/1449/case1/output/index.js

@@ -1,14 +1,14 @@
 import _async_to_generator from "@swc/helpers/src/_async_to_generator.mjs";
-import _throw from "@swc/helpers/src/_throw.mjs";
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _ts_generator from "@swc/helpers/src/_ts_generator.mjs";
 function foo() {
     return _foo.apply(this, arguments);
 }
 function _foo() {
     _foo = _async_to_generator(function() {
-        var tmp, _ref, _ref;
+        var tmp, ref;
         return _ts_generator(this, function(_state) {
-            tmp = baz.bar, _ref = tmp === void 0 ? {} : tmp, _ref = _ref !== null ? _ref : _throw(new TypeError("Cannot destructure undefined"));
+            tmp = baz.bar, ref = _object_destructuring_empty(tmp === void 0 ? {} : tmp);
             return [
                 2
             ];

crates/swc/tests/fixture/issues-1xxx/pr-1579/checkingExtend/output/index.js

@@ -1,3 +1,4 @@
 import _extends from "@swc/helpers/src/_extends.mjs";
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 var a = {};
-var b = _extends({}, a);
+var b = _extends({}, _object_destructuring_empty(a));

crates/swc/tests/fixture/issues-2xxx/2964/case-5/output/index.ts

@@ -14,9 +14,10 @@ _export(exports, {
     foo: ()=>foo
 });
 const _extends = require("@swc/helpers/lib/_extends.js").default;
+const _objectDestructuringEmpty = require("@swc/helpers/lib/_object_destructuring_empty.js").default;
 const a = 1;
 const b = 2;
-var foo = _extends({}, {
+var foo = _extends({}, _objectDestructuringEmpty({
     a: 1,
     b: 2
-});
+}));

crates/swc/tests/fixture/issues-6xxx/6306/input/index.js

@@ -0,0 +1,2 @@
+"use strict";
+x = {} = null;

crates/swc/tests/fixture/issues-6xxx/6306/output/index.js

@@ -0,0 +1,3 @@
+"use strict";
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
+x = _object_destructuring_empty(null);

crates/swc/tests/fixture/issues-6xxx/6330/input/input.js

@@ -0,0 +1 @@
+new (function ({}) {})();

crates/swc/tests/fixture/issues-6xxx/6330/output/input.js

@@ -0,0 +1,4 @@
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
+new function(param) {
+    var ref = _object_destructuring_empty(param);
+}();

crates/swc/tests/fixture/issues-6xxx/6390/input/input.js

@@ -0,0 +1,5 @@
+var { ...x } = null;
+var { ...y } = undefined;
+
+var z;
+({...z} = null);

crates/swc/tests/fixture/issues-6xxx/6390/output/input.js

@@ -0,0 +1,7 @@
+import _extends from "@swc/helpers/src/_extends.mjs";
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
+var x = _extends({}, _object_destructuring_empty(null));
+var y = _extends({}, _object_destructuring_empty(undefined));
+var z;
+var _tmp;
+_tmp = null, z = _extends({}, _object_destructuring_empty(_tmp)), _tmp;

crates/swc/tests/fixture/issues-6xxx/6392/1/input/index.js

@@ -0,0 +1 @@
+let {} = x;

crates/swc/tests/fixture/issues-6xxx/6392/1/output/index.js

@@ -0,0 +1,2 @@
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
+var ref = _object_destructuring_empty(x);

crates/swc/tests/fixture/issues-6xxx/6392/2/input/index.js

@@ -0,0 +1,8 @@
+let x = 42;
+
+function f() {
+    let {} = x;
+    console.log(x);
+}
+
+f();

crates/swc/tests/fixture/issues-6xxx/6392/2/output/index.js

@@ -0,0 +1,7 @@
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
+var x = 42;
+function f() {
+    var ref = _object_destructuring_empty(x);
+    console.log(x);
+}
+f();

crates/swc/tests/tsc-references/asyncWithVarShadowing_es6.1.normal.js

@@ -2,6 +2,7 @@
 // https://github.com/Microsoft/TypeScript/issues/20461
 import _async_to_generator from "@swc/helpers/src/_async_to_generator.mjs";
 import _extends from "@swc/helpers/src/_extends.mjs";
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 function fn1(x) {
     return _fn1.apply(this, arguments);
 }
@@ -97,7 +98,7 @@ function fn11(x) {
 }
 function _fn11() {
     _fn11 = _async_to_generator(function*(x) {
-        var x = _extends({}, y);
+        var x = _extends({}, _object_destructuring_empty(y));
     });
     return _fn11.apply(this, arguments);
 }

crates/swc/tests/tsc-references/declarationsAndAssignments.1.normal.js

@@ -1,6 +1,6 @@
 //// [declarationsAndAssignments.ts]
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-import _throw from "@swc/helpers/src/_throw.mjs";
 import _to_array from "@swc/helpers/src/_to_array.mjs";
 function f0() {
     var _ref = [
@@ -33,10 +33,10 @@ function f1() {
     var z;
 }
 function f2() {
-    var _ref = {
+    var ref = _object_destructuring_empty({
         x: 5,
         y: "hello"
-    }, _ref = _ref !== null ? _ref : _throw(new TypeError("Cannot destructure undefined")); // Ok, empty binding pattern means nothing
+    }); // Ok, empty binding pattern means nothing
     var x = {
         x: 5,
         y: "hello"
@@ -45,24 +45,24 @@ function f2() {
         x: 5,
         y: "hello"
     }.y; // Error, no x in target
-    var _ref1 = {
+    var _ref = {
         x: 5,
         y: "hello"
-    }, x = _ref1.x, y = _ref1.y;
+    }, x = _ref.x, y = _ref.y;
     var x;
     var y;
-    var _ref2 = {
+    var _ref1 = {
         x: 5,
         y: "hello"
-    }, a = _ref2.x; // Error, no y in target
-    var _ref3 = {
+    }, a = _ref1.x; // Error, no y in target
+    var _ref2 = {
         x: 5,
         y: "hello"
-    }, b = _ref3.y; // Error, no x in target
-    var _ref4 = {
+    }, b = _ref2.y; // Error, no x in target
+    var _ref3 = {
         x: 5,
         y: "hello"
-    }, a = _ref4.x, b = _ref4.y;
+    }, a = _ref3.x, b = _ref3.y;
     var a;
     var b;
 }

crates/swc/tests/tsc-references/destructuringAssignabilityCheck.1.normal.js

@@ -1,23 +1,23 @@
 //// [destructuringAssignabilityCheck.ts]
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-import _throw from "@swc/helpers/src/_throw.mjs";
 var _ref = _sliced_to_array({}, 0); // should be error
-var undefined = undefined !== null ? undefined : _throw(new TypeError("Cannot destructure undefined")); // error correctly
+var ref = _object_destructuring_empty(undefined); // error correctly
 (function(param) {
     var _param = _sliced_to_array(param, 0);
     return 0;
 })({}); // should be error
 (function(param) {
-    var param = param !== null ? param : _throw(new TypeError("Cannot destructure undefined"));
+    var ref = _object_destructuring_empty(param);
     return 0;
 })(undefined); // should be error
 function foo(param) {
-    var param = param !== null ? param : _throw(new TypeError("Cannot destructure undefined"));
+    var ref = _object_destructuring_empty(param);
     return 0;
 }
 function bar(param) {
     var _param = _sliced_to_array(param, 0);
     return 0;
 }
-var _ref1 = 1, _ref1 = _ref1 !== null ? _ref1 : _throw(new TypeError("Cannot destructure undefined"));
-var _ref2 = _sliced_to_array({}, 0);
+var ref1 = _object_destructuring_empty(1);
+var _ref1 = _sliced_to_array({}, 0);

crates/swc/tests/tsc-references/destructuringAssignabilityCheck.2.minified.js

@@ -1,10 +1,4 @@
 //// [destructuringAssignabilityCheck.ts]
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-import _throw from "@swc/helpers/src/_throw.mjs";
-_sliced_to_array({}, 0);
-var undefined = undefined;
-_sliced_to_array({}, 0), function(param) {
-    var param = null !== param ? param : _throw(new TypeError("Cannot destructure undefined"));
-}(undefined);
-var _ref = 1, _ref = null !== _ref ? _ref : _throw(new TypeError("Cannot destructure undefined"));
-_sliced_to_array({}, 0);
+_sliced_to_array({}, 0), _object_destructuring_empty(void 0), _sliced_to_array({}, 0), _object_destructuring_empty(void 0), _object_destructuring_empty(1), _sliced_to_array({}, 0);

crates/swc/tests/tsc-references/destructuringEvaluationOrder(target=es2015).1.normal.js

@@ -1,6 +1,7 @@
 //// [destructuringEvaluationOrder.ts]
 // https://github.com/microsoft/TypeScript/issues/39205
 import _extends from "@swc/helpers/src/_extends.mjs";
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _object_without_properties from "@swc/helpers/src/_object_without_properties.mjs";
 import _to_property_key from "@swc/helpers/src/_to_property_key.mjs";
 let trace = [];
@@ -23,4 +24,4 @@ let _ref1 = [
     {
         x: 1
     }
-], [{}, b = a] = _ref1, a = _extends({}, _ref1[0]);
+], [{}, b = a] = _ref1, a = _extends({}, _object_destructuring_empty(_ref1[0]));

crates/swc/tests/tsc-references/destructuringEvaluationOrder(target=es2015).2.minified.js

@@ -1,5 +1,6 @@
 //// [destructuringEvaluationOrder.ts]
 import _extends from "@swc/helpers/src/_extends.mjs";
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _object_without_properties from "@swc/helpers/src/_object_without_properties.mjs";
 import _to_property_key from "@swc/helpers/src/_to_property_key.mjs";
 let trace = [], order = (n)=>trace.push(n), [{ [order(1)]: x  } = order(0)] = [], [{ [order(1)]: y  } = order(0)] = [
@@ -12,4 +13,4 @@ let _ref1 = [
     {
         x: 1
     }
-], [{}, b = a] = _ref1, a = _extends({}, _ref1[0]);
+], [{}, b = a] = _ref1, a = _extends({}, _object_destructuring_empty(_ref1[0]));

crates/swc/tests/tsc-references/destructuringEvaluationOrder(target=es5).1.normal.js

@@ -1,9 +1,9 @@
 //// [destructuringEvaluationOrder.ts]
 // https://github.com/microsoft/TypeScript/issues/39205
 import _extends from "@swc/helpers/src/_extends.mjs";
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _object_without_properties from "@swc/helpers/src/_object_without_properties.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-import _throw from "@swc/helpers/src/_throw.mjs";
 import _to_property_key from "@swc/helpers/src/_to_property_key.mjs";
 var trace = [];
 var order = function(n) {
@@ -25,4 +25,4 @@ var _ref5 = [
     {
         x: 1
     }
-], _ref6 = _sliced_to_array(_ref5, 2), _ref_ = _ref6[0], _ref_ = _ref_ !== null ? _ref_ : _throw(new TypeError("Cannot destructure undefined")), tmp3 = _ref6[1], b = tmp3 === void 0 ? a : tmp3, a = _extends({}, _ref5[0]);
+], _ref6 = _sliced_to_array(_ref5, 2), ref = _object_destructuring_empty(_ref6[0]), tmp3 = _ref6[1], b = tmp3 === void 0 ? a : tmp3, a = _extends({}, _object_destructuring_empty(_ref5[0]));

crates/swc/tests/tsc-references/destructuringEvaluationOrder(target=es5).2.minified.js

@@ -1,8 +1,8 @@
 //// [destructuringEvaluationOrder.ts]
 import _extends from "@swc/helpers/src/_extends.mjs";
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _object_without_properties from "@swc/helpers/src/_object_without_properties.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-import _throw from "@swc/helpers/src/_throw.mjs";
 import _to_property_key from "@swc/helpers/src/_to_property_key.mjs";
 var trace = [], order = function(n) {
     return trace.push(n);
@@ -18,5 +18,5 @@ var _ref1 = [
     {
         x: 1
     }
-], _ref2 = _sliced_to_array(_ref1, 2), _ref_ = _ref2[0], _ref_ = null !== _ref_ ? _ref_ : _throw(new TypeError("Cannot destructure undefined"));
-_ref2[1], _extends({}, _ref1[0]);
+], _ref2 = _sliced_to_array(_ref1, 2);
+_object_destructuring_empty(_ref2[0]), _ref2[1], _extends({}, _object_destructuring_empty(_ref1[0]));

crates/swc/tests/tsc-references/destructuringParameterDeclaration7ES5.1.normal.js

@@ -1,14 +1,14 @@
 //// [destructuringParameterDeclaration7ES5.ts]
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-import _throw from "@swc/helpers/src/_throw.mjs";
-function foo(_$param, param) {
-    var _$param = _$param !== null ? _$param : _throw(new TypeError("Cannot destructure undefined")), foo = param.foo, bar = param.bar;
+function foo(param, param1) {
+    var ref = _object_destructuring_empty(param), foo = param1.foo, bar = param1.bar;
 }
 function baz(param, param1) {
     var _param = _sliced_to_array(param, 0), foo = param1.foo, bar = param1.bar;
 }
-function one(param, _$param) {
-    var _param = _sliced_to_array(param, 0), _$param = _$param !== null ? _$param : _throw(new TypeError("Cannot destructure undefined"));
+function one(param, param1) {
+    var _param = _sliced_to_array(param, 0), ref = _object_destructuring_empty(param1);
 }
 function two(param, param1) {
     var _param = _sliced_to_array(param, 0), _param1 = _sliced_to_array(param1, 3), a = _param1[0], b = _param1[1], c = _param1[2];

crates/swc/tests/tsc-references/destructuringParameterDeclaration7ES5iterable.1.normal.js

@@ -1,14 +1,14 @@
 //// [destructuringParameterDeclaration7ES5iterable.ts]
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-import _throw from "@swc/helpers/src/_throw.mjs";
-function foo(_$param, param) {
-    var _$param = _$param !== null ? _$param : _throw(new TypeError("Cannot destructure undefined")), foo = param.foo, bar = param.bar;
+function foo(param, param1) {
+    var ref = _object_destructuring_empty(param), foo = param1.foo, bar = param1.bar;
 }
 function baz(param, param1) {
     var _param = _sliced_to_array(param, 0), foo = param1.foo, bar = param1.bar;
 }
-function one(param, _$param) {
-    var _param = _sliced_to_array(param, 0), _$param = _$param !== null ? _$param : _throw(new TypeError("Cannot destructure undefined"));
+function one(param, param1) {
+    var _param = _sliced_to_array(param, 0), ref = _object_destructuring_empty(param1);
 }
 function two(param, param1) {
     var _param = _sliced_to_array(param, 0), _param1 = _sliced_to_array(param1, 3), a = _param1[0], b = _param1[1], c = _param1[2];

crates/swc/tests/tsc-references/destructuringVoid.1.normal.js

@@ -1,3 +1,3 @@
 //// [destructuringVoid.ts]
-import _throw from "@swc/helpers/src/_throw.mjs";
-var v = v !== null ? v : _throw(new TypeError("Cannot destructure undefined"));
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
+var ref = _object_destructuring_empty(v);

crates/swc/tests/tsc-references/destructuringVoid.2.minified.js

@@ -1,3 +1,3 @@
 //// [destructuringVoid.ts]
-import _throw from "@swc/helpers/src/_throw.mjs";
-var v = null !== v ? v : _throw(new TypeError("Cannot destructure undefined"));
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
+_object_destructuring_empty(v);

crates/swc/tests/tsc-references/destructuringVoidStrictNullChecks.1.normal.js

@@ -1,3 +1,3 @@
 //// [destructuringVoidStrictNullChecks.ts]
-import _throw from "@swc/helpers/src/_throw.mjs";
-var v = v !== null ? v : _throw(new TypeError("Cannot destructure undefined"));
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
+var ref = _object_destructuring_empty(v);

crates/swc/tests/tsc-references/destructuringVoidStrictNullChecks.2.minified.js

@@ -1,3 +1,3 @@
 //// [destructuringVoidStrictNullChecks.ts]
-import _throw from "@swc/helpers/src/_throw.mjs";
-var v = null !== v ? v : _throw(new TypeError("Cannot destructure undefined"));
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
+_object_destructuring_empty(v);

crates/swc/tests/tsc-references/emptyAssignmentPatterns01_ES5.1.normal.js

@@ -1,10 +1,10 @@
 //// [emptyAssignmentPatterns01_ES5.ts]
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
 var a;
+_object_destructuring_empty(a);
 var ref;
-ref = a, ref;
-var ref1;
-ref1 = _sliced_to_array(a, 0), ref1;
+ref = _sliced_to_array(a, 0), ref;
 var _ref = [
     1,
     2

crates/swc/tests/tsc-references/emptyAssignmentPatterns01_ES5.2.minified.js

@@ -1,4 +1,5 @@
 //// [emptyAssignmentPatterns01_ES5.ts]
 var a;
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-_sliced_to_array(a, 0);
+_object_destructuring_empty(a), _sliced_to_array(a, 0);

crates/swc/tests/tsc-references/emptyAssignmentPatterns01_ES5iterable.1.normal.js

@@ -1,7 +1,7 @@
 //// [emptyAssignmentPatterns01_ES5iterable.ts]
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
 var a;
+_object_destructuring_empty(a);
 var ref;
-ref = a, ref;
-var ref1;
-ref1 = _sliced_to_array(a, 0), ref1;
+ref = _sliced_to_array(a, 0), ref;

crates/swc/tests/tsc-references/emptyAssignmentPatterns01_ES5iterable.2.minified.js

@@ -1,4 +1,5 @@
 //// [emptyAssignmentPatterns01_ES5iterable.ts]
 var a;
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-_sliced_to_array(a, 0);
+_object_destructuring_empty(a), _sliced_to_array(a, 0);

crates/swc/tests/tsc-references/emptyAssignmentPatterns02_ES5.1.normal.js

@@ -1,8 +1,9 @@
 //// [emptyAssignmentPatterns02_ES5.ts]
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
 var a;
 var x, y, z, a1, a2, a3;
-var ref, ref1;
-ref1 = (ref = a, x = ref.x, y = ref.y, z = ref.z, ref), ref1;
-var ref2, ref3;
-ref3 = _sliced_to_array((ref2 = _sliced_to_array(a, 3), a1 = ref2[0], a2 = ref2[1], a3 = ref2[2], ref2), 0), ref3;
+var ref;
+_object_destructuring_empty((ref = a, x = ref.x, y = ref.y, z = ref.z, ref));
+var ref1, ref2;
+ref2 = _sliced_to_array((ref1 = _sliced_to_array(a, 3), a1 = ref1[0], a2 = ref1[1], a3 = ref1[2], ref1), 0), ref2;

crates/swc/tests/tsc-references/emptyAssignmentPatterns02_ES5.2.minified.js

@@ -1,4 +1,5 @@
 //// [emptyAssignmentPatterns02_ES5.ts]
 var a, ref;
+import _object_destructuring_empty from "@swc/helpers/src/_object_destructuring_empty.mjs";
 import _sliced_to_array from "@swc/helpers/src/_sliced_to_array.mjs";
-a.x, a.y, a.z, _sliced_to_array(((ref = _sliced_to_array(a, 3))[0], ref[1], ref[2], ref), 0);
+_object_destructuring_empty((a.x, a.y, a.z, a)), _sliced_to_array(((ref = _sliced_to_array(a, 3))[0], ref[1], ref[2], ref), 0);