fix(es/compat): Handle super access in a private static property (#6361)

swc-project · Nov 5, 2022 · 6cc9e90 · 6cc9e90 · github-actions · Nov 5, 2022
1 parent 134b134
commit 6cc9e90
Show file tree

Hide file tree

Showing 12 changed files with 796 additions and 264 deletions.
diff --git a/crates/swc/tests/tsc-references/classStaticBlock5(target=es2015).1.normal.js b/crates/swc/tests/tsc-references/classStaticBlock5(target=es2015).1.normal.js
@@ -13,7 +13,7 @@ var __ = {
     writable: true,
     value: (()=>{
         C.b;
-        super.b;
-        super.a;
+        _get(_get_prototype_of(C), "b", C);
+        _get(_get_prototype_of(C), "a", C);
     })()
 };
diff --git a/crates/swc/tests/tsc-references/classStaticBlock5(target=es2015).2.minified.js b/crates/swc/tests/tsc-references/classStaticBlock5(target=es2015).2.minified.js
@@ -6,4 +6,4 @@ class B {
 B.a = 1, B.b = 2;
 class C extends B {
 }
-C.b = 3, C.c = _get(_get_prototype_of(C), "a", C), C.b, super.b, super.a;
+C.b = 3, C.c = _get(_get_prototype_of(C), "a", C), C.b, _get(_get_prototype_of(C), "b", C), _get(_get_prototype_of(C), "a", C);
diff --git a/crates/swc/tests/tsc-references/classStaticBlock5(target=es5).1.normal.js b/crates/swc/tests/tsc-references/classStaticBlock5(target=es5).1.normal.js
@@ -4,7 +4,6 @@ import _get from "@swc/helpers/src/_get.mjs";
 import _get_prototype_of from "@swc/helpers/src/_get_prototype_of.mjs";
 import _inherits from "@swc/helpers/src/_inherits.mjs";
 import _create_super from "@swc/helpers/src/_create_super.mjs";
-var _superprop_get_b = ()=>super.b, _superprop_get_a = ()=>super.a;
 var B = function B() {
     "use strict";
     _class_call_check(this, B);
@@ -27,7 +26,7 @@ var __ = {
     writable: true,
     value: function() {
         C.b;
-        _superprop_get_b();
-        _superprop_get_a();
+        _get(_get_prototype_of(C), "b", C);
+        _get(_get_prototype_of(C), "a", C);
     }()
 };
diff --git a/crates/swc/tests/tsc-references/classStaticBlock5(target=es5).2.minified.js b/crates/swc/tests/tsc-references/classStaticBlock5(target=es5).2.minified.js
@@ -18,4 +18,4 @@ var C = function(B) {
     }
     return C;
 }(B);
-C.b = 3, C.c = _get(_get_prototype_of(C), "a", C), C.b, super.b, super.a;
+C.b = 3, C.c = _get(_get_prototype_of(C), "a", C), C.b, _get(_get_prototype_of(C), "b", C), _get(_get_prototype_of(C), "a", C);
Benchmark suite	Current: `6cc9e90`	Previous: `8123bf0`	Ratio
`es/full/bugs-1`	`348228` ns/iter (`± 19534`)	`343343` ns/iter (`± 27668`)	`1.01`
`es/full/minify/libraries/antd`	`1901637821` ns/iter (`± 46749020`)	`1862921911` ns/iter (`± 67546291`)	`1.02`
`es/full/minify/libraries/d3`	`418685431` ns/iter (`± 13781535`)	`456943209` ns/iter (`± 77559708`)	`0.92`
`es/full/minify/libraries/echarts`	`1613872450` ns/iter (`± 36929596`)	`1681460292` ns/iter (`± 83058984`)	`0.96`
`es/full/minify/libraries/jquery`	`119365341` ns/iter (`± 8773959`)	`101039469` ns/iter (`± 2202933`)	`1.18`
`es/full/minify/libraries/lodash`	`136487309` ns/iter (`± 7400297`)	`125437813` ns/iter (`± 7561945`)	`1.09`
`es/full/minify/libraries/moment`	`59527896` ns/iter (`± 1715040`)	`60542407` ns/iter (`± 4701614`)	`0.98`
`es/full/minify/libraries/react`	`20747002` ns/iter (`± 898055`)	`20558806` ns/iter (`± 1229623`)	`1.01`
`es/full/minify/libraries/terser`	`315728962` ns/iter (`± 7801742`)	`320858886` ns/iter (`± 30362068`)	`0.98`
`es/full/minify/libraries/three`	`568646840` ns/iter (`± 30625141`)	`561827252` ns/iter (`± 21378446`)	`1.01`
`es/full/minify/libraries/typescript`	`3491109046` ns/iter (`± 47846620`)	`3423518124` ns/iter (`± 69640837`)	`1.02`
`es/full/minify/libraries/victory`	`858557132` ns/iter (`± 26752846`)	`833597110` ns/iter (`± 37338157`)	`1.03`
`es/full/minify/libraries/vue`	`152055768` ns/iter (`± 5563797`)	`162776567` ns/iter (`± 25061041`)	`0.93`
`es/full/codegen/es3`	`35192` ns/iter (`± 5421`)	`33865` ns/iter (`± 1734`)	`1.04`
`es/full/codegen/es5`	`33955` ns/iter (`± 4179`)	`33984` ns/iter (`± 975`)	`1.00`
`es/full/codegen/es2015`	`34034` ns/iter (`± 4401`)	`33960` ns/iter (`± 2196`)	`1.00`
`es/full/codegen/es2016`	`33590` ns/iter (`± 4594`)	`33730` ns/iter (`± 1539`)	`1.00`
`es/full/codegen/es2017`	`34333` ns/iter (`± 4566`)	`33944` ns/iter (`± 1208`)	`1.01`
`es/full/codegen/es2018`	`35200` ns/iter (`± 5417`)	`33843` ns/iter (`± 1227`)	`1.04`
`es/full/codegen/es2019`	`32986` ns/iter (`± 1728`)	`33857` ns/iter (`± 2484`)	`0.97`
`es/full/codegen/es2020`	`32357` ns/iter (`± 1322`)	`34021` ns/iter (`± 1967`)	`0.95`
`es/full/all/es3`	`188282853` ns/iter (`± 4177376`)	`195120515` ns/iter (`± 11282219`)	`0.96`
`es/full/all/es5`	`179275476` ns/iter (`± 5596067`)	`189545443` ns/iter (`± 12038590`)	`0.95`
`es/full/all/es2015`	`143278757` ns/iter (`± 2890295`)	`148921470` ns/iter (`± 7644693`)	`0.96`
`es/full/all/es2016`	`142571986` ns/iter (`± 4470917`)	`148399464` ns/iter (`± 15501230`)	`0.96`
`es/full/all/es2017`	`141666120` ns/iter (`± 4779840`)	`154987026` ns/iter (`± 15690787`)	`0.91`
`es/full/all/es2018`	`141373552` ns/iter (`± 4179702`)	`156704302` ns/iter (`± 12450944`)	`0.90`
`es/full/all/es2019`	`148868582` ns/iter (`± 12036422`)	`153811086` ns/iter (`± 14230746`)	`0.97`
`es/full/all/es2020`	`144637675` ns/iter (`± 7212519`)	`159079289` ns/iter (`± 16477066`)	`0.91`
`es/full/parser`	`799122` ns/iter (`± 101172`)	`752161` ns/iter (`± 45952`)	`1.06`
`es/full/base/fixer`	`26794` ns/iter (`± 2548`)	`27213` ns/iter (`± 2089`)	`0.98`
`es/full/base/resolver_and_hygiene`	`93121` ns/iter (`± 9954`)	`93181` ns/iter (`± 16766`)	`1.00`
`serialization of ast node`	`237` ns/iter (`± 45`)	`214` ns/iter (`± 2`)	`1.11`
`serialization of serde`	`220` ns/iter (`± 21`)	`216` ns/iter (`± 53`)	`1.02`