Skip to content

Commit

Permalink
build(es/plugin): Fix Wasm build (#6179)
Browse files Browse the repository at this point in the history
  • Loading branch information
kdy1 committed Oct 17, 2022
1 parent 167359e commit 7c40e44
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
12 changes: 6 additions & 6 deletions crates/swc_plugin_runner/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,14 @@ swc_common = { version = "0.29.8", path = "../swc_common", features = [
swc_ecma_ast = { version = "0.94.11", path = "../swc_ecma_ast" }
swc_plugin_proxy = { version = "0.22.11", path = "../swc_plugin_proxy" }

tracing = "0.1.32"
wasmer = { version = "2.3.0", default-features = false }
wasmer-compiler-cranelift = { version = "2.3.0", default-features = false }
wasmer-engine-universal = { version = "2.3.0", default-features = false }
wasmer-wasi = { version = "2.3.0", default-features = false }
tracing = "0.1.32"
wasmer = { version = "2.3.0", default-features = false }
wasmer-wasi = { version = "2.3.0", default-features = false }

[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
wasmer-cache = { version = "2.3.0", optional = true }
wasmer-cache = { version = "2.3.0", optional = true }
wasmer-compiler-cranelift = { version = "2.3.0" }
wasmer-engine-universal = { version = "2.3.0" }

[dev-dependencies]
criterion = "0.3"
Expand Down
6 changes: 6 additions & 0 deletions crates/swc_plugin_runner/src/cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ impl PluginModuleCache {
/// Creates an instnace of [Store].
///
/// This function exists because we need to disable simd.
#[cfg(not(target_arch = "wasm32"))]
fn new_store() -> Store {
// Use empty enumset to disable simd.
let mut set = EnumSet::new();
Expand All @@ -255,3 +256,8 @@ fn new_store() -> Store {
let tunables = BaseTunables::for_target(engine.target());
Store::new_with_tunables(&engine, tunables)
}

#[cfg(target_arch = "wasm32")]
fn new_store() -> Store {
Store::default()
}

1 comment on commit 7c40e44

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 7c40e44 Previous: cb8f350 Ratio
es/full/minify/libraries/antd 1872475029 ns/iter (± 32683387) 1775410094 ns/iter (± 25135944) 1.05
es/full/minify/libraries/d3 415776660 ns/iter (± 14072984) 369964686 ns/iter (± 12605973) 1.12
es/full/minify/libraries/echarts 1559644664 ns/iter (± 29185442) 1558020272 ns/iter (± 164396669) 1.00
es/full/minify/libraries/jquery 110021355 ns/iter (± 2268541) 95921619 ns/iter (± 3433476) 1.15
es/full/minify/libraries/lodash 129026016 ns/iter (± 3371456) 115087462 ns/iter (± 11766488) 1.12
es/full/minify/libraries/moment 62064355 ns/iter (± 3858222) 78136969 ns/iter (± 23198633) 0.79
es/full/minify/libraries/react 21094559 ns/iter (± 1143350) 20263285 ns/iter (± 853199) 1.04
es/full/minify/libraries/terser 328732232 ns/iter (± 5958613) 308659975 ns/iter (± 9375412) 1.07
es/full/minify/libraries/three 568350647 ns/iter (± 11907740) 560918939 ns/iter (± 40649540) 1.01
es/full/minify/libraries/typescript 3542930512 ns/iter (± 56527982) 3464193675 ns/iter (± 101081265) 1.02
es/full/minify/libraries/victory 833583319 ns/iter (± 113109182) 823218568 ns/iter (± 33323259) 1.01
es/full/minify/libraries/vue 177278050 ns/iter (± 15303820) 144241553 ns/iter (± 10072677) 1.23
es/full/codegen/es3 33692 ns/iter (± 2478) 33364 ns/iter (± 1544) 1.01
es/full/codegen/es5 33716 ns/iter (± 1447) 33344 ns/iter (± 547) 1.01
es/full/codegen/es2015 33509 ns/iter (± 2583) 33646 ns/iter (± 1381) 1.00
es/full/codegen/es2016 34098 ns/iter (± 2984) 33585 ns/iter (± 1913) 1.02
es/full/codegen/es2017 33717 ns/iter (± 4133) 33707 ns/iter (± 1877) 1.00
es/full/codegen/es2018 34189 ns/iter (± 9495) 33740 ns/iter (± 5028) 1.01
es/full/codegen/es2019 33751 ns/iter (± 1636) 34399 ns/iter (± 4842) 0.98
es/full/codegen/es2020 33703 ns/iter (± 930) 34268 ns/iter (± 2400) 0.98
es/full/all/es3 228784543 ns/iter (± 22307434) 191209500 ns/iter (± 9908762) 1.20
es/full/all/es5 226520967 ns/iter (± 104393138) 180754939 ns/iter (± 9309890) 1.25
es/full/all/es2015 178912433 ns/iter (± 18551491) 144903171 ns/iter (± 14610725) 1.23
es/full/all/es2016 175385932 ns/iter (± 14371832) 144993033 ns/iter (± 7806876) 1.21
es/full/all/es2017 172968841 ns/iter (± 18371456) 143705139 ns/iter (± 9166430) 1.20
es/full/all/es2018 172992192 ns/iter (± 16006862) 142446677 ns/iter (± 6177405) 1.21
es/full/all/es2019 166492653 ns/iter (± 33318217) 141262678 ns/iter (± 9563018) 1.18
es/full/all/es2020 164008573 ns/iter (± 21686908) 136219575 ns/iter (± 6395694) 1.20
es/full/parser 765261 ns/iter (± 66390) 716139 ns/iter (± 29277) 1.07
es/full/base/fixer 26818 ns/iter (± 1671) 26364 ns/iter (± 2128) 1.02
es/full/base/resolver_and_hygiene 98891 ns/iter (± 14352) 94501 ns/iter (± 8550) 1.05
serialization of ast node 212 ns/iter (± 16) 217 ns/iter (± 15) 0.98
serialization of serde 234 ns/iter (± 16) 211 ns/iter (± 10) 1.11

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.