Skip to content

Commit

Permalink
feat(es/parser): Relax MSRV requirement (#3922)
Browse files Browse the repository at this point in the history
  • Loading branch information
kdy1 committed Mar 9, 2022
1 parent c80d5c8 commit a8ac7e3
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions crates/swc_ecma_parser/src/error.rs
Expand Up @@ -422,9 +422,11 @@ impl SyntaxError {
SyntaxError::PropertyNamedConstructor => {
"Classes may not have a non-static field named 'constructor'".into()
}
SyntaxError::PrivateNameModifier(modifier) => {
format!("'{modifier}' modifier cannot be used with a private identifier").into()
}
SyntaxError::PrivateNameModifier(modifier) => format!(
"'{}' modifier cannot be used with a private identifier",
modifier
)
.into(),

SyntaxError::ReadOnlyMethod => "A method cannot be readonly".into(),
SyntaxError::TsBindingPatCannotBeOptional => "A binding pattern parameter cannot be \
Expand Down

1 comment on commit a8ac7e3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: a8ac7e3 Previous: c2b9e1c Ratio
full_es2015 182793440 ns/iter (± 18873424) 178978238 ns/iter (± 17138594) 1.02
full_es2016 173334943 ns/iter (± 15987475) 176603118 ns/iter (± 12054112) 0.98
full_es2017 174916495 ns/iter (± 15424205) 175927919 ns/iter (± 9445851) 0.99
full_es2018 172461716 ns/iter (± 16636015) 175957896 ns/iter (± 9479746) 0.98
full_es2019 173462598 ns/iter (± 21158680) 173846495 ns/iter (± 13580555) 1.00
full_es2020 153875876 ns/iter (± 10681840) 160014418 ns/iter (± 7966590) 0.96
full_es3 219369768 ns/iter (± 14511045) 229912376 ns/iter (± 15082472) 0.95
full_es5 223149255 ns/iter (± 29047397) 220424989 ns/iter (± 12013186) 1.01
parser 689349 ns/iter (± 106556) 613293 ns/iter (± 28874) 1.12

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.