fix(css/minifier): Don't touch @supports (#6199)

swc-project · Oct 19, 2022 · ac7cfa1 · ac7cfa1 · github-actions · Oct 19, 2022
1 parent 287c2f2
commit ac7cfa1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/crates/swc_css_minifier/src/compressor/mod.rs b/crates/swc_css_minifier/src/compressor/mod.rs
@@ -213,7 +213,11 @@ impl VisitMut for Compressor {
             ..self.ctx
         }));
 
-        self.compress_calc_sum(n);
+        // Don't touch `@supports`, it can be used to check a browser's support for one
+        // or more specific CSS features
+        if !self.in_supports_conidition {
+            self.compress_calc_sum(n);
+        }
     }
 
     fn visit_mut_component_value(&mut self, n: &mut ComponentValue) {

diff --git a/crates/swc_css_minifier/tests/fixture/compress-calc/supports-condition/input.css b/crates/swc_css_minifier/tests/fixture/compress-calc/supports-condition/input.css
@@ -21,3 +21,9 @@
         background: red;
     }
 }
+
+@supports (width: calc(100px * sqrt(9))) {
+    div {
+        background: red;
+    }
+}
diff --git a/crates/swc_css_minifier/tests/fixture/compress-calc/supports-condition/output.min.css b/crates/swc_css_minifier/tests/fixture/compress-calc/supports-condition/output.min.css
Benchmark suite	Current: `ac7cfa1`	Previous: `842abd4`	Ratio
`es/full/minify/libraries/antd`	`1936211939` ns/iter (`± 84626124`)	`1987920106` ns/iter (`± 38350667`)	`0.97`
`es/full/minify/libraries/d3`	`407642390` ns/iter (`± 23512584`)	`454701610` ns/iter (`± 22105722`)	`0.90`
`es/full/minify/libraries/echarts`	`1575935113` ns/iter (`± 51718197`)	`1822721566` ns/iter (`± 430307712`)	`0.86`
`es/full/minify/libraries/jquery`	`114110115` ns/iter (`± 4748088`)	`116499814` ns/iter (`± 11769607`)	`0.98`
`es/full/minify/libraries/lodash`	`118953556` ns/iter (`± 7356986`)	`132333266` ns/iter (`± 10850176`)	`0.90`
`es/full/minify/libraries/moment`	`63147471` ns/iter (`± 11386188`)	`79246110` ns/iter (`± 13373743`)	`0.80`
`es/full/minify/libraries/react`	`19766423` ns/iter (`± 418342`)	`22049141` ns/iter (`± 1228722`)	`0.90`
`es/full/minify/libraries/terser`	`317328741` ns/iter (`± 10994451`)	`351748932` ns/iter (`± 37835653`)	`0.90`
`es/full/minify/libraries/three`	`555009274` ns/iter (`± 16838877`)	`614463318` ns/iter (`± 38044971`)	`0.90`
`es/full/minify/libraries/typescript`	`3351725271` ns/iter (`± 54038362`)	`3731332042` ns/iter (`± 109327183`)	`0.90`
`es/full/minify/libraries/victory`	`793090127` ns/iter (`± 12092898`)	`1000605691` ns/iter (`± 68287295`)	`0.79`
`es/full/minify/libraries/vue`	`140598366` ns/iter (`± 3999963`)	`195728434` ns/iter (`± 19696210`)	`0.72`
`es/full/codegen/es3`	`32909` ns/iter (`± 917`)	`38207` ns/iter (`± 7380`)	`0.86`
`es/full/codegen/es5`	`32882` ns/iter (`± 1775`)	`36399` ns/iter (`± 5843`)	`0.90`
`es/full/codegen/es2015`	`33053` ns/iter (`± 1068`)	`40705` ns/iter (`± 6214`)	`0.81`
`es/full/codegen/es2016`	`33044` ns/iter (`± 742`)	`38705` ns/iter (`± 6792`)	`0.85`
`es/full/codegen/es2017`	`32941` ns/iter (`± 387`)	`40114` ns/iter (`± 6343`)	`0.82`
`es/full/codegen/es2018`	`33250` ns/iter (`± 1001`)	`42386` ns/iter (`± 7881`)	`0.78`
`es/full/codegen/es2019`	`33451` ns/iter (`± 770`)	`39960` ns/iter (`± 6800`)	`0.84`
`es/full/codegen/es2020`	`33471` ns/iter (`± 1632`)	`37409` ns/iter (`± 5336`)	`0.89`
`es/full/all/es3`	`189949137` ns/iter (`± 7198156`)	`247828681` ns/iter (`± 26836941`)	`0.77`
`es/full/all/es5`	`180394514` ns/iter (`± 4943662`)	`228299889` ns/iter (`± 32952433`)	`0.79`
`es/full/all/es2015`	`144251831` ns/iter (`± 6262216`)	`188536936` ns/iter (`± 20727926`)	`0.77`
`es/full/all/es2016`	`145473955` ns/iter (`± 7923568`)	`193588097` ns/iter (`± 19695210`)	`0.75`
`es/full/all/es2017`	`144483319` ns/iter (`± 4246513`)	`191247476` ns/iter (`± 19413051`)	`0.76`
`es/full/all/es2018`	`140014291` ns/iter (`± 5864304`)	`187477093` ns/iter (`± 20962967`)	`0.75`
`es/full/all/es2019`	`140680247` ns/iter (`± 5309763`)	`189771349` ns/iter (`± 18380408`)	`0.74`
`es/full/all/es2020`	`134900780` ns/iter (`± 2957383`)	`181164204` ns/iter (`± 22428478`)	`0.74`
`es/full/parser`	`707857` ns/iter (`± 55110`)	`923359` ns/iter (`± 141678`)	`0.77`
`es/full/base/fixer`	`26676` ns/iter (`± 2952`)	`31768` ns/iter (`± 3808`)	`0.84`
`es/full/base/resolver_and_hygiene`	`93061` ns/iter (`± 2317`)	`105770` ns/iter (`± 15684`)	`0.88`
`serialization of ast node`	`218` ns/iter (`± 8`)	`272` ns/iter (`± 48`)	`0.80`
`serialization of serde`	`215` ns/iter (`± 3`)	`255` ns/iter (`± 48`)	`0.84`