Skip to content

Commit

Permalink
refactor(common): Cleanup source_map.rs (#6570)
Browse files Browse the repository at this point in the history
  • Loading branch information
jridgewell committed Dec 3, 2022
1 parent ab5635c commit b3ea52f
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions crates/swc_common/src/source_map.rs
Expand Up @@ -1249,17 +1249,13 @@ impl SourceMap {
continue;
}

let a = match f.lookup_line(pos) {
let mut line = match f.lookup_line(pos) {
Some(line) => line as u32,
None => continue,
};

let mut name = config.name_for_bytepos(pos);
let mut name_idx = None;

let mut line = a;

let linebpos = f.lines[a as usize];
let linebpos = f.lines[line as usize];
debug_assert!(
pos >= linebpos,
"{}: bpos = {:?}; linebpos = {:?};",
Expand Down Expand Up @@ -1302,9 +1298,7 @@ impl SourceMap {
}
}

if let Some(name) = name {
name_idx = Some(builder.add_name(name))
}
let name_idx = name.map(|name| builder.add_name(name));

builder.add_raw(lc.line, lc.col, line, col, Some(src_id), name_idx);
prev_dst_line = lc.line;
Expand Down

1 comment on commit b3ea52f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: b3ea52f Previous: fa8f7b0 Ratio
es/full/bugs-1 343801 ns/iter (± 20816) 353239 ns/iter (± 39445) 0.97
es/full/minify/libraries/antd 2074193534 ns/iter (± 30405152) 2078251310 ns/iter (± 27895652) 1.00
es/full/minify/libraries/d3 464031120 ns/iter (± 7391889) 456454566 ns/iter (± 24957236) 1.02
es/full/minify/libraries/echarts 1759691063 ns/iter (± 28454434) 1860832278 ns/iter (± 273792038) 0.95
es/full/minify/libraries/jquery 117025630 ns/iter (± 1086192) 127488036 ns/iter (± 19543741) 0.92
es/full/minify/libraries/lodash 134996226 ns/iter (± 5100567) 146296630 ns/iter (± 5873202) 0.92
es/full/minify/libraries/moment 67771633 ns/iter (± 2414796) 76142469 ns/iter (± 10048933) 0.89
es/full/minify/libraries/react 22860831 ns/iter (± 926675) 23984111 ns/iter (± 2864805) 0.95
es/full/minify/libraries/terser 361358001 ns/iter (± 9156009) 391689879 ns/iter (± 11489362) 0.92
es/full/minify/libraries/three 640193589 ns/iter (± 16087997) 680315768 ns/iter (± 50673572) 0.94
es/full/minify/libraries/typescript 3747256017 ns/iter (± 43887440) 4165509204 ns/iter (± 772377694) 0.90
es/full/minify/libraries/victory 962472607 ns/iter (± 26793385) 999466221 ns/iter (± 87948207) 0.96
es/full/minify/libraries/vue 175548395 ns/iter (± 9521210) 189639080 ns/iter (± 14866423) 0.93
es/full/codegen/es3 34843 ns/iter (± 4262) 34227 ns/iter (± 2058) 1.02
es/full/codegen/es5 37205 ns/iter (± 5140) 34356 ns/iter (± 1149) 1.08
es/full/codegen/es2015 34240 ns/iter (± 3652) 34241 ns/iter (± 3424) 1.00
es/full/codegen/es2016 34501 ns/iter (± 3868) 34078 ns/iter (± 2532) 1.01
es/full/codegen/es2017 34396 ns/iter (± 1523) 33193 ns/iter (± 1439) 1.04
es/full/codegen/es2018 34174 ns/iter (± 1919) 33384 ns/iter (± 938) 1.02
es/full/codegen/es2019 34464 ns/iter (± 2896) 33240 ns/iter (± 1294) 1.04
es/full/codegen/es2020 34143 ns/iter (± 4401) 34740 ns/iter (± 3285) 0.98
es/full/all/es3 200427698 ns/iter (± 10403125) 200755501 ns/iter (± 16424703) 1.00
es/full/all/es5 195509378 ns/iter (± 13780140) 186831116 ns/iter (± 21854864) 1.05
es/full/all/es2015 149577455 ns/iter (± 14144437) 154262824 ns/iter (± 20845504) 0.97
es/full/all/es2016 145033761 ns/iter (± 7533543) 153665360 ns/iter (± 19825682) 0.94
es/full/all/es2017 145422970 ns/iter (± 6738295) 154896418 ns/iter (± 19178490) 0.94
es/full/all/es2018 145488546 ns/iter (± 5955845) 151192080 ns/iter (± 18049025) 0.96
es/full/all/es2019 142097566 ns/iter (± 4973738) 150965646 ns/iter (± 18227895) 0.94
es/full/all/es2020 136534753 ns/iter (± 3921701) 140647028 ns/iter (± 18889302) 0.97
es/full/parser 734155 ns/iter (± 92517) 744440 ns/iter (± 56755) 0.99
es/full/base/fixer 26396 ns/iter (± 1588) 26906 ns/iter (± 2918) 0.98
es/full/base/resolver_and_hygiene 91086 ns/iter (± 5520) 93229 ns/iter (± 7273) 0.98
serialization of ast node 220 ns/iter (± 38) 216 ns/iter (± 8) 1.02
serialization of serde 224 ns/iter (± 28) 232 ns/iter (± 29) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.