Skip to content

Commit

Permalink
refactor(css/prefixer): Use eq_ignore_span (#6656)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexander-akait committed Dec 15, 2022
1 parent d48f4ba commit d4660a4
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions crates/swc_css_prefixer/src/prefixer.rs
Expand Up @@ -1115,7 +1115,7 @@ impl VisitMut for Prefixer {
"-moz-placeholder",
);

if new_moz_prelude_with_previous != new_moz_prelude {
if !new_moz_prelude_with_previous.eq_ignore_span(&new_moz_prelude) {
let qualified_rule = Box::new(QualifiedRule {
span: DUMMY_SP,
prelude: new_moz_prelude_with_previous,
Expand Down Expand Up @@ -1201,7 +1201,7 @@ impl VisitMut for Prefixer {
"-ms-input-placeholder",
);

if new_ms_prelude_with_previous != new_ms_prelude {
if !new_ms_prelude_with_previous.eq_ignore_span(&new_ms_prelude) {
let qualified_rule = Box::new(QualifiedRule {
span: DUMMY_SP,
prelude: new_ms_prelude_with_previous,
Expand Down Expand Up @@ -1805,7 +1805,7 @@ impl VisitMut for Prefixer {
);
}

if n.value != old_spec_webkit_value {
if !n.value.eq_ignore_span(&old_spec_webkit_value) {
self.added_declarations.push(Box::new(Declaration {
span: n.span,
name: n.name.clone(),
Expand Down Expand Up @@ -2458,7 +2458,7 @@ impl VisitMut for Prefixer {

replace_ident(&mut old_spec_ms_value, "pixelated", "nearest-neighbor");

if ms_value != old_spec_ms_value {
if !ms_value.eq_ignore_span(&old_spec_ms_value) {
add_declaration!(
Prefix::Ms,
"-ms-interpolation-mode",
Expand Down Expand Up @@ -3356,7 +3356,7 @@ impl VisitMut for Prefixer {
_ => {}
}

if n.value != webkit_value {
if !n.value.eq_ignore_span(&webkit_value) {
self.added_declarations.push(Box::new(Declaration {
span: n.span,
name: n.name.clone(),
Expand All @@ -3365,7 +3365,7 @@ impl VisitMut for Prefixer {
}));
}

if n.value != moz_value {
if !n.value.eq_ignore_span(&moz_value) {
self.added_declarations.push(Box::new(Declaration {
span: n.span,
name: n.name.clone(),
Expand All @@ -3374,7 +3374,7 @@ impl VisitMut for Prefixer {
}));
}

if n.value != o_value {
if !n.value.eq_ignore_span(&o_value) {
self.added_declarations.push(Box::new(Declaration {
span: n.span,
name: n.name.clone(),
Expand All @@ -3383,7 +3383,7 @@ impl VisitMut for Prefixer {
}));
}

if n.value != ms_value {
if !n.value.eq_ignore_span(&ms_value) {
self.added_declarations.push(Box::new(Declaration {
span: n.span,
name: n.name.clone(),
Expand Down

1 comment on commit d4660a4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d4660a4 Previous: cb4173a Ratio
es/full/bugs-1 306238 ns/iter (± 5409) 307549 ns/iter (± 17103) 1.00
es/full/minify/libraries/antd 1813214071 ns/iter (± 24110094) 1747643644 ns/iter (± 19341265) 1.04
es/full/minify/libraries/d3 358028346 ns/iter (± 4770174) 313284816 ns/iter (± 4775108) 1.14
es/full/minify/libraries/echarts 1516432233 ns/iter (± 11790366) 1354874075 ns/iter (± 12750915) 1.12
es/full/minify/libraries/jquery 93577563 ns/iter (± 1548305) 92036818 ns/iter (± 776717) 1.02
es/full/minify/libraries/lodash 113491314 ns/iter (± 912692) 107803067 ns/iter (± 793937) 1.05
es/full/minify/libraries/moment 54977236 ns/iter (± 629797) 53624495 ns/iter (± 356373) 1.03
es/full/minify/libraries/react 20206008 ns/iter (± 226294) 19217933 ns/iter (± 334353) 1.05
es/full/minify/libraries/terser 275631697 ns/iter (± 3852669) 257417945 ns/iter (± 2765754) 1.07
es/full/minify/libraries/three 516248082 ns/iter (± 7236671) 491971444 ns/iter (± 5626645) 1.05
es/full/minify/libraries/typescript 3418482967 ns/iter (± 15113725) 3343596629 ns/iter (± 36374127) 1.02
es/full/minify/libraries/victory 788236150 ns/iter (± 20913210) 755861182 ns/iter (± 15794788) 1.04
es/full/minify/libraries/vue 140605213 ns/iter (± 3176020) 132540867 ns/iter (± 2237567) 1.06
es/full/codegen/es3 27519 ns/iter (± 55) 27342 ns/iter (± 60) 1.01
es/full/codegen/es5 27547 ns/iter (± 51) 27224 ns/iter (± 48) 1.01
es/full/codegen/es2015 27556 ns/iter (± 42) 27206 ns/iter (± 75) 1.01
es/full/codegen/es2016 27518 ns/iter (± 104) 27199 ns/iter (± 58) 1.01
es/full/codegen/es2017 27562 ns/iter (± 53) 27159 ns/iter (± 64) 1.01
es/full/codegen/es2018 27549 ns/iter (± 46) 27169 ns/iter (± 72) 1.01
es/full/codegen/es2019 27563 ns/iter (± 52) 27196 ns/iter (± 38) 1.01
es/full/codegen/es2020 27555 ns/iter (± 60) 27183 ns/iter (± 58) 1.01
es/full/all/es3 173796641 ns/iter (± 3452557) 165807884 ns/iter (± 2838023) 1.05
es/full/all/es5 164734039 ns/iter (± 3395151) 159599653 ns/iter (± 1206851) 1.03
es/full/all/es2015 122652359 ns/iter (± 1409807) 119457396 ns/iter (± 651824) 1.03
es/full/all/es2016 122547168 ns/iter (± 1799016) 118742186 ns/iter (± 754297) 1.03
es/full/all/es2017 121390531 ns/iter (± 834341) 117044212 ns/iter (± 946954) 1.04
es/full/all/es2018 120050713 ns/iter (± 1793872) 115900335 ns/iter (± 625258) 1.04
es/full/all/es2019 119488331 ns/iter (± 1544378) 115242257 ns/iter (± 757364) 1.04
es/full/all/es2020 113323926 ns/iter (± 1243616) 110804480 ns/iter (± 773503) 1.02
es/full/parser 510868 ns/iter (± 8197) 517522 ns/iter (± 8407) 0.99
es/full/base/fixer 21859 ns/iter (± 40) 21674 ns/iter (± 24) 1.01
es/full/base/resolver_and_hygiene 77244 ns/iter (± 78) 77950 ns/iter (± 400) 0.99
serialization of ast node 138 ns/iter (± 0) 138 ns/iter (± 0) 1
serialization of serde 124 ns/iter (± 0) 124 ns/iter (± 0) 1
css/minify/libraries/bootstrap 27630963 ns/iter (± 281723) 27171931 ns/iter (± 159908) 1.02
css/visitor/compare/clone 2400570 ns/iter (± 67826) 2052928 ns/iter (± 16640) 1.17
css/visitor/compare/visit_mut_span 2629116 ns/iter (± 4778) 2254912 ns/iter (± 5824) 1.17
css/visitor/compare/visit_mut_span_panic 2711574 ns/iter (± 4273) 2302595 ns/iter (± 3875) 1.18
css/visitor/compare/fold_span 3412560 ns/iter (± 36609) 3014376 ns/iter (± 22136) 1.13
css/visitor/compare/fold_span_panic 3537237 ns/iter (± 34789) 3140004 ns/iter (± 21920) 1.13
css/lexer/bootstrap_5_1_3 5267194 ns/iter (± 10082) 5195876 ns/iter (± 5685) 1.01
css/lexer/foundation_6_7_4 4428573 ns/iter (± 6674) 4411955 ns/iter (± 5414) 1.00
css/lexer/tailwind_3_1_1 829536 ns/iter (± 810) 827014 ns/iter (± 921) 1.00
css/parser/bootstrap_5_1_3 20877713 ns/iter (± 709879) 20795778 ns/iter (± 92331) 1.00
css/parser/foundation_6_7_4 16661317 ns/iter (± 34709) 16614590 ns/iter (± 358718) 1.00
css/parser/tailwind_3_1_1 3194471 ns/iter (± 2501) 3191332 ns/iter (± 1817) 1.00
es/codegen/colors 321387 ns/iter (± 182880) 322832 ns/iter (± 181265) 1.00
es/codegen/large 1087571 ns/iter (± 555511) 1222619 ns/iter (± 648829) 0.89
es/codegen/with-parser/colors 46061 ns/iter (± 62) 46444 ns/iter (± 185) 0.99
es/codegen/with-parser/large 507756 ns/iter (± 1562) 506151 ns/iter (± 792) 1.00
es/minify/libraries/antd 1606005621 ns/iter (± 12416823) 1537765646 ns/iter (± 17495496) 1.04
es/minify/libraries/d3 308288183 ns/iter (± 5642352) 270564678 ns/iter (± 2546261) 1.14
es/minify/libraries/echarts 1330680057 ns/iter (± 18473217) 1168670568 ns/iter (± 8739553) 1.14
es/minify/libraries/jquery 81384615 ns/iter (± 678014) 79049173 ns/iter (± 402012) 1.03
es/minify/libraries/lodash 101210524 ns/iter (± 1505392) 97178072 ns/iter (± 654722) 1.04
es/minify/libraries/moment 48336757 ns/iter (± 1609031) 46448220 ns/iter (± 557728) 1.04
es/minify/libraries/react 17934444 ns/iter (± 238010) 17132418 ns/iter (± 178791) 1.05
es/minify/libraries/terser 232112870 ns/iter (± 4698551) 221322840 ns/iter (± 1344115) 1.05
es/minify/libraries/three 433472497 ns/iter (± 4325185) 407318621 ns/iter (± 6715311) 1.06
es/minify/libraries/typescript 2960801303 ns/iter (± 14300384) 2872945859 ns/iter (± 16800180) 1.03
es/minify/libraries/victory 641725727 ns/iter (± 11953033) 661292915 ns/iter (± 13593674) 0.97
es/minify/libraries/vue 123967699 ns/iter (± 1987365) 120009351 ns/iter (± 1165564) 1.03
es/visitor/compare/clone 2691395 ns/iter (± 62298) 2397189 ns/iter (± 32516) 1.12
es/visitor/compare/visit_mut_span 3151130 ns/iter (± 6220) 2820002 ns/iter (± 6403) 1.12
es/visitor/compare/visit_mut_span_panic 3247291 ns/iter (± 8160) 2895829 ns/iter (± 9637) 1.12
es/visitor/compare/fold_span 4372642 ns/iter (± 24655) 4073064 ns/iter (± 19496) 1.07
es/visitor/compare/fold_span_panic 4509376 ns/iter (± 14034) 4186693 ns/iter (± 40180) 1.08
es/lexer/colors 17319 ns/iter (± 134) 17301 ns/iter (± 11) 1.00
es/lexer/angular 8249474 ns/iter (± 13823) 8277733 ns/iter (± 3768) 1.00
es/lexer/backbone 1081266 ns/iter (± 1011) 1080932 ns/iter (± 653) 1.00
es/lexer/jquery 5982518 ns/iter (± 2361) 5989510 ns/iter (± 9387) 1.00
es/lexer/jquery mobile 9199900 ns/iter (± 17783) 9217453 ns/iter (± 8822) 1.00
es/lexer/mootools 4696896 ns/iter (± 9529) 4703594 ns/iter (± 6606) 1.00
es/lexer/underscore 898838 ns/iter (± 2032) 903078 ns/iter (± 1696) 1.00
es/lexer/three 28015733 ns/iter (± 36875) 28083250 ns/iter (± 23122) 1.00
es/lexer/yui 5064813 ns/iter (± 7017) 5078391 ns/iter (± 4588) 1.00
es/parser/colors 29963 ns/iter (± 752) 31127 ns/iter (± 172) 0.96
es/parser/angular 15651319 ns/iter (± 114660) 16169038 ns/iter (± 216179) 0.97
es/parser/backbone 2301541 ns/iter (± 11060) 2329835 ns/iter (± 15506) 0.99
es/parser/jquery 12655585 ns/iter (± 130215) 12518000 ns/iter (± 69109) 1.01
es/parser/jquery mobile 20591312 ns/iter (± 364952) 19906042 ns/iter (± 165118) 1.03
es/parser/mootools 9662461 ns/iter (± 39251) 9577984 ns/iter (± 22266) 1.01
es/parser/underscore 1948577 ns/iter (± 8694) 1972276 ns/iter (± 9221) 0.99
es/parser/three 61165492 ns/iter (± 318382) 60737398 ns/iter (± 552253) 1.01
es/parser/yui 9614292 ns/iter (± 68559) 9722516 ns/iter (± 58254) 0.99
es/preset-env/usage/builtin_type 140002 ns/iter (± 30895) 138109 ns/iter (± 29992) 1.01
es/preset-env/usage/property 20983 ns/iter (± 95) 21520 ns/iter (± 119) 0.98
es/resolver/typescript 130218572 ns/iter (± 3009677) 121828619 ns/iter (± 2534116) 1.07
es/fixer/typescript 107512634 ns/iter (± 1284829) 100484955 ns/iter (± 7791125) 1.07
es/hygiene/typescript 211658464 ns/iter (± 2820023) 199837365 ns/iter (± 767829) 1.06
es/resolver_with_hygiene/typescript 359234065 ns/iter (± 1381624) 340751107 ns/iter (± 1599241) 1.05
es/visitor/base-perf/module_clone 76580 ns/iter (± 1978) 76327 ns/iter (± 1135) 1.00
es/visitor/base-perf/fold_empty 86703 ns/iter (± 1404) 86218 ns/iter (± 1582) 1.01
es/visitor/base-perf/fold_noop_impl_all 85445 ns/iter (± 1436) 85527 ns/iter (± 630) 1.00
es/visitor/base-perf/fold_noop_impl_vec 85960 ns/iter (± 1336) 86968 ns/iter (± 1212) 0.99
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 59 ns/iter (± 0) 60 ns/iter (± 0) 0.98
es/visitor/base-perf/boxing_boxed 103 ns/iter (± 0) 102 ns/iter (± 0) 1.01
es/visitor/base-perf/boxing_unboxed 103 ns/iter (± 0) 108 ns/iter (± 0) 0.95
es/visitor/base-perf/visit_contains_this 3540 ns/iter (± 90) 3560 ns/iter (± 95) 0.99
es/base/parallel/resolver/typescript 5540373260 ns/iter (± 599462708) 6119864528 ns/iter (± 453058491) 0.91
es/base/parallel/hygiene/typescript 2281114346 ns/iter (± 22406646) 2247701111 ns/iter (± 22222650) 1.01
misc/visitors/time-complexity/time 5 106 ns/iter (± 0) 93 ns/iter (± 0) 1.14
misc/visitors/time-complexity/time 10 334 ns/iter (± 1) 331 ns/iter (± 4) 1.01
misc/visitors/time-complexity/time 15 679 ns/iter (± 7) 638 ns/iter (± 1) 1.06
misc/visitors/time-complexity/time 20 1265 ns/iter (± 9) 1196 ns/iter (± 5) 1.06
misc/visitors/time-complexity/time 40 6901 ns/iter (± 119) 6149 ns/iter (± 10) 1.12
misc/visitors/time-complexity/time 60 17190 ns/iter (± 5) 15522 ns/iter (± 11) 1.11
es/full-target/es2016 189244 ns/iter (± 545) 189636 ns/iter (± 1289) 1.00
es/full-target/es2017 183643 ns/iter (± 358) 183036 ns/iter (± 612) 1.00
es/full-target/es2018 171602 ns/iter (± 396) 172317 ns/iter (± 656) 1.00
es2020_nullish_coalescing 66664 ns/iter (± 142) 67161 ns/iter (± 188) 0.99
es2020_optional_chaining 96356 ns/iter (± 168) 95859 ns/iter (± 368) 1.01
es2022_class_properties 93863 ns/iter (± 129) 93487 ns/iter (± 166) 1.00
es2018_object_rest_spread 71523 ns/iter (± 70) 71647 ns/iter (± 120) 1.00
es2019_optional_catch_binding 61126 ns/iter (± 85) 60909 ns/iter (± 115) 1.00
es2017_async_to_generator 61868 ns/iter (± 116) 61540 ns/iter (± 125) 1.01
es2016_exponentiation 64986 ns/iter (± 125) 65125 ns/iter (± 90) 1.00
es2015_arrow 69740 ns/iter (± 218) 70293 ns/iter (± 281) 0.99
es2015_block_scoped_fn 65933 ns/iter (± 118) 65846 ns/iter (± 106) 1.00
es2015_block_scoping 158946 ns/iter (± 9503) 153039 ns/iter (± 9249) 1.04
es2015_classes 116241 ns/iter (± 341) 117250 ns/iter (± 455) 0.99
es2015_computed_props 61180 ns/iter (± 119) 60986 ns/iter (± 151) 1.00
es2015_destructuring 117393 ns/iter (± 200) 116234 ns/iter (± 795) 1.01
es2015_duplicate_keys 63853 ns/iter (± 84) 63729 ns/iter (± 80) 1.00
es2015_parameters 79768 ns/iter (± 216) 79609 ns/iter (± 130) 1.00
es2015_fn_name 67005 ns/iter (± 486) 66921 ns/iter (± 448) 1.00
es2015_for_of 64387 ns/iter (± 107) 64215 ns/iter (± 163) 1.00
es2015_instanceof 63240 ns/iter (± 128) 63376 ns/iter (± 135) 1.00
es2015_shorthand_property 61168 ns/iter (± 148) 61026 ns/iter (± 200) 1.00
es2015_spread 61329 ns/iter (± 60) 61113 ns/iter (± 125) 1.00
es2015_sticky_regex 62334 ns/iter (± 128) 62722 ns/iter (± 255) 0.99
es2015_typeof_symbol 62439 ns/iter (± 166) 62302 ns/iter (± 156) 1.00
es/transform/baseline/base 52032 ns/iter (± 133) 51825 ns/iter (± 126) 1.00
es/transform/baseline/common_reserved_word 62889 ns/iter (± 193) 62141 ns/iter (± 197) 1.01
es/transform/baseline/common_typescript 168343 ns/iter (± 305) 142944 ns/iter (± 165) 1.18
es/target/es3 169933 ns/iter (± 476) 169271 ns/iter (± 416) 1.00
es/target/es2015 634450 ns/iter (± 1648) 632907 ns/iter (± 1455) 1.00
es/target/es2016 65230 ns/iter (± 164) 65235 ns/iter (± 100) 1.00
es/target/es2017 61995 ns/iter (± 108) 61693 ns/iter (± 139) 1.00
es/target/es2018 81649 ns/iter (± 206) 81578 ns/iter (± 164) 1.00
es/target/es2020 132850 ns/iter (± 240) 132271 ns/iter (± 435) 1.00
babelify-only 697654 ns/iter (± 1404) 671107 ns/iter (± 1558) 1.04
parse_and_babelify_angular 44909941 ns/iter (± 413716) 45717147 ns/iter (± 894610) 0.98
parse_and_babelify_backbone 5626702 ns/iter (± 61538) 5450147 ns/iter (± 52413) 1.03
parse_and_babelify_jquery 34532350 ns/iter (± 441762) 33290365 ns/iter (± 284656) 1.04
parse_and_babelify_jquery_mobile 58782710 ns/iter (± 710415) 57085374 ns/iter (± 525509) 1.03
parse_and_babelify_mootools 36159617 ns/iter (± 701329) 34689749 ns/iter (± 223867) 1.04
parse_and_babelify_underscore 4434965 ns/iter (± 46795) 4368149 ns/iter (± 22565) 1.02
parse_and_babelify_yui 34931707 ns/iter (± 1759631) 34397162 ns/iter (± 983371) 1.02
html/minify/document/css_spec 44078526 ns/iter (± 427128) 42316429 ns/iter (± 153518) 1.04
html/minify/document/github 17759805 ns/iter (± 63061) 17503163 ns/iter (± 56464) 1.01
html/minify/document/stackoverflow 15682799 ns/iter (± 81643) 15608511 ns/iter (± 50109) 1.00
html/minify/document_fragment/css_spec 41793846 ns/iter (± 368174) 40783326 ns/iter (± 133475) 1.02
html/minify/document_fragment/github 16901803 ns/iter (± 112406) 16794670 ns/iter (± 35438) 1.01
html/minify/document_fragment/stackoverflow 15232383 ns/iter (± 49541) 15219623 ns/iter (± 54089) 1.00
html/document/visitor/compare/clone 399642 ns/iter (± 12327) 342927 ns/iter (± 2157) 1.17
html/document/visitor/compare/visit_mut_span 427642 ns/iter (± 3408) 363714 ns/iter (± 1807) 1.18
html/document/visitor/compare/visit_mut_span_panic 450171 ns/iter (± 4207) 374205 ns/iter (± 2336) 1.20
html/document/visitor/compare/fold_span 471854 ns/iter (± 5623) 403141 ns/iter (± 2523) 1.17
html/document/visitor/compare/fold_span_panic 528157 ns/iter (± 3418) 458588 ns/iter (± 2549) 1.15
html/document_fragment/visitor/compare/clone 403689 ns/iter (± 4230) 334030 ns/iter (± 1848) 1.21
html/document_fragment/visitor/compare/visit_mut_span 424953 ns/iter (± 5361) 363046 ns/iter (± 3489) 1.17
html/document_fragment/visitor/compare/visit_mut_span_panic 436025 ns/iter (± 6158) 372158 ns/iter (± 1811) 1.17
html/document_fragment/visitor/compare/fold_span 476667 ns/iter (± 4212) 402757 ns/iter (± 2100) 1.18
html/document_fragment/visitor/compare/fold_span_panic 528661 ns/iter (± 5516) 462885 ns/iter (± 2117) 1.14
html/lexer/css_2021_spec 15538436 ns/iter (± 27351) 15551820 ns/iter (± 67920) 1.00
html/lexer/github_com_17_05_2022 6018239 ns/iter (± 7195) 6014614 ns/iter (± 5386) 1.00
html/lexer/stackoverflow_com_17_05_2022 5616374 ns/iter (± 3033) 5627358 ns/iter (± 7907) 1.00
html/parser/parser_document/css_2021_spec 26260463 ns/iter (± 213018) 25829958 ns/iter (± 137744) 1.02
html/parser/parser_document/github_com_17_05_2022 8804318 ns/iter (± 14483) 8793884 ns/iter (± 23491) 1.00
html/parser/parser_document/stackoverflow_com_17_05_2022 7721171 ns/iter (± 13858) 7713298 ns/iter (± 15061) 1.00
html/parser/parser_document_fragment/css_2021_spec 26613787 ns/iter (± 151724) 25804260 ns/iter (± 473366) 1.03
html/parser/parser_document_fragment/github_com_17_05_2022 8849328 ns/iter (± 14344) 8793308 ns/iter (± 19000) 1.01
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7747230 ns/iter (± 11259) 7737262 ns/iter (± 60702) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.