fix(es/helpers): Fix toArray (#6318)

**Related issue (if exists):** - Closes #6302.
swc-project · Nov 2, 2022 · e34c25e · e34c25e · github-actions · Nov 2, 2022
1 parent e11368e
commit e34c25e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 2 deletions.
diff --git a/.../swc/tests/exec/issues-6xxx/.6303/exec.js → ...s/swc/tests/exec/issues-6xxx/6303/exec.js b/.../swc/tests/exec/issues-6xxx/.6303/exec.js → ...s/swc/tests/exec/issues-6xxx/6303/exec.js
diff --git a/.../swc/tests/exec/issues-6xxx/.6304/exec.js → ...s/swc/tests/exec/issues-6xxx/6304/exec.js b/.../swc/tests/exec/issues-6xxx/.6304/exec.js → ...s/swc/tests/exec/issues-6xxx/6304/exec.js
diff --git a/crates/swc_ecma_transforms_base/src/helpers/_to_array.js b/crates/swc_ecma_transforms_base/src/helpers/_to_array.js
@@ -1,3 +1,3 @@
 function _toArray(arr) {
-  return _arrayWithHoles(arr) || _iterableToArray(arr) || _unsupportedIterableToArray(arr, i) || _nonIterableRest();
+  return _arrayWithHoles(arr) || _iterableToArray(arr) || _unsupportedIterableToArray(arr) || _nonIterableRest();
 }
diff --git a/packages/swc-helpers/src/_to_array.mjs b/packages/swc-helpers/src/_to_array.mjs
@@ -4,5 +4,5 @@ import nonIterableRest from './_non_iterable_rest.mjs';
 import unsupportedIterableToArray from './_unsupported_iterable_to_array.mjs';
 
 export default function _toArray(arr) {
-  return arrayWithHoles(arr) || iterableToArray(arr) || unsupportedIterableToArray(arr, i) || nonIterableRest();
+  return arrayWithHoles(arr) || iterableToArray(arr) || unsupportedIterableToArray(arr) || nonIterableRest();
 }
Benchmark suite	Current: `e34c25e`	Previous: `3bea6f7`	Ratio
`es/full/bugs-1`	`366521` ns/iter (`± 32501`)	`399743` ns/iter (`± 61356`)	`0.92`
`es/full/minify/libraries/antd`	`1954466534` ns/iter (`± 43523773`)	`1955675265` ns/iter (`± 60450808`)	`1.00`
`es/full/minify/libraries/d3`	`455549624` ns/iter (`± 38743280`)	`458567593` ns/iter (`± 32049872`)	`0.99`
`es/full/minify/libraries/echarts`	`1713781129` ns/iter (`± 95023533`)	`1636140742` ns/iter (`± 58984035`)	`1.05`
`es/full/minify/libraries/jquery`	`106065578` ns/iter (`± 6166821`)	`103149575` ns/iter (`± 6021113`)	`1.03`
`es/full/minify/libraries/lodash`	`143199691` ns/iter (`± 24811843`)	`130941517` ns/iter (`± 19520720`)	`1.09`
`es/full/minify/libraries/moment`	`64300761` ns/iter (`± 4490976`)	`59649083` ns/iter (`± 1706865`)	`1.08`
`es/full/minify/libraries/react`	`21787184` ns/iter (`± 969348`)	`20034497` ns/iter (`± 716720`)	`1.09`
`es/full/minify/libraries/terser`	`332798757` ns/iter (`± 34261794`)	`343546179` ns/iter (`± 19517895`)	`0.97`
`es/full/minify/libraries/three`	`592007046` ns/iter (`± 144895518`)	`673304939` ns/iter (`± 161118457`)	`0.88`
`es/full/minify/libraries/typescript`	`3923219982` ns/iter (`± 278840018`)	`4058696990` ns/iter (`± 432689285`)	`0.97`
`es/full/minify/libraries/victory`	`958819906` ns/iter (`± 102452178`)	`1035119104` ns/iter (`± 81957917`)	`0.93`
`es/full/minify/libraries/vue`	`198729804` ns/iter (`± 15533892`)	`214614783` ns/iter (`± 34639391`)	`0.93`
`es/full/codegen/es3`	`37213` ns/iter (`± 5097`)	`36070` ns/iter (`± 5112`)	`1.03`
`es/full/codegen/es5`	`47987` ns/iter (`± 11497`)	`35433` ns/iter (`± 7292`)	`1.35`
`es/full/codegen/es2015`	`38453` ns/iter (`± 6049`)	`35853` ns/iter (`± 15107`)	`1.07`
`es/full/codegen/es2016`	`35859` ns/iter (`± 5632`)	`35049` ns/iter (`± 9279`)	`1.02`
`es/full/codegen/es2017`	`39893` ns/iter (`± 6391`)	`34279` ns/iter (`± 1634`)	`1.16`
`es/full/codegen/es2018`	`36664` ns/iter (`± 5596`)	`36767` ns/iter (`± 9383`)	`1.00`
`es/full/codegen/es2019`	`42159` ns/iter (`± 7404`)	`36438` ns/iter (`± 4062`)	`1.16`
`es/full/codegen/es2020`	`38688` ns/iter (`± 5437`)	`35327` ns/iter (`± 4053`)	`1.10`
`es/full/all/es3`	`218309029` ns/iter (`± 25205889`)	`234550773` ns/iter (`± 52015717`)	`0.93`
`es/full/all/es5`	`222890509` ns/iter (`± 25952827`)	`225804758` ns/iter (`± 60999842`)	`0.99`
`es/full/all/es2015`	`181236059` ns/iter (`± 20910298`)	`179881616` ns/iter (`± 38238012`)	`1.01`
`es/full/all/es2016`	`176584553` ns/iter (`± 19102039`)	`149473819` ns/iter (`± 32927089`)	`1.18`
`es/full/all/es2017`	`182724886` ns/iter (`± 33442858`)	`150960163` ns/iter (`± 27867906`)	`1.21`
`es/full/all/es2018`	`186314996` ns/iter (`± 28588169`)	`153103170` ns/iter (`± 37764710`)	`1.22`
`es/full/all/es2019`	`189905465` ns/iter (`± 19854746`)	`165812040` ns/iter (`± 37663647`)	`1.15`
`es/full/all/es2020`	`177082083` ns/iter (`± 32242714`)	`146518125` ns/iter (`± 24347865`)	`1.21`
`es/full/parser`	`912711` ns/iter (`± 117531`)	`772047` ns/iter (`± 225819`)	`1.18`
`es/full/base/fixer`	`32579` ns/iter (`± 6175`)	`26776` ns/iter (`± 1522`)	`1.22`
`es/full/base/resolver_and_hygiene`	`102282` ns/iter (`± 20043`)	`93320` ns/iter (`± 6347`)	`1.10`
`serialization of ast node`	`243` ns/iter (`± 52`)	`218` ns/iter (`± 10`)	`1.11`
`serialization of serde`	`239` ns/iter (`± 48`)	`219` ns/iter (`± 9`)	`1.09`