Skip to content

Commit

Permalink
build(bindings): Crash in GraalVM (#6689)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Brooooooklyn
Brooooooklyn committed Dec 20, 2022
1 parent 913230d commit e7849db
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 17 deletions.
28 changes: 19 additions & 9 deletions Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions bindings/Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Expand Up @@ -94,7 +94,7 @@
"@babel/preset-react": "^7.13.13",
"@babel/preset-typescript": "^7.13.0",
"@babel/types": "^7.14.0",
"@napi-rs/cli": "^2.10.0",
"@napi-rs/cli": "^2.13.3",
"@swc/core": "=1.2.220",
"@swc/helpers": "^0.4.2",
"@swc/plugin-jest": "1.5.25",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Expand Up @@ -2124,12 +2124,12 @@ __metadata:
languageName: node
linkType: hard

"@napi-rs/cli@npm:^2.10.0":
version: 2.12.0
resolution: "@napi-rs/cli@npm:2.12.0"
"@napi-rs/cli@npm:^2.13.3":
version: 2.13.3
resolution: "@napi-rs/cli@npm:2.13.3"
bin:
napi: scripts/index.js
checksum: 88e4cb33022ad9f2185a3e539d2b692f0c5edaeb55d8ecf2c92e512d1a68770f97d0d56ff7aa24595e83c783cbd8509309968052671b79bbed780340b9201c8f
checksum: b16c3b307927b68adfe378bd76153b75c4a1a9d4101d7c49e0b1b9d425ce0f63a6d18acb9548d210dd90a4244333666f839d3f27070d3a07d63fa8ae1bfe2f35
languageName: node
linkType: hard

Expand Down Expand Up @@ -2450,7 +2450,7 @@ __metadata:
"@babel/preset-react": ^7.13.13
"@babel/preset-typescript": ^7.13.0
"@babel/types": ^7.14.0
"@napi-rs/cli": ^2.10.0
"@napi-rs/cli": ^2.13.3
"@swc/core": =1.2.220
"@swc/core-darwin-arm64": 1.2.146
"@swc/core-darwin-x64": 1.2.146
Expand Down

1 comment on commit e7849db

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e7849db Previous: d27a270 Ratio
es/full/bugs-1 302705 ns/iter (± 8760) 307769 ns/iter (± 15058) 0.98
es/full/minify/libraries/antd 1649727840 ns/iter (± 31294844) 1817146272 ns/iter (± 56060311) 0.91
es/full/minify/libraries/d3 315661244 ns/iter (± 8343244) 349493958 ns/iter (± 7566895) 0.90
es/full/minify/libraries/echarts 1288049445 ns/iter (± 12539531) 1377944728 ns/iter (± 12906459) 0.93
es/full/minify/libraries/jquery 93000778 ns/iter (± 1348437) 94684082 ns/iter (± 1414142) 0.98
es/full/minify/libraries/lodash 108196627 ns/iter (± 630043) 109306831 ns/iter (± 2701625) 0.99
es/full/minify/libraries/moment 53830188 ns/iter (± 1131638) 57659859 ns/iter (± 1911041) 0.93
es/full/minify/libraries/react 19438033 ns/iter (± 172912) 20433851 ns/iter (± 500587) 0.95
es/full/minify/libraries/terser 260034986 ns/iter (± 4676892) 276988050 ns/iter (± 5444674) 0.94
es/full/minify/libraries/three 473624942 ns/iter (± 7742045) 489544276 ns/iter (± 9213942) 0.97
es/full/minify/libraries/typescript 3089609309 ns/iter (± 41817715) 3462773588 ns/iter (± 61445174) 0.89
es/full/minify/libraries/victory 711411167 ns/iter (± 11763421) 789447604 ns/iter (± 14515464) 0.90
es/full/minify/libraries/vue 137139799 ns/iter (± 1343886) 137900726 ns/iter (± 1968757) 0.99
es/full/codegen/es3 27244 ns/iter (± 47) 27661 ns/iter (± 238) 0.98
es/full/codegen/es5 27295 ns/iter (± 46) 27644 ns/iter (± 43) 0.99
es/full/codegen/es2015 27331 ns/iter (± 58) 27601 ns/iter (± 34) 0.99
es/full/codegen/es2016 27295 ns/iter (± 40) 27623 ns/iter (± 29) 0.99
es/full/codegen/es2017 27279 ns/iter (± 51) 27603 ns/iter (± 47) 0.99
es/full/codegen/es2018 27302 ns/iter (± 86) 27574 ns/iter (± 58) 0.99
es/full/codegen/es2019 27322 ns/iter (± 92) 27591 ns/iter (± 61) 0.99
es/full/codegen/es2020 27321 ns/iter (± 60) 27582 ns/iter (± 51) 0.99
es/full/all/es3 168614653 ns/iter (± 2760164) 173374365 ns/iter (± 3430186) 0.97
es/full/all/es5 161132814 ns/iter (± 2410018) 162454056 ns/iter (± 2048737) 0.99
es/full/all/es2015 119421947 ns/iter (± 1313776) 123826929 ns/iter (± 2313155) 0.96
es/full/all/es2016 117909838 ns/iter (± 608492) 123093191 ns/iter (± 2506622) 0.96
es/full/all/es2017 117710372 ns/iter (± 678411) 122521831 ns/iter (± 3557186) 0.96
es/full/all/es2018 115549493 ns/iter (± 564919) 118830521 ns/iter (± 2164637) 0.97
es/full/all/es2019 115728354 ns/iter (± 610919) 117990682 ns/iter (± 1629883) 0.98
es/full/all/es2020 111030919 ns/iter (± 772516) 112775479 ns/iter (± 2547596) 0.98
es/full/parser 508439 ns/iter (± 5295) 498468 ns/iter (± 9566) 1.02
es/full/base/fixer 21951 ns/iter (± 25) 22068 ns/iter (± 30) 0.99
es/full/base/resolver_and_hygiene 78179 ns/iter (± 117) 77089 ns/iter (± 58) 1.01
serialization of ast node 118 ns/iter (± 0) 118 ns/iter (± 0) 1
serialization of serde 124 ns/iter (± 0) 122 ns/iter (± 0) 1.02
css/minify/libraries/bootstrap 27155662 ns/iter (± 138466) 27713352 ns/iter (± 95665) 0.98
css/visitor/compare/clone 2063905 ns/iter (± 13724) 2089116 ns/iter (± 11997) 0.99
css/visitor/compare/visit_mut_span 2275060 ns/iter (± 11497) 2272926 ns/iter (± 7767) 1.00
css/visitor/compare/visit_mut_span_panic 2341778 ns/iter (± 14607) 2319733 ns/iter (± 11521) 1.01
css/visitor/compare/fold_span 2975880 ns/iter (± 13722) 2993230 ns/iter (± 26646) 0.99
css/visitor/compare/fold_span_panic 3109517 ns/iter (± 26412) 3171581 ns/iter (± 21972) 0.98
css/lexer/bootstrap_5_1_3 5178401 ns/iter (± 1376) 5221137 ns/iter (± 2624) 0.99
css/lexer/foundation_6_7_4 4354476 ns/iter (± 1762) 4397574 ns/iter (± 2566) 0.99
css/lexer/tailwind_3_1_1 825557 ns/iter (± 408) 832427 ns/iter (± 506) 0.99
css/parser/bootstrap_5_1_3 20887952 ns/iter (± 169130) 21381031 ns/iter (± 141161) 0.98
css/parser/foundation_6_7_4 16611366 ns/iter (± 40218) 16949368 ns/iter (± 206932) 0.98
css/parser/tailwind_3_1_1 3199590 ns/iter (± 5148) 3219899 ns/iter (± 2413) 0.99
es/codegen/colors 332300 ns/iter (± 186984) 331235 ns/iter (± 184091) 1.00
es/codegen/large 1219818 ns/iter (± 641938) 1176605 ns/iter (± 593304) 1.04
es/codegen/with-parser/colors 46309 ns/iter (± 410) 45803 ns/iter (± 348) 1.01
es/codegen/with-parser/large 516568 ns/iter (± 1646) 517548 ns/iter (± 1361) 1.00
es/minify/libraries/antd 1438763219 ns/iter (± 14950230) 1651457092 ns/iter (± 24802137) 0.87
es/minify/libraries/d3 263252369 ns/iter (± 4604241) 293602111 ns/iter (± 8928207) 0.90
es/minify/libraries/echarts 1102816968 ns/iter (± 11177039) 1195472523 ns/iter (± 7951005) 0.92
es/minify/libraries/jquery 78852758 ns/iter (± 637708) 82655329 ns/iter (± 2141304) 0.95
es/minify/libraries/lodash 96232476 ns/iter (± 782753) 104684925 ns/iter (± 1983855) 0.92
es/minify/libraries/moment 46294829 ns/iter (± 277602) 49237125 ns/iter (± 882547) 0.94
es/minify/libraries/react 17119205 ns/iter (± 197837) 17729014 ns/iter (± 486875) 0.97
es/minify/libraries/terser 218245765 ns/iter (± 2239194) 231744595 ns/iter (± 4149774) 0.94
es/minify/libraries/three 384031744 ns/iter (± 4881264) 425042137 ns/iter (± 9619919) 0.90
es/minify/libraries/typescript 2611460016 ns/iter (± 7707359) 2924834557 ns/iter (± 39064934) 0.89
es/minify/libraries/victory 585122115 ns/iter (± 11592603) 658917245 ns/iter (± 10150359) 0.89
es/minify/libraries/vue 117075190 ns/iter (± 941999) 125442968 ns/iter (± 3934773) 0.93
es/visitor/compare/clone 2437323 ns/iter (± 4277) 2467132 ns/iter (± 20067) 0.99
es/visitor/compare/visit_mut_span 2832452 ns/iter (± 10011) 2920493 ns/iter (± 65764) 0.97
es/visitor/compare/visit_mut_span_panic 2863740 ns/iter (± 9930) 2873810 ns/iter (± 15258) 1.00
es/visitor/compare/fold_span 3985282 ns/iter (± 11452) 3955940 ns/iter (± 20015) 1.01
es/visitor/compare/fold_span_panic 4117684 ns/iter (± 101523) 4177550 ns/iter (± 21804) 0.99
es/lexer/colors 17281 ns/iter (± 15) 17478 ns/iter (± 134) 0.99
es/lexer/angular 8202609 ns/iter (± 4282) 8241350 ns/iter (± 3641) 1.00
es/lexer/backbone 1067023 ns/iter (± 541) 1077846 ns/iter (± 547) 0.99
es/lexer/jquery 5933880 ns/iter (± 10441) 5966840 ns/iter (± 4572) 0.99
es/lexer/jquery mobile 9125241 ns/iter (± 8724) 9186762 ns/iter (± 1778) 0.99
es/lexer/mootools 4644861 ns/iter (± 5423) 4686572 ns/iter (± 864) 0.99
es/lexer/underscore 892215 ns/iter (± 244) 899768 ns/iter (± 232) 0.99
es/lexer/three 27717684 ns/iter (± 29914) 28099617 ns/iter (± 47924) 0.99
es/lexer/yui 5030544 ns/iter (± 6095) 5062876 ns/iter (± 2753) 0.99
es/parser/colors 30870 ns/iter (± 163) 31317 ns/iter (± 167) 0.99
es/parser/angular 15757222 ns/iter (± 102091) 16560001 ns/iter (± 394962) 0.95
es/parser/backbone 2321964 ns/iter (± 11316) 2332709 ns/iter (± 19085) 1.00
es/parser/jquery 12856616 ns/iter (± 148223) 13569870 ns/iter (± 247688) 0.95
es/parser/jquery mobile 20249257 ns/iter (± 147747) 22337070 ns/iter (± 447854) 0.91
es/parser/mootools 9630661 ns/iter (± 33086) 9664579 ns/iter (± 73500) 1.00
es/parser/underscore 1956932 ns/iter (± 10061) 1967099 ns/iter (± 10527) 0.99
es/parser/three 59383369 ns/iter (± 367406) 61398183 ns/iter (± 478184) 0.97
es/parser/yui 9633027 ns/iter (± 82288) 10109030 ns/iter (± 135255) 0.95
es/preset-env/usage/builtin_type 144565 ns/iter (± 33525) 141379 ns/iter (± 32466) 1.02
es/preset-env/usage/property 21546 ns/iter (± 63) 21868 ns/iter (± 80) 0.99
es/resolver/typescript 111616741 ns/iter (± 2179322) 126601397 ns/iter (± 4662549) 0.88
es/fixer/typescript 85488810 ns/iter (± 1004023) 99773541 ns/iter (± 1004426) 0.86
es/hygiene/typescript 170393305 ns/iter (± 2234552) 204524063 ns/iter (± 3406821) 0.83
es/resolver_with_hygiene/typescript 296793516 ns/iter (± 1430703) 344443869 ns/iter (± 4873613) 0.86
es/visitor/base-perf/module_clone 75372 ns/iter (± 1219) 75788 ns/iter (± 1234) 0.99
es/visitor/base-perf/fold_empty 85408 ns/iter (± 929) 85842 ns/iter (± 1386) 0.99
es/visitor/base-perf/fold_noop_impl_all 84933 ns/iter (± 2061) 86723 ns/iter (± 1211) 0.98
es/visitor/base-perf/fold_noop_impl_vec 86000 ns/iter (± 1769) 86184 ns/iter (± 315) 1.00
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 59 ns/iter (± 0) 59 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 103 ns/iter (± 0) 104 ns/iter (± 0) 0.99
es/visitor/base-perf/boxing_unboxed 102 ns/iter (± 0) 101 ns/iter (± 0) 1.01
es/visitor/base-perf/visit_contains_this 3502 ns/iter (± 93) 3505 ns/iter (± 67) 1.00
es/base/parallel/resolver/typescript 5703572693 ns/iter (± 268569284) 6656597515 ns/iter (± 408155315) 0.86
es/base/parallel/hygiene/typescript 2022077382 ns/iter (± 36037951) 2264044986 ns/iter (± 29633964) 0.89
misc/visitors/time-complexity/time 5 102 ns/iter (± 0) 97 ns/iter (± 2) 1.05
misc/visitors/time-complexity/time 10 320 ns/iter (± 3) 307 ns/iter (± 3) 1.04
misc/visitors/time-complexity/time 15 647 ns/iter (± 0) 651 ns/iter (± 6) 0.99
misc/visitors/time-complexity/time 20 1232 ns/iter (± 4) 1221 ns/iter (± 29) 1.01
misc/visitors/time-complexity/time 40 6625 ns/iter (± 11) 6117 ns/iter (± 3) 1.08
misc/visitors/time-complexity/time 60 17133 ns/iter (± 6) 15568 ns/iter (± 41) 1.10
es/full-target/es2016 189362 ns/iter (± 953) 188707 ns/iter (± 283) 1.00
es/full-target/es2017 183617 ns/iter (± 288) 184564 ns/iter (± 583) 0.99
es/full-target/es2018 173523 ns/iter (± 398) 173702 ns/iter (± 654) 1.00
es2020_nullish_coalescing 66968 ns/iter (± 559) 66885 ns/iter (± 318) 1.00
es2020_optional_chaining 96944 ns/iter (± 247) 95740 ns/iter (± 414) 1.01
es2022_class_properties 94263 ns/iter (± 162) 93755 ns/iter (± 105) 1.01
es2018_object_rest_spread 71400 ns/iter (± 122) 71790 ns/iter (± 135) 0.99
es2019_optional_catch_binding 61486 ns/iter (± 114) 61376 ns/iter (± 118) 1.00
es2017_async_to_generator 61692 ns/iter (± 68) 62051 ns/iter (± 119) 0.99
es2016_exponentiation 65287 ns/iter (± 95) 65303 ns/iter (± 101) 1.00
es2015_arrow 70056 ns/iter (± 216) 69966 ns/iter (± 194) 1.00
es2015_block_scoped_fn 66186 ns/iter (± 109) 66055 ns/iter (± 101) 1.00
es2015_block_scoping 146649 ns/iter (± 12066) 138717 ns/iter (± 9469) 1.06
es2015_classes 116630 ns/iter (± 466) 117357 ns/iter (± 534) 0.99
es2015_computed_props 61044 ns/iter (± 63) 61121 ns/iter (± 87) 1.00
es2015_destructuring 115855 ns/iter (± 172) 115857 ns/iter (± 317) 1.00
es2015_duplicate_keys 63979 ns/iter (± 140) 63637 ns/iter (± 61) 1.01
es2015_parameters 79544 ns/iter (± 146) 79527 ns/iter (± 128) 1.00
es2015_fn_name 66667 ns/iter (± 469) 67063 ns/iter (± 675) 0.99
es2015_for_of 64573 ns/iter (± 128) 64384 ns/iter (± 73) 1.00
es2015_instanceof 63167 ns/iter (± 96) 63491 ns/iter (± 111) 0.99
es2015_shorthand_property 61249 ns/iter (± 97) 61178 ns/iter (± 138) 1.00
es2015_spread 61394 ns/iter (± 121) 61263 ns/iter (± 55) 1.00
es2015_sticky_regex 62301 ns/iter (± 98) 62112 ns/iter (± 131) 1.00
es2015_typeof_symbol 62346 ns/iter (± 168) 62563 ns/iter (± 75) 1.00
es/transform/baseline/base 51932 ns/iter (± 89) 51908 ns/iter (± 117) 1.00
es/transform/baseline/common_reserved_word 62583 ns/iter (± 79) 63020 ns/iter (± 159) 0.99
es/transform/baseline/common_typescript 141797 ns/iter (± 274) 142781 ns/iter (± 1221) 0.99
es/target/es3 169538 ns/iter (± 253) 167617 ns/iter (± 185) 1.01
es/target/es2015 628846 ns/iter (± 1182) 628094 ns/iter (± 2387) 1.00
es/target/es2016 65324 ns/iter (± 72) 65304 ns/iter (± 119) 1.00
es/target/es2017 61741 ns/iter (± 115) 62034 ns/iter (± 67) 1.00
es/target/es2018 81471 ns/iter (± 140) 81585 ns/iter (± 107) 1.00
es/target/es2020 134208 ns/iter (± 240) 132726 ns/iter (± 294) 1.01
babelify-only 672333 ns/iter (± 1212) 675656 ns/iter (± 1035) 1.00
parse_and_babelify_angular 43688921 ns/iter (± 778948) 49567855 ns/iter (± 912136) 0.88
parse_and_babelify_backbone 5377474 ns/iter (± 130830) 6031259 ns/iter (± 459701) 0.89
parse_and_babelify_jquery 31511611 ns/iter (± 672000) 36278543 ns/iter (± 927574) 0.87
parse_and_babelify_jquery_mobile 52929718 ns/iter (± 512155) 61489421 ns/iter (± 1580173) 0.86
parse_and_babelify_mootools 32927645 ns/iter (± 735913) 37115155 ns/iter (± 549345) 0.89
parse_and_babelify_underscore 4321057 ns/iter (± 18283) 4542027 ns/iter (± 98229) 0.95
parse_and_babelify_yui 31657658 ns/iter (± 496008) 36882297 ns/iter (± 1275638) 0.86
html/minify/document/css_spec 41830444 ns/iter (± 273166) 44511610 ns/iter (± 462519) 0.94
html/minify/document/github 17269994 ns/iter (± 18056) 17835466 ns/iter (± 83532) 0.97
html/minify/document/stackoverflow 15437916 ns/iter (± 22578) 15811563 ns/iter (± 86094) 0.98
html/minify/document_fragment/css_spec 39842225 ns/iter (± 200073) 42500842 ns/iter (± 715261) 0.94
html/minify/document_fragment/github 16592510 ns/iter (± 27980) 17224748 ns/iter (± 108681) 0.96
html/minify/document_fragment/stackoverflow 15032440 ns/iter (± 37564) 15599158 ns/iter (± 62196) 0.96
html/document/visitor/compare/clone 341038 ns/iter (± 2309) 341282 ns/iter (± 1920) 1.00
html/document/visitor/compare/visit_mut_span 367379 ns/iter (± 2171) 363882 ns/iter (± 2228) 1.01
html/document/visitor/compare/visit_mut_span_panic 375924 ns/iter (± 2146) 373898 ns/iter (± 1255) 1.01
html/document/visitor/compare/fold_span 406099 ns/iter (± 2729) 404409 ns/iter (± 2169) 1.00
html/document/visitor/compare/fold_span_panic 465090 ns/iter (± 2576) 465096 ns/iter (± 2180) 1.00
html/document_fragment/visitor/compare/clone 337903 ns/iter (± 2256) 340176 ns/iter (± 1432) 0.99
html/document_fragment/visitor/compare/visit_mut_span 373541 ns/iter (± 2396) 370435 ns/iter (± 2434) 1.01
html/document_fragment/visitor/compare/visit_mut_span_panic 372212 ns/iter (± 1241) 372474 ns/iter (± 2790) 1.00
html/document_fragment/visitor/compare/fold_span 410380 ns/iter (± 2001) 403672 ns/iter (± 1485) 1.02
html/document_fragment/visitor/compare/fold_span_panic 459483 ns/iter (± 2021) 457419 ns/iter (± 2463) 1.00
html/lexer/css_2021_spec 15617746 ns/iter (± 5396) 15588471 ns/iter (± 41970) 1.00
html/lexer/github_com_17_05_2022 6060831 ns/iter (± 5492) 6048443 ns/iter (± 9638) 1.00
html/lexer/stackoverflow_com_17_05_2022 5672434 ns/iter (± 6806) 5641472 ns/iter (± 2584) 1.01
html/parser/parser_document/css_2021_spec 25863365 ns/iter (± 319589) 26889884 ns/iter (± 345621) 0.96
html/parser/parser_document/github_com_17_05_2022 8807354 ns/iter (± 14690) 8897102 ns/iter (± 23482) 0.99
html/parser/parser_document/stackoverflow_com_17_05_2022 7783209 ns/iter (± 7236) 7854833 ns/iter (± 22009) 0.99
html/parser/parser_document_fragment/css_2021_spec 26480308 ns/iter (± 227229) 28227206 ns/iter (± 243978) 0.94
html/parser/parser_document_fragment/github_com_17_05_2022 8837150 ns/iter (± 6236) 8863776 ns/iter (± 19001) 1.00
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7806226 ns/iter (± 6271) 7830687 ns/iter (± 11082) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.