Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css/minifier): don't touch @supports #6199

Merged
merged 2 commits into from Oct 19, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Oct 18, 2022

Description:

Don't tocuh @supports, because it can be used for check a support of calc, so

// Will not work in old browser
@supports (width: calc(100px + 100px)) {
    div {
        background: red;
    }
}

will be

// Will work in odl browser
@supports (width: 200px) {
   div {
        background: red;
    }
}

But some styles can be used for old browser (and verca vise), this is definitely not the expected behavior

BREAKING CHANGE:

No

Related issue (if exists):

No

@kdy1 kdy1 self-assigned this Oct 18, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 18, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_minifier

@kdy1 kdy1 enabled auto-merge (squash) October 19, 2022 02:15
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit ac7cfa1 into swc-project:main Oct 19, 2022
@alexander-akait alexander-akait deleted the fix-dont-touch-supports branch October 19, 2022 14:13
@kdy1 kdy1 modified the milestones: Planned, v1.3.10 Oct 21, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants