Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mut from build_source_map_from #6276

Merged
merged 2 commits into from Oct 28, 2022
Merged

Remove mut from build_source_map_from #6276

merged 2 commits into from Oct 28, 2022

Conversation

jridgewell
Copy link
Contributor

Description:

The mappings vector was required to be mutable, but the value is never mutated.

BREAKING CHANGE:

I don't believe so. Any code that passed in a mutable reference will still work without any changes.

Related issue (if exists):

@jridgewell
Remove mut from build_source_map_from
d17d503 
The `mappings` vector was required to be mutable, but the value is never mutated.
@CLAassistant
Copy link

CLAassistant commented Oct 27, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@kdy1 kdy1 self-assigned this Oct 28, 2022
@kdy1 kdy1 added this to the Planned milestone Oct 28, 2022
@kdy1
Copy link
Member

kdy1 commented Oct 28, 2022

Can you sign the CLA? Honestly, I don't care how people use swc, but I configured it to avoid processes like swc-project/plugins#99 or swc-project/plugins#98

@kdy1
Copy link
Member

kdy1 commented Oct 28, 2022

Oh it was bug

kdy1
kdy1 previously approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common

@kdy1 kdy1 enabled auto-merge (squash) October 28, 2022 01:04
@kdy1 kdy1 disabled auto-merge October 28, 2022 01:04
@kdy1
Copy link
Member

kdy1 commented Oct 28, 2022

clippy failed. Seems like it want &[Foo]

@jridgewell
Copy link
Contributor Author

Updated.

@kdy1 kdy1 merged commit 47d7fca into swc-project:main Oct 28, 2022
@jridgewell jridgewell deleted the immutable-build_source_map_with_config branch October 28, 2022 01:47
jridgewell added a commit to vercel/turbo that referenced this pull request Oct 29, 2022
@jridgewell
Bump SWC
cedb1e6 
This also removes the source map clone, which is no longer necessary after swc-project/swc#6276.
@jridgewell jridgewell mentioned this pull request Oct 29, 2022
Closed
@kdy1 kdy1 modified the milestones: Planned, v1.3.12, v1.3.13 Nov 2, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jridgewell @CLAassistant @kdy1