refactor(bindings/wasm): deprecate jsvalue::*_serde #6436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
force-pushed
the
refactor-break-serde
branch
from
b463de9
to
4fa1acb
Compare
kwonoj
force-pushed
the
refactor-break-serde
branch
from
4fa1acb
to
e301cf5
Compare
Merged
kdy1
added a commit
that referenced
this pull request
Nov 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor wasm binding to not to use
JsValue::*_serde. It is effectively deprecated (rustwasm/wasm-bindgen#3031) , and also one of the reason to create circular dependencies around indexmap.BREAKING CHANGE:
Related issue (if exists):