Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Publish v1.3.17 #6442

Merged
merged 6 commits into from Nov 15, 2022
Merged

chore: Publish v1.3.17 #6442

merged 6 commits into from Nov 15, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 15, 2022

No description provided.

@kdy1 kdy1 added this to the Planned milestone Nov 15, 2022
@kdy1 kdy1 marked this pull request as ready for review November 15, 2022 03:47
@kdy1 kdy1 enabled auto-merge (squash) November 15, 2022 03:47
@kdy1 kdy1 changed the title chore: Publish v1.13.17 chore: Publish v1.3.17 Nov 15, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 15, 2022
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 15, 2022
@kdy1
Copy link
Member Author

kdy1 commented Nov 15, 2022

cc @kwonoj I reverted 1dd8b3d as it broke wasm

@kwonoj
Copy link
Member

kwonoj commented Nov 15, 2022

@kdy1 can I see Ci logs to fix it forward?

@kdy1
Copy link
Member Author

kdy1 commented Nov 15, 2022

@kdy1 kdy1 modified the milestones: Planned, v1.3.17 Nov 15, 2022
@kdy1
Copy link
Member Author

kdy1 commented Nov 15, 2022

Oh revert was not enough

kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 15, 2022
@kwonoj
Copy link
Member

kwonoj commented Nov 15, 2022

Let bindings use published version of swc_core serves well, but we definitely need some way to test latest swc_core directly before publishing bindings :/ I'll file an issue and think about some way.

@kdy1
Copy link
Member Author

kdy1 commented Nov 15, 2022

It does not work. With the latest version wasm CI fails

@kdy1
Copy link
Member Author

kdy1 commented Nov 15, 2022

See https://github.com/swc-project/swc/actions/runs/3467460473/jobs/5792360658
It's using binding_macros@ v0.20.94

@kwonoj
Copy link
Member

kwonoj commented Nov 15, 2022

It does not work. With the latest version wasm CI fails

Do you mean previous version of swc_core, or one more bump of swc_core with revert? if it's reverted + swc_core has been bumped up and still same compilation error occurs?

@kdy1
Copy link
Member Author

kdy1 commented Nov 15, 2022

No, it's not reverted yet and the broken version (with #6436) is the latest version at the moment

kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 15, 2022
@kwonoj
Copy link
Member

kwonoj commented Nov 15, 2022

I see.

What I meant

Let bindings use published version of swc_core serves well,

was not for this specific case, it's for more general cases (aka when it works, it works well). As said above, seems we're hitting bumps bit more than we expected - I'll try to see if I can come up with some plan.

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 15, 2022
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 15, 2022
@kdy1 kdy1 merged commit 375fe85 into swc-project:main Nov 15, 2022
@kdy1 kdy1 deleted the publish branch November 15, 2022 05:48
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants