chore(es/minifier): expose globals_defs pass
#6633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
requested changes
Dec 13, 2022
|
Also, do you know https://rustdoc.swc.rs/swc_ecma_transforms_optimization/fn.inline_globals2.html ? |
Yeah. It's a little more complicated than we need. |
hyf0
force-pushed
the
hyf_20221213
branch
2 times, most recently
from
aa42bc6
to
f4ebd49
Compare
swc-bot
reviewed
Dec 13, 2022
kdy1
approved these changes
Dec 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I'm trying to do some global expression replacement and found I could reuse this part. Would it be ok to expose this function?
BREAKING CHANGE:
Related issue (if exists):