Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): parsing import.meta should not throw error using parse_file_as_expr #6783

Merged
merged 2 commits into from Jan 11, 2023
Merged

fix(es/parser): parsing import.meta should not throw error using parse_file_as_expr #6783

merged 2 commits into from Jan 11, 2023

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented Jan 10, 2023

Description:

BREAKING CHANGE:

Related issue (if exists):
Fix #6781.

@kdy1 kdy1 self-assigned this Jan 11, 2023
@kdy1 kdy1 added this to the Planned milestone Jan 11, 2023
kdy1
kdy1 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 enabled auto-merge (squash) January 11, 2023 02:58
@kdy1 kdy1 merged commit ff8face into swc-project:main Jan 11, 2023
@hyf0 hyf0 mentioned this pull request Jan 11, 2023
Merged
2 tasks
@kdy1 kdy1 modified the milestones: Planned, v1.3.26 Jan 11, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.26
Development

Successfully merging this pull request may close these issues.

using parse_file_as_expr to parse import.meta will throw SyntaxError::ImportMetaInScript
2 participants
@hyf0 @kdy1