chore: bump swc #1587

IWANABETHATGUY · 2023-01-10T05:00:27Z

Summary

Backgrounds

1. Better name mangling of SWC minifier. feat(es/minifier): Make name mangler understand block scoping swc-project/swc#6670
1. Fix a bug fix(es/parser): parsing import.meta should not throw error using parse_file_as_expr swc-project/swc#6783

Test Plan

Related issue (if exists)

How does Webpack handle this? (if exists)

Is this a workaround for the Webpack's implementation?

Check if Webpack has the same feature and but we're taking a workaround for it.

Yes. Issue for resolving the workaround:
No

Name	Type
@rspack/binding	Patch
@rspack/postcss-loader	Patch
@rspack/core	Patch
@rspack/cli	Patch
@rspack/dev-middleware	Patch
@rspack/dev-server	Patch
@rspack/plugin-html	Patch
@rspack/less-loader	Patch
@rspack/dev-client	Patch
@rspack/plugin-minify	Patch
@rspack/plugin-node-polyfill	Patch
@rspack/binding-darwin-arm64	Patch
@rspack/binding-darwin-x64	Patch
@rspack/binding-linux-x64-gnu	Patch
@rspack/binding-win32-x64-msvc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

IWANABETHATGUY · 2023-01-10T05:02:38Z

!bench

IWANABETHATGUY · 2023-01-10T05:11:41Z

crates/rspack_loader_sass/tests/fixtures/rspack_importer/expected/main.css

@@ -29,7 +29,7 @@ nav a {
  border-radius: 10px;
 }
 .foo:before {
-  content: "\e0c6";
+  content: "";


This diff is due to swc version upgrade

github-actions · 2023-01-10T05:21:08Z

Benchmark Results

group                                                 baseline                               pr
-----                                                 --------                               --
criterion_benchmark/css_heavy                         1.00     54.5±3.29ms        ? ?/sec    1.06     57.5±3.70ms        ? ?/sec
criterion_benchmark/lodash                            1.00     75.6±1.47ms        ? ?/sec    1.02     76.9±1.42ms        ? ?/sec
criterion_benchmark/ten_copy_of_threejs               1.00   800.8±12.20ms        ? ?/sec    1.00   803.9±13.78ms        ? ?/sec
high_cost_benchmark/ten_copy_of_threejs_production    1.00       5.3±0.02s        ? ?/sec    1.02       5.4±0.02s        ? ?/sec

IWANABETHATGUY · 2023-01-10T05:59:17Z

crates/rspack_plugin_javascript/tests/fixtures/builtins/define/expected/main.js

@@ -41,7 +41,7 @@ try {
    error_count += 1;


The diff is because of this pr swc-project/swc#6670

IWANABETHATGUY · 2023-01-10T06:28:07Z

...ugin_css/src/pxtorem/tests/cases/should_not_replace_values_with_an_uppercase_P_or_X.css.snap

@@ -12,9 +11,9 @@ expression: should_not_replace_values_with_an_uppercase_P_or_X.css

 # Actual
 .rule {
-  margin: 0.75rem calc(100% - 14PX);


This diff is controversial, and I filed an issue here #1590

Is only the problem blocking us to bump version of SWC?

I don't think this is an issue that blocking us to bump swc.

IWANABETHATGUY · 2023-01-10T06:28:29Z

!bench

github-actions · 2023-01-10T07:01:11Z

Benchmark Results

group                                                 baseline                               pr
-----                                                 --------                               --
criterion_benchmark/css_heavy                         1.00     54.2±3.48ms        ? ?/sec    1.09     59.3±3.64ms        ? ?/sec
criterion_benchmark/lodash                            1.00     72.0±1.27ms        ? ?/sec    1.04     74.6±1.34ms        ? ?/sec
criterion_benchmark/ten_copy_of_threejs               1.00    765.5±9.38ms        ? ?/sec    1.03    789.7±9.80ms        ? ?/sec
high_cost_benchmark/ten_copy_of_threejs_production    1.00       4.7±0.03s        ? ?/sec    1.06       4.9±0.02s        ? ?/sec

hyf0 · 2023-01-11T03:06:40Z

Could you bump swc_core to 0.55.2
There's a bug need to fixed with swc-project/swc#6783

hardfist · 2023-01-11T06:46:07Z

please add background about why we bump swc

hyf0 · 2023-01-11T06:48:44Z

please add background about why we bump swc

Done

IWANABETHATGUY changed the title ~~chore: 🤖 init~~ chore: bump swc Jan 10, 2023

IWANABETHATGUY commented Jan 10, 2023

View reviewed changes

IWANABETHATGUY force-pushed the chore/bump-swc branch from 48f7c1d to fd09e27 Compare January 10, 2023 06:15

IWANABETHATGUY changed the title ~~chore: bump swc~~ WIP: chore: bump swc Jan 10, 2023

IWANABETHATGUY commented Jan 10, 2023

View reviewed changes

IWANABETHATGUY force-pushed the chore/bump-swc branch from fd09e27 to 5e2620f Compare January 10, 2023 11:04

IWANABETHATGUY force-pushed the chore/bump-swc branch from 5e2620f to e86f956 Compare January 11, 2023 03:15

hyf0 approved these changes Jan 11, 2023

View reviewed changes

IWANABETHATGUY and others added 9 commits January 11, 2023 14:09

chore: 🤖 init

0d3bfea

chore: 🤖 changeset

8c6c045

chore: 🤖 update snapshot

8bb29ac

chore: 🤖 upgrade dep

a46d77c

chore: 🤖 fix

e978ec4

chore: 🤖 update snapshot

b735038

Bump SWC version

75ee0e5

Fix napi

b4cfc80

Fix test

847c4e6

hyf0 force-pushed the chore/bump-swc branch from 33953ee to 847c4e6 Compare January 11, 2023 06:09

underfin approved these changes Jan 11, 2023

View reviewed changes

hyf0 merged commit cd77363 into main Jan 11, 2023

hyf0 deleted the chore/bump-swc branch January 11, 2023 06:27

hyf0 mentioned this pull request Jan 12, 2023

How to deal recovered parsed error from SWC #1604

Closed

hyf0 changed the title ~~WIP: chore: bump swc~~ chore: bump swc Jan 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump swc #1587

chore: bump swc #1587

IWANABETHATGUY commented Jan 10, 2023 •

edited by hyf0

changeset-bot bot commented Jan 10, 2023 •

edited

IWANABETHATGUY commented Jan 10, 2023

IWANABETHATGUY Jan 10, 2023

github-actions bot commented Jan 10, 2023

IWANABETHATGUY Jan 10, 2023

IWANABETHATGUY Jan 10, 2023

hyf0 Jan 10, 2023 •

edited

IWANABETHATGUY Jan 10, 2023

IWANABETHATGUY commented Jan 10, 2023

github-actions bot commented Jan 10, 2023

hyf0 commented Jan 11, 2023 •

edited

hardfist commented Jan 11, 2023

hyf0 commented Jan 11, 2023

chore: bump swc #1587

chore: bump swc #1587

Conversation

IWANABETHATGUY commented Jan 10, 2023 • edited by hyf0

Summary

Test Plan

Related issue (if exists)

How does Webpack handle this? (if exists)

Further reading

changeset-bot bot commented Jan 10, 2023 • edited

🦋 Changeset detected

IWANABETHATGUY commented Jan 10, 2023

IWANABETHATGUY Jan 10, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 10, 2023

Benchmark Results

IWANABETHATGUY Jan 10, 2023

Choose a reason for hiding this comment

IWANABETHATGUY Jan 10, 2023

Choose a reason for hiding this comment

hyf0 Jan 10, 2023 • edited

Choose a reason for hiding this comment

IWANABETHATGUY Jan 10, 2023

Choose a reason for hiding this comment

IWANABETHATGUY commented Jan 10, 2023

github-actions bot commented Jan 10, 2023

Benchmark Results

hyf0 commented Jan 11, 2023 • edited

hardfist commented Jan 11, 2023

hyf0 commented Jan 11, 2023

IWANABETHATGUY commented Jan 10, 2023 •

edited by hyf0

changeset-bot bot commented Jan 10, 2023 •

edited

hyf0 Jan 10, 2023 •

edited

hyf0 commented Jan 11, 2023 •

edited