Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/codegen): Fix codegen of string literals with \x000 #6838

Merged
merged 15 commits into from
Jan 20, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 20, 2023

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jan 20, 2023
@kdy1 kdy1 self-assigned this Jan 20, 2023
@kdy1 kdy1 marked this pull request as ready for review January 20, 2023 06:35
@kdy1 kdy1 enabled auto-merge (squash) January 20, 2023 06:35
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 20, 2023
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 disabled auto-merge January 20, 2023 06:41
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 20, 2023
crates/swc_ecma_codegen/src/lib.rs Outdated Show resolved Hide resolved
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 20, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 20, 2023
jridgewell
jridgewell previously approved these changes Jan 20, 2023
@kdy1 kdy1 enabled auto-merge (squash) January 20, 2023 06:56
@kdy1 kdy1 dismissed stale reviews from jridgewell and kodiakhq via 402e5ec January 20, 2023 07:24
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 20, 2023
@kdy1 kdy1 merged commit df70261 into swc-project:main Jan 20, 2023
@kdy1 kdy1 deleted the issue-6836 branch January 20, 2023 08:09
@kdy1 kdy1 modified the milestones: Planned, v1.3.28 Jan 24, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"\x000" falsely gets turned into "\00"
2 participants