Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact(es/preset-env): use const fn instead of macro #6844

Merged
merged 1 commit into from
Jan 23, 2023
Merged

refact(es/preset-env): use const fn instead of macro #6844

merged 1 commit into from
Jan 23, 2023

Conversation

Austaras
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

kdy1
kdy1 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_preset_env

@kdy1 kdy1 added this to the Planned milestone Jan 23, 2023
@kdy1 kdy1 self-assigned this Jan 23, 2023
kdy1
kdy1 requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

@Austaras Austaras requested a review from kdy1 January 23, 2023 10:05
kdy1
kdy1 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 enabled auto-merge (squash) January 23, 2023 10:11
@kdy1 kdy1 merged commit 2fcab36 into swc-project:main Jan 23, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.28 Jan 24, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.28
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Austaras @kdy1