fix(swc/core): Stop doing require unnecessary packages (@swc/core-darwin-universal).
#6902
+0
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kwonoj
approved these changes
Feb 5, 2023
kdy1
approved these changes
Feb 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removed the part that requires a package that does not exist.
(Previously, this was enclosed in a try-catch and did not manifest itself as a clear error, but was problematic in the situation described in the issue below.)
BREAKING CHANGE:
If
process.platform === 'darwin' && (process.arch !== 'x64' && process.arch !== 'arm64'),then Error "Unsupported architecture on macOS: (process.arch)" will be thrown.
Previously, however, the Error "Failed to load native binding" would have been thrown because
@swc/core-darwin-arm64does not exist. In this point of view, Probably I can argue that this changes make error easy-to-understand.Related issue (if exists):
@swc/core-darwin-universalprobably does not exist. #6901