Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visitBindingIdentifier should go through type annotations #7000

Merged
merged 1 commit into from Mar 3, 2023

Conversation

cyjake
Copy link
Contributor

@cyjake cyjake commented Mar 2, 2023

Description:

Visitor#visitBindingIdentifier() currently doesn't go through type annotations, which makes customized visitor easy to overlook.

BREAKING CHANGE:

Changing the function type shouldn't break existing code because BindingIdentifier can be coerced to Identifier implicitly. Adding some specific typescript tests can better justify that, any suggestions about adding those?

Related issue (if exists):
n/a

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 enabled auto-merge (squash) March 3, 2023 02:03
@kdy1 kdy1 merged commit 30cff01 into swc-project:main Mar 3, 2023
@kdy1 kdy1 added this to the Planned milestone Mar 3, 2023
@cyjake cyjake deleted the fix-ts-visit-binding-identifier branch March 3, 2023 03:06
@kdy1 kdy1 modified the milestones: Planned, v1.3.38 Mar 6, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants