Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/preset-env): move findLast and findLastIndex to finished proposals #7012

Merged
merged 4 commits into from Mar 6, 2023

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented Mar 4, 2023

Description: Fix #7001

BREAKING CHANGE: No

Related issue (if exists): #3970

@zloirock
Copy link

zloirock commented Mar 4, 2023

It seems it's time to completely update it by https://github.com/babel/babel-polyfills/blob/main/packages/babel-plugin-polyfill-corejs3/src/built-in-definitions.ts

@nissy-dev
Copy link
Contributor Author

Thanks! I will create annother PR for other updates

@@ -4,7 +4,7 @@
"../../../../lib",
{
"useBuiltIns": "usage",
"corejs": "3.21",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add another test and revert this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted!

@kdy1 kdy1 added this to the Planned milestone Mar 6, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_preset_env

@kdy1 kdy1 enabled auto-merge (squash) March 6, 2023 01:10
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit b46a724 into swc-project:main Mar 6, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.38 Mar 6, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Does not add imports to findLast and findLastIndex core-js polyfills when { env: { mode: 'usage' }}
4 participants