Implement new `@swc/helpers` #7182

magic-akari · 2023-03-31T09:10:15Z

Description:

named export
unified import path

BREAKING CHANGE:

Breaking changes for @swc/helpers.
new major version 0.5.0 is required.

Related issue (if exists):

close [RFC] Next Step for @swc/helpers #7157

kdy1 · 2023-04-01T09:46:31Z

crates/swc/tests/fixture/deno/paths/issue-2724/output/src/index.ts

 (async function() {
-    const { displayA  } = await Promise.resolve().then(()=>/*#__PURE__*/ _interop_require_wildcard(require("../packages/a/src/index")));
+    const { displayA  } = await Promise.resolve().then(()=>/*#__PURE__*/ (0, _interop_require_wildcard._interop_require_wildcard)(require("../packages/a/src/index")));


I think this will regress the bundle size by margin.

Do you mean the indirect call?

We known that there is no this issue in our helpers.
Is it safe to call function directlly?

I meant that _interop_xxx cannot be optimized by the minifier.

I think it's better to invoke it directly

I meant that _interop_xxx cannot be optimized by the minifier.

I think it's better to invoke it directly

Done. fixed by keep using the pattern fn.apply(this, arguments) .

I still need to handle it in CJS/AMD/UMD

I meant that _interop_xxx cannot be optimized by the minifier.

I think it's better to invoke it directly

The first solution is to disable rewriting exported functions in esm so that we can safely use var foo = require("foo").foo.
But if other bundler handle our helpers, it does not know that our export is constant and may not apply such optimization.

The second solution is to add another constant named export with shorter name such as _, and then use it in transpiled file as follows:

var foo = require("foo"); foo._(bar);.

Which is better?

Compare:
magic-akari/swc@swc-helpers...magic-akari:swc:swc-helpers-short-named

Wow, the second one sounds cool. What a clever trick!

is there a simple way to get helpers SyntaxContext?
I am trying to skip the indrect call (0, foo)._ for helpers.

I got it by using

HELPERS.with(|helper| helper.mark());

kdy1 · 2023-04-02T03:15:11Z

crates/swc/tests/fixture/config/regenerator/import-path/1/output/index.js

@@ -1,4 +1,4 @@
-import _ts_generator from "@swc/helpers/src/_ts_generator.mjs";
+import { _ts_generator } from "@swc/helpers/_/_ts_generator";


I think this will regress the bundle size, too.

import { _ts_generator as e } from "@swc/helpers/_/_ts_generator"; e()

This is how it's optimized, but this looks problematic

The test cases will be updated.
It will be changed to the following:

import { _ as _ts_generator } from "@swc/helpers/_/_ts_generator";

and with optimized phase:

import { _ as e } from "@swc/helpers/_/_ts_generator"; e()

I see, thank you so much!

kdy1 · 2023-04-03T01:08:03Z

I don't know why, but GitHub shows a wrong diff. I'm not sure how should I review this 🤣

magic-akari · 2023-04-03T02:34:43Z

I don't know why, but GitHub shows a wrong diff. I'm not sure how should I review this 🤣

I wish the builtin GitHub plugin from VSCode will solve this issue.

kdy1 · 2023-04-03T10:33:25Z

I already tried it, but it didn't work

magic-akari · 2023-04-03T11:09:19Z

I already tried it, but it didn't work

Try to checkout locally?
Or should I rebase and squash some commits?

kdy1 · 2023-04-03T11:14:44Z

I checked it out, but git diff upstream/main...pr/magic-akari/7182 fails with fatal: upstream/main...pr/magic-akari/7182: no merge base.
Can you try rebasing?

magic-akari · 2023-04-03T11:33:05Z

I checked it out, but git diff upstream/main...pr/magic-akari/7182 fails with fatal: upstream/main...pr/magic-akari/7182: no merge base. Can you try rebasing?

Done.
I have split the test cases commits.

kdy1 · 2023-04-03T11:41:25Z

It didn't work, but I think I can review it using cli tools now

packages/swc-helpers/.dprint.json

packages/swc-helpers/esm/_update.js

- named export - unified import path

kdy1

Thank you! I'll update swc/fixture and swc/tsc soon

swc-bump:

swc_ecma_utils
swc_ecma_transforms_base --breaking

swc-bot

Automated review comment generated by auto-rebase script

magic-akari force-pushed the swc-helpers branch from c09e926 to 88036a5 Compare March 31, 2023 14:19

magic-akari marked this pull request as ready for review March 31, 2023 14:19

kdy1 reviewed Apr 1, 2023

View reviewed changes

magic-akari force-pushed the swc-helpers branch from 9edce72 to e4a3f60 Compare April 1, 2023 11:54

magic-akari requested a review from kdy1 April 1, 2023 14:24

kdy1 self-assigned this Apr 2, 2023

kdy1 added this to the Planned milestone Apr 2, 2023

kdy1 reviewed Apr 2, 2023

View reviewed changes

magic-akari force-pushed the swc-helpers branch 2 times, most recently from c9ccd08 to fdcdafc Compare April 3, 2023 11:30

kdy1 reviewed Apr 3, 2023

View reviewed changes

packages/swc-helpers/.dprint.json Outdated Show resolved Hide resolved

kdy1 reviewed Apr 3, 2023

View reviewed changes

packages/swc-helpers/esm/_update.js Outdated Show resolved Hide resolved

magic-akari added 6 commits April 4, 2023 11:10

feat(swc-helpers): Implement new @swc/helpers

4f7be66

- named export - unified import path

chore: update node-swc test cases

777aeef

chore: update swc_ecma_transforms_base test cases

4f9b3ea

chore: update swc_ecma_transforms_module test cases

c1da3ae

chore: update vercel test cases

ae3b052

chore: ignore .dprint.json

5b8116e

kdy1 force-pushed the swc-helpers branch from ab0af63 to 5b8116e Compare April 4, 2023 02:10

kdy1 previously approved these changes Apr 4, 2023

View reviewed changes

kdy1 enabled auto-merge (squash) April 4, 2023 02:20

kdy1 added 2 commits April 4, 2023 11:22

Update test refs

4385caa

Update test refs

508cf1f

kdy1 dismissed their stale review via 508cf1f April 4, 2023 02:22

kdy1 approved these changes Apr 4, 2023

View reviewed changes

Merge branch 'main' into swc-helpers

454edb2

swc-bot reviewed Apr 4, 2023

View reviewed changes

kdy1 merged commit a13a78e into swc-project:main Apr 4, 2023
127 checks passed

kdy1 modified the milestones: Planned, v1.3.45 Apr 4, 2023

freben mentioned this pull request Apr 6, 2023

fix(deps): update dependency @swc/helpers to ^0.5.0 backstage/backstage#17269

Merged

1 task

magic-akari deleted the swc-helpers branch April 7, 2023 02:31

underfin mentioned this pull request Apr 7, 2023

chore: bump swc 0.74.6 web-infra-dev/rspack#2657

Merged

7 tasks

Skn0tt mentioned this pull request Apr 27, 2023

feat: split up API Routes + use .nft.json files to make builds fast netlify/next-runtime#2058

Merged

2 tasks

swc-project locked as resolved and limited conversation to collaborators May 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement new `@swc/helpers` #7182

Implement new `@swc/helpers` #7182

magic-akari commented Mar 31, 2023 •

edited

kdy1 Apr 1, 2023

magic-akari Apr 1, 2023

kdy1 Apr 1, 2023

magic-akari Apr 1, 2023

magic-akari Apr 1, 2023

magic-akari Apr 1, 2023 •

edited

kdy1 Apr 2, 2023

magic-akari Apr 2, 2023

magic-akari Apr 2, 2023

kdy1 Apr 2, 2023

magic-akari Apr 2, 2023

kdy1 Apr 2, 2023

kdy1 commented Apr 3, 2023

magic-akari commented Apr 3, 2023

kdy1 commented Apr 3, 2023

magic-akari commented Apr 3, 2023 •

edited

kdy1 commented Apr 3, 2023

magic-akari commented Apr 3, 2023

kdy1 commented Apr 3, 2023

kdy1 left a comment

swc-bot left a comment

		@@ -1,4 +1,4 @@
		import _ts_generator from "@swc/helpers/src/_ts_generator.mjs";
		import { _ts_generator } from "@swc/helpers/_/_ts_generator";

Implement new @swc/helpers #7182

Implement new @swc/helpers #7182

Conversation

magic-akari commented Mar 31, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magic-akari Apr 1, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kdy1 commented Apr 3, 2023

magic-akari commented Apr 3, 2023

kdy1 commented Apr 3, 2023

magic-akari commented Apr 3, 2023 • edited

kdy1 commented Apr 3, 2023

magic-akari commented Apr 3, 2023

kdy1 commented Apr 3, 2023

kdy1 left a comment

Choose a reason for hiding this comment

swc-bot left a comment

Choose a reason for hiding this comment

Implement new `@swc/helpers` #7182

Implement new `@swc/helpers` #7182

magic-akari commented Mar 31, 2023 •

edited

magic-akari Apr 1, 2023 •

edited

magic-akari commented Apr 3, 2023 •

edited