Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make helpers an optional peer dependency of core #7216

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Apr 5, 2023

Description:

Mark the @swc/helpers dependency of @swc/core as optional.

BREAKING CHANGE:

Related issue (if exists):

Closes #7212

@mischnic mischnic changed the title Add peerDependenciesMeta for helpers Make helpers an optional peer dependency of core Apr 5, 2023
kdy1
kdy1 previously approved these changes Apr 5, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • dbg-swc

@kdy1 kdy1 added this to the Planned milestone Apr 5, 2023
@kdy1
Copy link
Member

kdy1 commented Apr 5, 2023

Can you run yarn again?

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 merged commit e86d598 into swc-project:main Apr 6, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.47 Apr 10, 2023
@mischnic mischnic deleted the patch-1 branch April 11, 2023 19:41
@swc-project swc-project locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@swc/core peerDependency of @swc/helpers is not optional
2 participants