Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es): Fix a crash related to an empty source map #7229

Merged
merged 2 commits into from Apr 10, 2023
Merged

fix(es): Fix a crash related to an empty source map #7229

merged 2 commits into from Apr 10, 2023

Conversation

chenyukang
Copy link
Contributor

Description:

BREAKING CHANGE:

Related issue (if exists):
Fixes #7035

@chenyukang
Copy link
Contributor Author

seems we don't have tests for swc_cli now.

@realtimetodie
Copy link
Contributor

LGTM

@kdy1 kdy1 added this to the Planned milestone Apr 10, 2023
kdy1
kdy1 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc

@kdy1 kdy1 enabled auto-merge (squash) April 10, 2023 02:58
@kdy1 kdy1 disabled auto-merge April 10, 2023 03:14
@kdy1 kdy1 changed the title fix(bindings/swc_cli) fix crash issue for empty source map fix(es): Fix a crash related to an empty source map Apr 10, 2023
@kdy1 kdy1 enabled auto-merge (squash) April 10, 2023 08:06
swc-bot
swc-bot reviewed Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit c665918 into swc-project:main Apr 10, 2023
128 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.50 Apr 13, 2023
kdy1 added a commit to kdy1/swc that referenced this pull request Apr 21, 2023
@kdy1
Revert swc-project#7229
cdd0a92
@kdy1 kdy1 mentioned this pull request Apr 21, 2023
Merged
kdy1 added a commit that referenced this pull request Apr 21, 2023
@kdy1
fix(es): Fix a crash related to source map (#7307)
e7f7b01 
**Related issue:**

 - Reverts #7229.
 - Closes #7301.
@swc-project swc-project locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kwonoj kwonoj kwonoj approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.50
5 participants
@chenyukang @realtimetodie @kwonoj @kdy1 @swc-bot