Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/helpers): Do not duplicate property names #7266

Merged
merged 3 commits into from
Apr 15, 2023
Merged

fix(es/helpers): Do not duplicate property names #7266

merged 3 commits into from
Apr 15, 2023
+5 −3

Conversation

magic-akari
Copy link
Member

Description:

This pattern works in cjs-module-lexer as well. And it's valid synatx in es5 strict mode.

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review April 14, 2023 10:53
kdy1
kdy1 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

swc-bump:

  • dbg-swc

@kdy1 kdy1 added this to the Planned milestone Apr 14, 2023
@kdy1 kdy1 enabled auto-merge (squash) April 14, 2023 22:19
swc-bot
swc-bot reviewed Apr 15, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 30a4e52 into swc-project:main Apr 15, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.51 Apr 15, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators May 16, 2023
@magic-akari magic-akari deleted the fix/issue-7264 branch September 18, 2023 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kdy1 kdy1

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.51
Development

Successfully merging this pull request may close these issues.

@swc/helpers does not pass npx es-check@7.0.1 es5
3 participants
@magic-akari @kdy1 @swc-bot