Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/module): Don't resolve as node_modules from TscResolver #7866

Merged
merged 5 commits into from Aug 25, 2023
Merged

fix(es/module): Don't resolve as node_modules from TscResolver #7866

merged 5 commits into from Aug 25, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 25, 2023

@kdy1 kdy1 added this to the Planned milestone Aug 25, 2023
@kdy1 kdy1 self-assigned this Aug 25, 2023
@kdy1 kdy1 marked this pull request as ready for review August 25, 2023 13:06
@kdy1 kdy1 enabled auto-merge (squash) August 25, 2023 13:06
kdy1
kdy1 commented Aug 25, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_loader

kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 25, 2023
View reviewed changes
@kdy1 kdy1 modified the milestones: Planned, v1.3.80 Aug 25, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 25, 2023
View reviewed changes
@kdy1 kdy1 disabled auto-merge August 25, 2023 13:16
@kdy1 kdy1 enabled auto-merge (squash) August 25, 2023 13:22
@DanRibbens DanRibbens mentioned this pull request Aug 25, 2023
Closed
@kdy1 kdy1 disabled auto-merge August 25, 2023 13:46
@kdy1 kdy1 merged commit 11ebae1 into swc-project:main Aug 25, 2023
128 checks passed
@kdy1 kdy1 deleted the issue-7863 branch August 25, 2023 13:46
@kdy1
Copy link
Member Author

kdy1 commented Aug 25, 2023

Let's wait for https://github.com/swc-project/swc/actions/runs/5976742103

@m-nouman-munir
Copy link

Ok

@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.80
Development

Successfully merging this pull request may close these issues.

When using @swc/helpers with @swc/core 1.3.79, the build output path has added node_modules.
2 participants
@kdy1 @m-nouman-munir