fix(css/ast): Make .hash() of Token not recursive
#8151
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
stormslowly
force-pushed
the
fix/css_token_hash_stack_overflow
branch
from
dd2f6eb to
a6c6f22
Compare
kdy1
changed the title
.hash of Token not recursive
kdy1
changed the title
.hash of Token not recursive.hash() of Token not recursive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
when hash a stylesheet ast, it will trigger stack overflow.
the root cause is that ,
Token'shashfunction recursively call itself.BREAKING CHANGE:
No
Related issue (if exists):
#8142