Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css/ast): Make .hash() of Token not recursive #8151

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(css/ast): Make .hash() of Token not recursive #8151

merged 1 commit into from
Oct 19, 2023

Conversation

stormslowly
Copy link
Contributor

Description:

when hash a stylesheet ast, it will trigger stack overflow.
the root cause is that , Token's hash function recursively call itself.

BREAKING CHANGE:
No

Related issue (if exists):

#8142

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@stormslowly stormslowly force-pushed the fix/css_token_hash_stack_overflow branch from dd2f6eb to a6c6f22 Compare October 19, 2023 16:29
kdy1
kdy1 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_ast

@kdy1 kdy1 changed the title refactor: 🔥 remove css token hash dead loop fix(css/ast): Make .hash of Token not recursive Oct 19, 2023
@kdy1 kdy1 added this to the Planned milestone Oct 19, 2023
@kdy1 kdy1 changed the title fix(css/ast): Make .hash of Token not recursive fix(css/ast): Make .hash() of Token not recursive Oct 19, 2023
@kdy1 kdy1 enabled auto-merge (squash) October 19, 2023 16:48
@kdy1 kdy1 merged commit 8d7894c into swc-project:main Oct 19, 2023
144 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.94 Oct 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.94
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stormslowly @CLAassistant @kdy1