Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Instantiation expr can be followed by line break or binary operator #5000

Merged
merged 1 commit into from
Jun 19, 2022
Merged

fix(es/parser): Instantiation expr can be followed by line break or binary operator #5000

merged 1 commit into from
Jun 19, 2022

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Jun 19, 2022 •
edited

Description:

Allow the code below:

const x2 = f<true>  // becomes instantiation expression
true;

f<x> && g<y>;

BREAKING CHANGE:

No.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jun 19, 2022
kdy1
kdy1 approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 enabled auto-merge (squash) June 19, 2022 17:51
@kdy1 kdy1 merged commit a62b2b3 into swc-project:main Jun 19, 2022
@g-plane g-plane deleted the parsing-instantiation-expr branch June 19, 2022 23:57
@kdy1 kdy1 modified the milestones: Planned, v1.2.205 Jun 24, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.205
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@g-plane @kdy1