Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/resolver): Resolve parameters correctly #6890

Merged
merged 17 commits into from Feb 1, 2023
Merged

fix(es/resolver): Resolve parameters correctly #6890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
929659c
Add a test
kdy1 Feb 1, 2023
7fdba15
Sort
kdy1 Feb 1, 2023
e016d77
Add a test
kdy1 Feb 1, 2023
1e7e5b8
Update test refs
kdy1 Feb 1, 2023
a894ad2
params
kdy1 Feb 1, 2023
18acdd8
WIP
kdy1 Feb 1, 2023
ea38a82
Fix
kdy1 Feb 1, 2023
3143ea2
Remove dbg
kdy1 Feb 1, 2023
6d6eb1f
WIP: Fix regression
kdy1 Feb 1, 2023
2b0738b
Imports
kdy1 Feb 1, 2023
9b8fc70
Done
kdy1 Feb 1, 2023
d4e3b1e
Update test refs
kdy1 Feb 1, 2023
1c68688
Fix
kdy1 Feb 1, 2023
7e6118d
Update test refs
kdy1 Feb 1, 2023
51c0e08
Merge branch 'main' into stc
kdy1 Feb 1, 2023
085d646
Exclude rest
kdy1 Feb 1, 2023
255c73f
Update test refs
kdy1 Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/swc/tests/tsc-references/destructuringArrayBindingPatternAndAssignment3.1.normal.js
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@ var _ref2 = [
1
]);
(function(param) {
var _param = _sliced_to_array(param, 4), f = _param[0], tmp = _param[1], g = tmp === void 0 ? f : tmp, tmp1 = _param[2], h = tmp1 === void 0 ? i : tmp1, tmp2 = _param[3], i1 = tmp2 === void 0 ? f : tmp2;
var _param = _sliced_to_array(param, 4), f = _param[0], tmp = _param[1], g = tmp === void 0 ? f : tmp, tmp1 = _param[2], h = tmp1 === void 0 ? i : tmp1, tmp2 = _param[3], i = tmp2 === void 0 ? f : tmp2;
})([
1
]);
2 changes: 1 addition & 1 deletion crates/swc/tests/tsc-references/functionImplementationErrors.1.normal.js
View file
Open in desktop
Expand Up @@ -37,7 +37,7 @@ function f6() {
}
// Function signature with initializer referencing other parameter to the right
function f7() {
var n = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : m, m1 = arguments.length > 1 ? arguments[1] : void 0;
var n = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : m, m = arguments.length > 1 ? arguments[1] : void 0;
}
// FunctionExpression with non -void return type annotation with a throw, no return, and other code
// Should be error but isn't
Expand Down
18 changes: 9 additions & 9 deletions crates/swc/tests/tsc-references/parameterInitializersForwardReferencing.1.normal.js
View file
Open in desktop
Expand Up @@ -6,15 +6,15 @@ function left(a) {
b1;
}
function right() {
var a = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : b, _$b = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : a;
var a = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : b1, b1 = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : a;
a;
_$b;
b1;
}
function right2() {
var a = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : b, _$b = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : c, _$c = arguments.length > 2 && arguments[2] !== void 0 ? arguments[2] : a;
var a = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : b1, b1 = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : c1, c1 = arguments.length > 2 && arguments[2] !== void 0 ? arguments[2] : a;
a;
_$b;
_$c;
b1;
c1;
}
function inside() {
var a = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : b;
Expand All @@ -29,13 +29,13 @@ function outside() {
}
function defaultArgFunction() {
var a = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : function() {
return b;
return b1;
}, b1 = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : 1;
}
function defaultArgArrow() {
var a = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : function() {
return function() {
return b;
return b1;
};
}, b1 = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : 3;
}
Expand All @@ -47,7 +47,7 @@ var C = /*#__PURE__*/ function() {
}
var _proto = C.prototype;
_proto.method = function method() {
var a = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : b, _$b = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : 1;
var a = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : b1, b1 = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : 1;
};
return C;
}();
Expand All @@ -59,6 +59,6 @@ var x = function() {
// Should not produce errors - can reference later parameters if they occur within a function expression initializer.
function f(a) {
var b1 = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : function() {
return c;
return c1;
}, c1 = arguments.length > 2 && arguments[2] !== void 0 ? arguments[2] : b1();
}
2 changes: 1 addition & 1 deletion crates/swc/tests/tsc-references/parameterInitializersForwardReferencing1.1.normal.js
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ function f2() {
return bar(); // returns 1
}
function f3() {
var bar = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : foo, foo1 = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : 2;
var bar = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : foo, foo = arguments.length > 1 && arguments[1] !== void 0 ? arguments[1] : 2;
return bar;
}
function f4(foo) {
Expand Down
2 changes: 1 addition & 1 deletion crates/swc/tests/tsc-references/parameterInitializersForwardReferencing1_es6.1.normal.js
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@ function f2(bar = (baz = foo)=>baz) {
var foo1 = 2;
return bar(); // returns 1
}
function f3(bar = foo, foo1 = 2) {
function f3(bar = foo, foo = 2) {
return bar;
}
function f4(foo, bar = foo) {
Expand Down