Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Handle export function in reserved_word #7251

Merged
merged 2 commits into from Apr 12, 2023
Merged

fix(es/compat): Handle export function in reserved_word #7251

merged 2 commits into from Apr 12, 2023

Conversation

magic-akari
Copy link
Member

Description:

There is a similar case with exported class.
But I do not believe that class will be preserved in es3 phase.

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review April 12, 2023 06:32
kdy1
kdy1 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 added this to the Planned milestone Apr 12, 2023
@kdy1 kdy1 enabled auto-merge (squash) April 12, 2023 11:44
@kdy1 kdy1 merged commit 2e947e7 into swc-project:main Apr 12, 2023
126 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.50 Apr 13, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators May 13, 2023
@magic-akari magic-akari deleted the fix/issue-7237 branch September 18, 2023 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.50
Development

Successfully merging this pull request may close these issues.

after compiled: export keyword “char” has been replaced like "_char", but import still use "char"
2 participants
@magic-akari @kdy1