Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(atoms): Remove usage of js_word! to drop string-cache #7976

Merged
merged 342 commits into from
Oct 8, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 20, 2023

Description:

This PR is to prepare removal of string-cache. Actually, this PR does not remove it. Instead, this PR only removes direct usages of js_word!s, especially in patterns.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Sep 20, 2023
@kdy1 kdy1 self-assigned this Sep 20, 2023
@kdy1 kdy1 force-pushed the str-type branch 4 times, most recently from f1db1ef to 3ceef25 Compare October 7, 2023 03:26
@kdy1 kdy1 changed the title refactor(atoms): Prepare swapping string-cache refactor(atoms): Prepare dropping string-cache Oct 7, 2023
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_atoms --breaking

@kdy1 kdy1 changed the title refactor(atoms): Prepare dropping string-cache refactor(atoms): Remove usage of js_word! to drop string-cache Oct 7, 2023
@kdy1 kdy1 marked this pull request as ready for review October 8, 2023 00:39
@kdy1 kdy1 merged commit 84cec87 into swc-project:main Oct 8, 2023
15 of 18 checks passed
@kdy1 kdy1 deleted the str-type branch October 8, 2023 00:39
@kdy1 kdy1 modified the milestones: Planned, v1.3.93 Oct 13, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant