Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/module): support resolving exports from package.json #8276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eandre
Copy link

@eandre eandre commented Nov 12, 2023

This adds support in swc_ecma_resolver::node::NodeModulesResolver to resolve import paths from the exports field in package.json. This is needed to resolve the correct file path for packages that use exports.

By default it uses the export conditions based on the TargetEnv. It also adds a new constructor NodeModulesResolver::with_export_conditions that allows adding additional conditions.

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests

@kdy1 kdy1 added this to the Planned milestone Nov 13, 2023
@eandre eandre requested a review from a team as a code owner April 29, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants