Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make expr_simplifier handle expressions when indexing strings, arrays and objects #8750

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft

Make expr_simplifier handle expressions when indexing strings, arrays and objects #8750

wants to merge 64 commits into from

Commits on Mar 15, 2024

  1. Initial commit: string literals

    @levi-nz
    levi-nz committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    84ec94e View commit details
    Browse the repository at this point in the history

  2. WIP: array literals

    @levi-nz
    levi-nz committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7f02ace View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Correctly handle array indexing

    @levi-nz
    levi-nz committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    2b94d3d View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Update unit test

    @levi-nz
    levi-nz committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    efec60b View commit details
    Browse the repository at this point in the history

  2. Fix broken index logic

    @levi-nz
    levi-nz committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    72537ac View commit details
    Browse the repository at this point in the history

  3. Fix indexing ObjectLits

    @levi-nz
    levi-nz committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    454378d View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Remove fraction check from LiteralVisitor

    @levi-nz
    levi-nz committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    9b26630 View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @levi-nz
    levi-nz committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    677a437 View commit details
    Browse the repository at this point in the history

  3. Update test files

    @levi-nz
    levi-nz committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3aa713e View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Handle x['0']

    @levi-nz
    levi-nz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    8450f8b View commit details
    Browse the repository at this point in the history

  2. Don't return KnownOp::Len if obj is an ObjectLiteral

    @levi-nz
    levi-nz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    2b8709f View commit details
    Browse the repository at this point in the history

  3. Handle x['length']

    @levi-nz
    levi-nz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    dd4336b View commit details
    Browse the repository at this point in the history

  4. Correctly handle builtin properties

    @levi-nz
    levi-nz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    2fe5f09 View commit details
    Browse the repository at this point in the history

  5. Don't replace ArrayLiteral if doing so may have side effects

    @levi-nz
    levi-nz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    c902739 View commit details
    Browse the repository at this point in the history

  6. Update unit test

    @levi-nz
    levi-nz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    b4455c9 View commit details
    Browse the repository at this point in the history

  7. Update minifier test files

    @levi-nz
    levi-nz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    ae673de View commit details
    Browse the repository at this point in the history

  8. cargo fmt

    @levi-nz
    levi-nz committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    4143a27 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Minifier shouldn't handle potential pristine_globals cases

    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    4b151fc View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    c154047 View commit details
    Browse the repository at this point in the history

  3. Update test files

    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    647cfd3 View commit details
    Browse the repository at this point in the history

  4. Don't add a dummy value if no side effects exist

    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    9c9d141 View commit details
    Browse the repository at this point in the history

  5. Update test files

    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    4424755 View commit details
    Browse the repository at this point in the history

  6. Oops

    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    96a1c0b View commit details
    Browse the repository at this point in the history

  7. Update unit test 

    The previous commit makes the whole array get replaced by just `f()`, which is correct, but we need a better case now
    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    5104b9a View commit details
    Browse the repository at this point in the history

  8. Add test case for side effects

    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    bfd376b View commit details
    Browse the repository at this point in the history

  9. Add compression for MemberExpr

    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    9296237 View commit details
    Browse the repository at this point in the history

  10. cargo fmt

    @levi-nz
    levi-nz committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    2b26790 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. String does not appear to inherit Function

    @levi-nz
    levi-nz committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    4f2c69f View commit details
    Browse the repository at this point in the history

  2. Array also does not inherit Function

    @levi-nz
    levi-nz committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    43fe050 View commit details
    Browse the repository at this point in the history

  3. Remove comment

    @levi-nz
    levi-nz committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    70f6f64 View commit details
    Browse the repository at this point in the history

  4. FUNCTION_SYMBOLS is no longer required

    @levi-nz
    levi-nz committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d19e907 View commit details
    Browse the repository at this point in the history

  5. Add unit test files

    @levi-nz
    levi-nz committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    10c4681 View commit details
    Browse the repository at this point in the history

  6. Update test files

    @levi-nz
    levi-nz committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    240713a View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Update test config

    @levi-nz
    levi-nz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ec03388 View commit details
    Browse the repository at this point in the history

  2. Better test dir names

    @levi-nz
    levi-nz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    bfcb5cf View commit details
    Browse the repository at this point in the history

  3. Remove evil clone

    @levi-nz
    levi-nz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    17439b9 View commit details
    Browse the repository at this point in the history

  4. I don't know why this changed, but it did.

    @levi-nz
    levi-nz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    67474ef View commit details
    Browse the repository at this point in the history

  5. Add array side effect unit test

    @levi-nz
    levi-nz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c92508f View commit details
    Browse the repository at this point in the history

  6. Don't optimize if inside left-hand side of AssignExpr

    @levi-nz
    levi-nz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9407838 View commit details
    Browse the repository at this point in the history

  7. Remove redundant import

    @levi-nz
    levi-nz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    942a343 View commit details
    Browse the repository at this point in the history

  8. Move call to end

    @levi-nz
    levi-nz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5424fed View commit details
    Browse the repository at this point in the history

  9. Cleanup iterator call

    @levi-nz
    levi-nz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c6029c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Handle side effects and __proto__ in object compression

    @levi-nz
    levi-nz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ea89ec2 View commit details
    Browse the repository at this point in the history

  2. Remove redundant return statement

    @levi-nz
    levi-nz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    976ddb7 View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @levi-nz
    levi-nz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a819d98 View commit details
    Browse the repository at this point in the history

  4. Remove redundant Box::new call

    @levi-nz
    levi-nz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b41617c View commit details
    Browse the repository at this point in the history

  5. Use preserve_effects

    @levi-nz
    levi-nz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a5df0a5 View commit details
    Browse the repository at this point in the history

  6. cargo fmt

    @levi-nz
    levi-nz committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    e47bff3 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Exclude watch and unwatch

    @levi-nz
    levi-nz committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    52dfab4 View commit details
    Browse the repository at this point in the history

  2. UPDATE=1 cargo test --test projects --test tsc

    @levi-nz
    levi-nz committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4a1b6db View commit details
    Browse the repository at this point in the history

  3. UPDATE=1 cargo test -p swc_ecma_minifier --features concurrent

    @levi-nz
    levi-nz committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    d4696ed View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. git merge upstream/main issue-8747

    @levi-nz
    levi-nz committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7dba5ac View commit details
    Browse the repository at this point in the history

  2. Remove redundant import

    @levi-nz
    levi-nz committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    00cb04f View commit details
    Browse the repository at this point in the history

  3. Fix test_fold_array_lit_spread_get_elem

    @levi-nz
    levi-nz committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6477fbf View commit details
    Browse the repository at this point in the history

  4. Fix test_fold_get_elem1

    @levi-nz
    levi-nz committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9b5239d View commit details
    Browse the repository at this point in the history

  5. Add self.changed = true;

    @levi-nz
    levi-nz committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f3cfa71 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Use ctx

    @levi-nz
    levi-nz committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b8cd66b View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Fix doc

    @levi-nz
    levi-nz committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b2a2cc6 View commit details
    Browse the repository at this point in the history

  2. Handle SeqExpr in optimize_member_expr

    @levi-nz
    levi-nz committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5458077 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Remove dup self.changed = true;

    @levi-nz
    levi-nz committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5e1819f View commit details
    Browse the repository at this point in the history

  2. git merge upstream/main issue-8747

    @levi-nz
    levi-nz committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4a2d3a9 View commit details
    Browse the repository at this point in the history

  3. Apply clippy suggestions

    @levi-nz
    levi-nz committed May 10, 2024
    Configuration menu
    Copy the full SHA
    45d23d3 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. Cleanup optimize_member_expr 

    This fixes unit tests being stuck running for 60s+
    @levi-nz
    levi-nz committed May 12, 2024
    Configuration menu
    Copy the full SHA
    52869c4 View commit details
    Browse the repository at this point in the history

  2. Fix optimization tests

    @levi-nz
    levi-nz committed May 12, 2024
    Configuration menu
    Copy the full SHA
    aa42961 View commit details
    Browse the repository at this point in the history