fix(es/minifier): don't reserve identifiers in expressions or patterns #8883
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auspicus
changed the title
kdy1
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
#3424 added support for the
reservedmangle option which prevents identifiers from being mangled when listed in the array. This is fine in most cases but can cause issues when the compressor brings two reserved variables into the same scope. When this occurs the generated code results in a parsing error due to the duplicate identifier.This PR adds a test to cover this case and a proposed fix by ignoring reserved identifiers for patterns and expressions.
BREAKING CHANGE:
Related issue (if exists):
fixes #8622